* [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding
2020-05-14 16:38 ` [PATCH v2 0/7] ASoC: QCOM: Add support for SC7180 lpass variant Ajit Pandey
@ 2020-05-14 16:38 ` Ajit Pandey
2020-05-14 16:44 ` Mark Brown
0 siblings, 1 reply; 7+ messages in thread
From: Ajit Pandey @ 2020-05-14 16:38 UTC (permalink / raw
To: broonie, plai, bgoswami, srinivas.kandagatla
Cc: devicetree, alsa-devel, linux-kernel, Ajit Pandey
Done the required cleanups to update lpass-cpu binding with newer
yaml formats.
Signed-off-by: Ajit Pandey <ajitp@codeaurora.org>
---
.../devicetree/bindings/sound/qcom,lpass-cpu.txt | 79 -------------
.../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 131 +++++++++++++++++++++
2 files changed, 131 insertions(+), 79 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt
create mode 100644 Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt
deleted file mode 100644
index 32c2cdb..0000000
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt
+++ /dev/null
@@ -1,79 +0,0 @@
-* Qualcomm Technologies LPASS CPU DAI
-
-This node models the Qualcomm Technologies Low-Power Audio SubSystem (LPASS).
-
-Required properties:
-
-- compatible : "qcom,lpass-cpu" or "qcom,apq8016-lpass-cpu"
-- clocks : Must contain an entry for each entry in clock-names.
-- clock-names : A list which must include the following entries:
- * "ahbix-clk"
- * "mi2s-osr-clk"
- * "mi2s-bit-clk"
- : required clocks for "qcom,lpass-cpu-apq8016"
- * "ahbix-clk"
- * "mi2s-bit-clk0"
- * "mi2s-bit-clk1"
- * "mi2s-bit-clk2"
- * "mi2s-bit-clk3"
- * "pcnoc-mport-clk"
- * "pcnoc-sway-clk"
-
-- interrupts : Must contain an entry for each entry in
- interrupt-names.
-- interrupt-names : A list which must include the following entries:
- * "lpass-irq-lpaif"
-- pinctrl-N : One property must exist for each entry in
- pinctrl-names. See ../pinctrl/pinctrl-bindings.txt
- for details of the property values.
-- pinctrl-names : Must contain a "default" entry.
-- reg : Must contain an address for each entry in reg-names.
-- reg-names : A list which must include the following entries:
- * "lpass-lpaif"
-- #address-cells : Must be 1
-- #size-cells : Must be 0
-
-
-
-Optional properties:
-
-- qcom,adsp : Phandle for the audio DSP node
-
-By default, the driver uses up to 4 MI2S SD lines, for a total of 8 channels.
-The SD lines to use can be configured by adding subnodes for each of the DAIs.
-
-Required properties for each DAI (represented by a subnode):
-- reg : Must be one of the DAI IDs
- (usually part of dt-bindings header)
-- qcom,playback-sd-lines: List of serial data lines to use for playback
- Each SD line should be represented by a number from 0-3.
-- qcom,capture-sd-lines : List of serial data lines to use for capture
- Each SD line should be represented by a number from 0-3.
-
-Note that adding a subnode changes the default to "no lines configured",
-so both playback and capture lines should be configured when a subnode is added.
-
-Example:
-
-lpass@28100000 {
- compatible = "qcom,lpass-cpu";
- clocks = <&lcc AHBIX_CLK>, <&lcc MI2S_OSR_CLK>, <&lcc MI2S_BIT_CLK>;
- clock-names = "ahbix-clk", "mi2s-osr-clk", "mi2s-bit-clk";
- interrupts = <0 85 1>;
- interrupt-names = "lpass-irq-lpaif";
- pinctrl-names = "default", "idle";
- pinctrl-0 = <&mi2s_default>;
- pinctrl-1 = <&mi2s_idle>;
- reg = <0x28100000 0x10000>;
- reg-names = "lpass-lpaif";
- qcom,adsp = <&adsp>;
-
- #address-cells = <1>;
- #size-cells = <0>;
-
- /* Optional to set different MI2S SD lines */
- dai@3 {
- reg = <MI2S_QUATERNARY>;
- qcom,playback-sd-lines = <0 1>;
- };
-};
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
new file mode 100644
index 0000000..f2bcafc
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
@@ -0,0 +1,131 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/qcom,lpass-cpu.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm LPASS CPU dai driver bindings
+
+maintainers:
+ - Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
+ - Ajit Pandey <ajitp@codeaurora.org>
+
+description:
+ Qualcomm SOC Low-Power Audio SubSystem (LPASS) that consist of MI2S interface
+ for audio data transfer on external codecs. LPASS cpu driver is a module to
+ configure Low-Power Audio Interface(LPAIF) core registers across different
+ IP versions.
+
+properties:
+ compatible:
+ enum:
+ - qcom,lpass-cpu
+ - qcom,apq8016-lpass-cpu
+
+ reg:
+ items:
+ - description: LPAIF core registers
+
+ reg-names:
+ items:
+ - const: lpass-lpaif
+
+ clocks:
+ items:
+ - description: AHBIX core clock for IPQ806X
+ - description: oscillator clock for MI2S external interfaces
+ - description: Bit clock for single MI2S dai in IPQ806X
+ - description: Bit clock for MI2S_PRIMARY dai interface
+ - description: Bit clock for MI2S_SECONDARY dai interface
+ - description: Bit clock for MI2S_TERTIARY dai interface
+ - description: Bit clock for MI2S_QUATERNARY dai interface
+ - description: NOC MPORT clock of LPASS core
+ - description: NOC SWAY clock of LPASS core
+
+ clock-names:
+ items:
+ - const: ahbix-clk
+ - const: mi2s-osr-clk
+ - const: mi2s-bit-clk
+ - const: mi2s-bit-clk0
+ - const: mi2s-bit-clk1
+ - const: mi2s-bit-clk2
+ - const: mi2s-bit-clk3
+ - const: pcnoc-mport-clk
+ - const: pcnoc-sway-clk
+
+ interrupts:
+ items:
+ - description: LPAIF DMA buffer interrupt
+
+ interrupt-names:
+ items:
+ - const: lpass-irq-lpaif
+
+ qcom,adsp:
+ maxItems: 1
+ description: Phandle for the audio DSP node
+
+ '#sound-dai-cells':
+ const: 1
+
+ child-node:
+ description: Required properties for each DAI
+ type: object
+ properties:
+ reg:
+ description: Must be one of the DAI ID
+ (Usually part of dtbindings header)
+ qcom,playback-sd-lines:
+ description: List of serial data lines to use for playback
+ Each SD line should be represented by a number from 0-3.
+ qcom,capture-sd-lines :
+ description: List of serial data lines to use for capture
+ Each SD line should be represented by a number from 0-3.
+ required:
+ -reg
+ # Note that adding a subnode changes the default to "no lines configured",
+ # so both playback and capture lines should be configured when a subnode
+ # is added.
+
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - clocks
+ - clock-names
+ - interrupts
+ - interrupt-names
+ - sound-dai-cells
+
+optional:
+ - qcom,adsp
+
+examples:
+ lpass@28100000 {
+ compatible = "qcom,lpass-cpu";
+ clocks = <&lcc AHBIX_CLK>,
+ <&lcc MI2S_OSR_CLK>,
+ <&lcc MI2S_BIT_CLK>;
+
+ clock-names = "ahbix-clk",
+ "mi2s-osr-clk",
+ "mi2s-bit-clk";
+
+ interrupts = <0 85 1>;
+ interrupt-names = "lpass-irq-lpaif";
+
+ reg = <0x28100000 0x10000>;
+ reg-names = "lpass-lpaif";
+ #sound-dai-cells = <1>;
+ qcom,adsp = <&adsp>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* Optional to set different MI2S SD lines */
+ mi2s-quaternary@3 {
+ reg = <MI2S_QUATERNARY>;
+ qcom,playback-sd-lines = <0 1>;
+ };
--
('The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project')
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding
2020-05-14 16:38 ` [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding Ajit Pandey
@ 2020-05-14 16:44 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2020-05-14 16:44 UTC (permalink / raw
To: Ajit Pandey
Cc: devicetree, alsa-devel, bgoswami, plai, linux-kernel,
srinivas.kandagatla
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
On Thu, May 14, 2020 at 10:08:12PM +0530, Ajit Pandey wrote:
> Done the required cleanups to update lpass-cpu binding with newer
> yaml formats.
Please do YAML conversions as the last thing in any patch series, there
is quite a big backlog of reviews of YAML conversions so they can slow
down the code development. It's good to do them, just try to make sure
other patches don't depend on them.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding
@ 2020-05-16 17:37 ` Ajit Pandey
0 siblings, 0 replies; 7+ messages in thread
From: Ajit Pandey @ 2020-05-16 17:37 UTC (permalink / raw
To: Mark Brown
Cc: plai, bgoswami, srinivas.kandagatla, alsa-devel, devicetree,
linux-kernel
On 5/14/2020 10:14 PM, Mark Brown wrote:
> On Thu, May 14, 2020 at 10:08:12PM +0530, Ajit Pandey wrote:
>> Done the required cleanups to update lpass-cpu binding with newer
>> yaml formats.
> Please do YAML conversions as the last thing in any patch series, there
> is quite a big backlog of reviews of YAML conversions so they can slow
> down the code development. It's good to do them, just try to make sure
> other patches don't depend on them.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
Ok.. we'll do the yaml conversion as a separate patch chain so that it
won't block
merging of this feature in ASoC core.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding
@ 2020-05-16 17:37 ` Ajit Pandey
0 siblings, 0 replies; 7+ messages in thread
From: Ajit Pandey @ 2020-05-16 17:37 UTC (permalink / raw
To: Mark Brown
Cc: devicetree, alsa-devel, bgoswami, plai, linux-kernel,
srinivas.kandagatla
On 5/14/2020 10:14 PM, Mark Brown wrote:
> On Thu, May 14, 2020 at 10:08:12PM +0530, Ajit Pandey wrote:
>> Done the required cleanups to update lpass-cpu binding with newer
>> yaml formats.
> Please do YAML conversions as the last thing in any patch series, there
> is quite a big backlog of reviews of YAML conversions so they can slow
> down the code development. It's good to do them, just try to make sure
> other patches don't depend on them.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
Ok.. we'll do the yaml conversion as a separate patch chain so that it
won't block
merging of this feature in ASoC core.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding
@ 2020-07-06 11:29 Rohit Kumar
2020-07-06 11:44 ` Mark Brown
0 siblings, 1 reply; 7+ messages in thread
From: Rohit Kumar @ 2020-07-06 11:29 UTC (permalink / raw
To: Ajit Pandey, Mark Brown
Cc: devicetree, alsa-devel, bgoswami, plai, linux-kernel,
srinivas.kandagatla
On 5/16/2020 11:07 PM, Ajit Pandey wrote:
> On 5/14/2020 10:14 PM, Mark Brown wrote:
>> On Thu, May 14, 2020 at 10:08:12PM +0530, Ajit Pandey wrote:
>>> Done the required cleanups to update lpass-cpu binding with newer
>>> yaml formats.
>> Please do YAML conversions as the last thing in any patch series, there
>> is quite a big backlog of reviews of YAML conversions so they can slow
>> down the code development. It's good to do them, just try to make sure
>> other patches don't depend on them.
>>
>> Please submit patches using subject lines reflecting the style for the
>> subsystem, this makes it easier for people to identify relevant patches.
>> Look at what existing commits in the area you're changing are doing and
>> make sure your subject lines visually resemble what they're doing.
>> There's no need to resubmit to fix this alone.
>
> Ok.. we'll do the yaml conversion as a separate patch chain so that it
> won't block
>
> merging of this feature in ASoC core.
@Mark, I was planning to post v3 patchset series for this and keep yaml
change as
last patch in the series as suggested. However, we have one update in
the driver to
support another compatible string. If we keep Documentation change at
the last, the
driver change will have checkpatch errors. Can you please suggest if
should make
first Documentation change in text file itself before driver change and
finally have a
patch to convert it to yaml at the end?
Thanks,
Rohit
--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding
2020-07-06 11:29 Rohit Kumar
@ 2020-07-06 11:44 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2020-07-06 11:44 UTC (permalink / raw
To: Rohit Kumar
Cc: Ajit Pandey, devicetree, alsa-devel, bgoswami, plai, linux-kernel,
srinivas.kandagatla
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
On Mon, Jul 06, 2020 at 04:59:39PM +0530, Rohit Kumar wrote:
> @Mark, I was planning to post v3 patchset series for this and keep yaml
> change as
My name is Mark.
> driver change will have checkpatch errors. Can you please suggest if should
> make
> first Documentation change in text file itself before driver change and
> finally have a
> patch to convert it to yaml at the end?
As ever make the YAML conversion the very last thing you do in your
series so it doesn't hold anything else up.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding
@ 2020-07-06 11:44 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2020-07-06 11:44 UTC (permalink / raw
To: Rohit Kumar
Cc: devicetree, alsa-devel, bgoswami, plai, Ajit Pandey, linux-kernel,
srinivas.kandagatla
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
On Mon, Jul 06, 2020 at 04:59:39PM +0530, Rohit Kumar wrote:
> @Mark, I was planning to post v3 patchset series for this and keep yaml
> change as
My name is Mark.
> driver change will have checkpatch errors. Can you please suggest if should
> make
> first Documentation change in text file itself before driver change and
> finally have a
> patch to convert it to yaml at the end?
As ever make the YAML conversion the very last thing you do in your
series so it doesn't hold anything else up.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-07-06 11:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-16 17:37 [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding Ajit Pandey
2020-05-16 17:37 ` Ajit Pandey
-- strict thread matches above, loose matches on Subject: below --
2020-07-06 11:29 Rohit Kumar
2020-07-06 11:44 ` Mark Brown
2020-07-06 11:44 ` Mark Brown
[not found] <“1586592171-31644-1-git-send-email-ajitp@codeaurora.org”>
2020-05-14 16:38 ` [PATCH v2 0/7] ASoC: QCOM: Add support for SC7180 lpass variant Ajit Pandey
2020-05-14 16:38 ` [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding Ajit Pandey
2020-05-14 16:44 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.