From: Lucas Tanure <tanureal@opensource.cirrus.com>
To: Fae <faenkhauser@gmail.com>,
James Schulman <james.schulman@cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Sound: pci/hda: Add quirk for HP Envy x360 ey0xxx
Date: Thu, 11 Aug 2022 10:42:44 +0100 [thread overview]
Message-ID: <c671ad96-e1aa-4cda-eef1-fd8fe906ec36@opensource.cirrus.com> (raw)
In-Reply-To: <20220811053950.11810-1-faenkhauser@gmail.com>
On 8/11/22 06:39, Fae wrote:
> This patch fixes speaker output on the HP Envy x360 ey0xxx
> The mic/speaker mute LEDs are still non-functional but they aren't required for basic funtionality
>
> Also the quirk is labeled ALC287_FIXUP_CS35L41_I2C_2 however it does not only apply to ALC287
> Its function is the generic cs35l41 fixup telling the driver that there's 2 i2c speakers. It isn't actually specific to ALC287
>
> I did have a bit of luck getting the mic mute LED to work but it was to finicky to submit ( I used the ALC245_FIXUP_HP_GPIO_LED quirk )
> I had no luck getting the speaker mute LED to work
>
> Signed-off-by: Fae<faenkhauser@gmail.com>
> ---
> sound/pci/hda/cs35l41_hda.c | 3 ++-
> sound/pci/hda/patch_realtek.c | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
> index 129bffb431c22..21d8c2de128ff 100644
> --- a/sound/pci/hda/cs35l41_hda.c
> +++ b/sound/pci/hda/cs35l41_hda.c
> @@ -1156,7 +1156,8 @@ static int cs35l41_no_acpi_dsd(struct cs35l41_hda *cs35l41, struct device *physd
> hw_cfg->valid = true;
> put_device(physdev);
>
> - if (strncmp(hid, "CLSA0100", 8) == 0) {
> + if ((strncmp(hid, "CLSA0100", 8) == 0) ||
> + (strncmp(hid, "CSC3551", 7) == 0)) {
Sorry, but we can't accept this. The HID CSC3551 was created for a whole
range of laptops, with all types of Boost.
With this HID the driver expects to read configurations from the BIOS.
> hw_cfg->bst_type = CS35L41_EXT_BOOST_NO_VSPK_SWITCH;
> } else if (strncmp(hid, "CLSA0101", 8) == 0) {
> hw_cfg->bst_type = CS35L41_EXT_BOOST;
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 8a57636f622e9..e7053cbc6bb6e 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9179,6 +9179,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
> SND_PCI_QUIRK(0x103c, 0x841c, "HP Pavilion 15-CK0xx", ALC269_FIXUP_HP_MUTE_LED_MIC3),
> SND_PCI_QUIRK(0x103c, 0x8497, "HP Envy x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
> + SND_PCI_QUIRK(0x103c, 0x8a31, "HP ENVY x360 2-in-1 Laptop 15-ey0xxx", ALC287_FIXUP_CS35L41_I2C_2),
> SND_PCI_QUIRK(0x103c, 0x84da, "HP OMEN dc0019-ur", ALC295_FIXUP_HP_OMEN),
> SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),
> SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360),
next prev parent reply other threads:[~2022-08-11 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 5:39 [PATCH] Sound: pci/hda: Add quirk for HP Envy x360 ey0xxx Fae
2022-08-11 9:42 ` Lucas Tanure [this message]
2022-08-11 15:29 ` Fae
2023-02-02 2:12 ` Albert Tseng
2023-02-02 2:12 ` Albert Tseng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c671ad96-e1aa-4cda-eef1-fd8fe906ec36@opensource.cirrus.com \
--to=tanureal@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=david.rhodes@cirrus.com \
--cc=faenkhauser@gmail.com \
--cc=james.schulman@cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.