All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] drm/amdgpu: stream's id should reduced after stream destruct
       [not found] <20210220063038.1790398-1-zhangzhijie@loongson.cn>
  2021-02-22 19:24   ` Kazlauskas, Nicholas
@ 2021-02-22 19:24   ` Kazlauskas, Nicholas
  0 siblings, 0 replies; 3+ messages in thread
From: Kazlauskas, Nicholas @ 2021-02-22 19:24 UTC (permalink / raw
  To: ZhiJie.Zhang, alexander.deucher, airlied, daniel,
	christian.koenig
  Cc: mchehab+huawei, dri-devel, amd-gfx, linux-kernel

On 2021-02-20 1:30 a.m., ZhiJie.Zhang wrote:
> Signed-off-by: ZhiJie.Zhang <zhangzhijie@loongson.cn>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> index c103f858375d..dc7b7e57a86c 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> @@ -137,6 +137,8 @@ static void dc_stream_destruct(struct dc_stream_state *stream)
>   		dc_transfer_func_release(stream->out_transfer_func);
>   		stream->out_transfer_func = NULL;
>   	}
> +
> +	stream->ctx->dc_stream_id_count--;

This is supposed to be a unique identifier so we shouldn't be reusing 
any old ID when creating a new stream.

Regards,
Nicholas Kazlauskas

>   }
>   
>   void dc_stream_retain(struct dc_stream_state *stream)
> 

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/amdgpu: stream's id should reduced after stream destruct
@ 2021-02-22 19:24   ` Kazlauskas, Nicholas
  0 siblings, 0 replies; 3+ messages in thread
From: Kazlauskas, Nicholas @ 2021-02-22 19:24 UTC (permalink / raw
  To: ZhiJie.Zhang, alexander.deucher, airlied, daniel,
	christian.koenig
  Cc: mchehab+huawei, dri-devel, amd-gfx, linux-kernel

On 2021-02-20 1:30 a.m., ZhiJie.Zhang wrote:
> Signed-off-by: ZhiJie.Zhang <zhangzhijie@loongson.cn>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> index c103f858375d..dc7b7e57a86c 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> @@ -137,6 +137,8 @@ static void dc_stream_destruct(struct dc_stream_state *stream)
>   		dc_transfer_func_release(stream->out_transfer_func);
>   		stream->out_transfer_func = NULL;
>   	}
> +
> +	stream->ctx->dc_stream_id_count--;

This is supposed to be a unique identifier so we shouldn't be reusing 
any old ID when creating a new stream.

Regards,
Nicholas Kazlauskas

>   }
>   
>   void dc_stream_retain(struct dc_stream_state *stream)
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/amdgpu: stream's id should reduced after stream destruct
@ 2021-02-22 19:24   ` Kazlauskas, Nicholas
  0 siblings, 0 replies; 3+ messages in thread
From: Kazlauskas, Nicholas @ 2021-02-22 19:24 UTC (permalink / raw
  To: ZhiJie.Zhang, alexander.deucher, airlied, daniel,
	christian.koenig
  Cc: mchehab+huawei, amd-gfx, dri-devel, linux-kernel

On 2021-02-20 1:30 a.m., ZhiJie.Zhang wrote:
> Signed-off-by: ZhiJie.Zhang <zhangzhijie@loongson.cn>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> index c103f858375d..dc7b7e57a86c 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> @@ -137,6 +137,8 @@ static void dc_stream_destruct(struct dc_stream_state *stream)
>   		dc_transfer_func_release(stream->out_transfer_func);
>   		stream->out_transfer_func = NULL;
>   	}
> +
> +	stream->ctx->dc_stream_id_count--;

This is supposed to be a unique identifier so we shouldn't be reusing 
any old ID when creating a new stream.

Regards,
Nicholas Kazlauskas

>   }
>   
>   void dc_stream_retain(struct dc_stream_state *stream)
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-22 19:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20210220063038.1790398-1-zhangzhijie@loongson.cn>
2021-02-22 19:24 ` [PATCH] drm/amdgpu: stream's id should reduced after stream destruct Kazlauskas, Nicholas
2021-02-22 19:24   ` Kazlauskas, Nicholas
2021-02-22 19:24   ` Kazlauskas, Nicholas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.