* [PATCH 0/2] Improve code, codestyle in usb_ops_linux.c
@ 2015-02-27 16:39 Navya Sri Nizamkari
2015-02-27 16:40 ` [PATCH 1/2] staging: rtl8188eu: Compress two statements into one Navya Sri Nizamkari
2015-02-27 16:41 ` [PATCH 2/2] staging: rtl8188eu: Add blank line after declarations Navya Sri Nizamkari
0 siblings, 2 replies; 4+ messages in thread
From: Navya Sri Nizamkari @ 2015-02-27 16:39 UTC (permalink / raw
To: outreachy-kernel
This patchset improves the code in usb_ops_linux by removing
the use of a variable, adds a blank line after declarations
to improve code readability.
Navya Sri Nizamkari (2):
staging: rtl8188eu: Compress two statements into one.
staging: rtl8188eu: Add blank line after declarations
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] staging: rtl8188eu: Compress two statements into one.
2015-02-27 16:39 [PATCH 0/2] Improve code, codestyle in usb_ops_linux.c Navya Sri Nizamkari
@ 2015-02-27 16:40 ` Navya Sri Nizamkari
2015-02-27 18:24 ` [Outreachy kernel] " Julia Lawall
2015-02-27 16:41 ` [PATCH 2/2] staging: rtl8188eu: Add blank line after declarations Navya Sri Nizamkari
1 sibling, 1 reply; 4+ messages in thread
From: Navya Sri Nizamkari @ 2015-02-27 16:40 UTC (permalink / raw
To: outreachy-kernel
This patch removes the use of a variable used only for
returning a value. The following coccinelle script was
used to discover it:
@@
expression ret;
identifier f;
@@
-ret =
+return
f(...);
-return ret;
Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
---
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
index 80e7ef9..4c8cc2b 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
@@ -552,7 +552,6 @@ int usb_write8(struct adapter *adapter, u32 addr, u8 val)
u16 index;
u16 len;
u8 data;
- int ret;
request = 0x05;
requesttype = 0x00;/* write_out */
@@ -560,8 +559,7 @@ int usb_write8(struct adapter *adapter, u32 addr, u8 val)
wvalue = (u16)(addr&0x0000ffff);
len = 1;
data = val;
- ret = usbctrl_vendorreq(adapter, request, wvalue, index, &data, len, requesttype);
- return ret;
+ return usbctrl_vendorreq(adapter, request, wvalue, index, &data, len, requesttype);
}
int usb_write16(struct adapter *adapter, u32 addr, u16 val)
@@ -572,7 +570,6 @@ int usb_write16(struct adapter *adapter, u32 addr, u16 val)
u16 index;
u16 len;
__le32 data;
- int ret;
request = 0x05;
@@ -584,10 +581,9 @@ int usb_write16(struct adapter *adapter, u32 addr, u16 val)
data = cpu_to_le32(val & 0x0000ffff);
- ret = usbctrl_vendorreq(adapter, request, wvalue, index, &data, len, requesttype);
+ return usbctrl_vendorreq(adapter, request, wvalue, index, &data, len, requesttype);
- return ret;
}
int usb_write32(struct adapter *adapter, u32 addr, u32 val)
@@ -598,7 +594,6 @@ int usb_write32(struct adapter *adapter, u32 addr, u32 val)
u16 index;
u16 len;
__le32 data;
- int ret;
request = 0x05;
@@ -609,10 +604,9 @@ int usb_write32(struct adapter *adapter, u32 addr, u32 val)
len = 4;
data = cpu_to_le32(val);
- ret = usbctrl_vendorreq(adapter, request, wvalue, index, &data, len, requesttype);
+ return usbctrl_vendorreq(adapter, request, wvalue, index, &data, len, requesttype);
- return ret;
}
static void usb_write_port_complete(struct urb *purb, struct pt_regs *regs)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] staging: rtl8188eu: Add blank line after declarations
2015-02-27 16:39 [PATCH 0/2] Improve code, codestyle in usb_ops_linux.c Navya Sri Nizamkari
2015-02-27 16:40 ` [PATCH 1/2] staging: rtl8188eu: Compress two statements into one Navya Sri Nizamkari
@ 2015-02-27 16:41 ` Navya Sri Nizamkari
1 sibling, 0 replies; 4+ messages in thread
From: Navya Sri Nizamkari @ 2015-02-27 16:41 UTC (permalink / raw
To: outreachy-kernel
This patch removes the following checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
---
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
index 4c8cc2b..51a52e4 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
@@ -530,6 +530,7 @@ void usb_read_port_cancel(struct adapter *padapter)
{
int i;
struct recv_buf *precvbuf;
+
precvbuf = (struct recv_buf *)padapter->recvpriv.precv_buf;
DBG_88E("%s\n", __func__);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8188eu: Compress two statements into one.
2015-02-27 16:40 ` [PATCH 1/2] staging: rtl8188eu: Compress two statements into one Navya Sri Nizamkari
@ 2015-02-27 18:24 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2015-02-27 18:24 UTC (permalink / raw
To: Navya Sri Nizamkari; +Cc: outreachy-kernel
> - ret = usbctrl_vendorreq(adapter, request, wvalue, index, &data, len, requesttype);
> - return ret;
> + return usbctrl_vendorreq(adapter, request, wvalue, index, &data, len, requesttype);
Consider fixing the 80 character problem at the same time.
julia
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-27 18:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-27 16:39 [PATCH 0/2] Improve code, codestyle in usb_ops_linux.c Navya Sri Nizamkari
2015-02-27 16:40 ` [PATCH 1/2] staging: rtl8188eu: Compress two statements into one Navya Sri Nizamkari
2015-02-27 18:24 ` [Outreachy kernel] " Julia Lawall
2015-02-27 16:41 ` [PATCH 2/2] staging: rtl8188eu: Add blank line after declarations Navya Sri Nizamkari
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.