From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2ADE4C43334 for ; Fri, 1 Jul 2022 12:06:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 77F1984474; Fri, 1 Jul 2022 14:06:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id AC2CF84476; Fri, 1 Jul 2022 14:06:29 +0200 (CEST) Received: from mail-m118111.qiye.163.com (mail-m118111.qiye.163.com [115.236.118.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 34A5684440 for ; Fri, 1 Jul 2022 14:06:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m118111.qiye.163.com (Hmail) with ESMTPA id 4A8975801A4; Fri, 1 Jul 2022 20:05:59 +0800 (CST) Message-ID: Date: Fri, 1 Jul 2022 20:05:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling Content-Language: en-US To: Lee Jones , sjg@chromium.org, philipp.tomsich@vrull.eu Cc: cym@rock-chips.com, u-boot@lists.denx.de References: <20220621100729.979275-1-lee.jones@linaro.org> From: Kever Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJSktLSjdXWS1ZQUlXWQ8JGhUIEh9ZQVkZQh0YVkxOGEhKSk1KHx4aTlUTARMWGhIXJB QOD1lXWRgSC1lBWU5DVUlJVUxVSkpPWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NAw6CTo*UT0*EikKDj0VAwgw NAgaCzRVSlVKTU5NTUxMSk5CTE5MVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFJT0NLNwY+ X-HM-Tid: 0a81b9a752022eb7kusn4a8975801a4 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Lee Jones, On 2022/6/27 16:39, Lee Jones wrote: > On Tue, 21 Jun 2022, Lee Jones wrote: > >> Functions pointed to by this op pointer can return non-zero values >> indicating an error. Ensure any error value is propagated back up the >> call-chain. >> >> Signed-off-by: Lee Jones >> --- >> drivers/ram/rockchip/sdram_rk3399.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) > Weekly check-in: > > Are these still on someone's radar, or would you like me to [RESEND]? It would be better to add leading message "rockchip:" in the subject. Thanks, - Kever >> diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c >> index c0a06dcaed..0af0fa9e7b 100644 >> --- a/drivers/ram/rockchip/sdram_rk3399.c >> +++ b/drivers/ram/rockchip/sdram_rk3399.c >> @@ -3005,7 +3005,9 @@ static int sdram_init(struct dram_info *dram, >> params->base.stride = calculate_stride(params); >> dram_all_config(dram, params); >> >> - dram->ops->set_rate_index(dram, params); >> + ret = dram->ops->set_rate_index(dram, params); >> + if (ret) >> + return ret; >> >> debug("Finish SDRAM initialization...\n"); >> return 0;