From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To: linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
"Darrick J . Wong" <djwong@kernel.org>,
Ojaswin Mujoo <ojaswin@linux.ibm.com>,
Ritesh Harjani <ritesh.list@gmail.com>, Jan Kara <jack@suse.cz>
Subject: [RFCv3 0/7] ext2 iomap changes and iomap improvements
Date: Thu, 25 Apr 2024 18:58:44 +0530 [thread overview]
Message-ID: <cover.1714046808.git.ritesh.list@gmail.com> (raw)
Hello all,
Here is a RFCv3 which implements ext2 iomap changes and I have also included
some iomap improvements along with implementing BH_Boundary fix within iomap.
Posting this more as an update (before conference/call) to the current work
since it has survived few runs of xfstests -
Patch 1-4 implements ext2 regular file buffered I/O to use iomap APIs.
Patch 5 & 6 are iomap improvements which me and Ojaswin noticed during code reviews.
Patch 7 optimizes the data access patterns for filesystems with indirect block
mappings. Thanks to Matthew Wilcox for pointing the problem and providing a
rough solution to BH_Boundary problem within iomap (which this patch is based
on).
Please note that I would still like to work on following aspects before
thinking of merging any of these -
1. Look into how dir handling for ext2 should be handled. Since ext2 uses page
cache for that, can we directly use iomap? Do we need any other iomap ops for
implementing dir handling? Basically either a PoC or some theoretical
understanding of how we should handle dir for ext2.
2. Integrate Patch 4 within Patch-2. Kept it separate for review.
3. Test patch 5 & 6 separately before thinking of getting those merged. The
changes look ok to me and I would like those to be reviewed. But I hope to
get more testing done on those patches individually, because those are not
dependent on this series.
4. Patch 7 is an early RFC to get an idea on whether it is taking the right
direction or not. If this looks ok, then I can polish the series, carefully
review at any missed corner cases (hopefully I have covered all),
work on other points in this todo list and do more testing before posting
another version.
5. Write few fstests to excercise the paths more for the overall series.
Ritesh Harjani (IBM) (7):
ext2: Remove comment related to journal handle
ext2: Convert ext2 regular file buffered I/O to use iomap
ext2: Enable large folio support
ext2: Implement seq counter for validating cached iomap
iomap: Fix iomap_adjust_read_range for plen calculation
iomap: Optimize iomap_read_folio
iomap: Optimize data access patterns for filesystems with indirect mappings
fs/ext2/balloc.c | 1 +
fs/ext2/ext2.h | 6 ++
fs/ext2/file.c | 20 +++++-
fs/ext2/inode.c | 126 +++++++++++++++++++++++++++++++++++---
fs/ext2/super.c | 2 +-
fs/iomap/buffered-io.c | 135 ++++++++++++++++++++++++++++++++---------
6 files changed, 248 insertions(+), 42 deletions(-)
--
2.44.0
next reply other threads:[~2024-04-25 13:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 13:28 Ritesh Harjani (IBM) [this message]
2024-04-25 13:28 ` [RFCv3 1/7] ext2: Remove comment related to journal handle Ritesh Harjani (IBM)
2024-04-26 15:21 ` Darrick J. Wong
2024-04-25 13:28 ` [RFCv3 2/7] ext2: Convert ext2 regular file buffered I/O to use iomap Ritesh Harjani (IBM)
2024-04-26 15:29 ` Darrick J. Wong
2024-04-25 13:28 ` [RFCv3 3/7] ext2: Enable large folio support Ritesh Harjani (IBM)
2024-04-26 15:30 ` Darrick J. Wong
2024-04-25 13:28 ` [RFCv3 4/7] ext2: Implement seq counter for validating cached iomap Ritesh Harjani (IBM)
2024-04-26 15:41 ` Darrick J. Wong
2024-04-25 13:28 ` [RFCv3 5/7] iomap: Fix iomap_adjust_read_range for plen calculation Ritesh Harjani (IBM)
2024-04-26 6:49 ` Christoph Hellwig
2024-04-26 8:52 ` Ritesh Harjani
2024-04-26 15:43 ` Darrick J. Wong
2024-04-25 13:28 ` [RFCv3 6/7] iomap: Optimize iomap_read_folio Ritesh Harjani (IBM)
2024-04-25 13:53 ` Matthew Wilcox
2024-04-26 6:53 ` Christoph Hellwig
2024-04-26 8:50 ` Ritesh Harjani
2024-04-27 4:44 ` Christoph Hellwig
2024-04-25 13:28 ` [RFCv3 7/7] iomap: Optimize data access patterns for filesystems with indirect mappings Ritesh Harjani (IBM)
2024-04-26 16:24 ` Darrick J. Wong
2024-04-26 17:17 ` Ritesh Harjani
2024-04-26 17:25 ` Ritesh Harjani
2024-04-26 17:37 ` Matthew Wilcox
2024-04-26 17:55 ` Ritesh Harjani
2024-04-26 18:13 ` Matthew Wilcox
2024-04-26 18:57 ` Ritesh Harjani
2024-04-26 19:19 ` Matthew Wilcox
2024-04-27 4:54 ` Christoph Hellwig
2024-04-27 6:03 ` Ritesh Harjani
2024-04-27 4:47 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1714046808.git.ritesh.list@gmail.com \
--to=ritesh.list@gmail.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.