From: Oleksii Kurochko <oleksii.kurochko@gmail.com>
To: Stewart Hildebrand <stewart.hildebrand@amd.com>,
xen-devel@lists.xenproject.org
Cc: "Jan Beulich" <jbeulich@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH] xen/x86: fix build with CONFIG_HVM=n and -Og
Date: Thu, 13 Feb 2025 21:17:32 +0100 [thread overview]
Message-ID: <d75455fe-f588-4389-9ac2-a3004189adaf@gmail.com> (raw)
In-Reply-To: <20250213185055.711703-1-stewart.hildebrand@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]
On 2/13/25 7:50 PM, Stewart Hildebrand wrote:
> When building with CONFIG_HVM=n and -Og, we encounter:
>
> prelink.o: in function `pit_set_gate':
> xen/xen/arch/x86/emul-i8254.c:195: undefined reference to `destroy_periodic_time'
>
> Add an IS_ENABLED(CONFIG_HVM) check to assist with dead code
> elimination.
>
> Fixes: 14f42af3f52d ("x86/vPIT: account for "counter stopped" time")
> Signed-off-by: Stewart Hildebrand<stewart.hildebrand@amd.com>
With proper review:
Release-Acked-by: Oleksii Kurochko<oleksii.kurochko@gmail.com>
~ Oleksii
> ---
> xen/arch/x86/emul-i8254.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/emul-i8254.c b/xen/arch/x86/emul-i8254.c
> index 144aa168a3f0..7bc4b31b2894 100644
> --- a/xen/arch/x86/emul-i8254.c
> +++ b/xen/arch/x86/emul-i8254.c
> @@ -191,7 +191,7 @@ static void pit_set_gate(PITState *pit, int channel, int val)
> case 3:
> case 4:
> /* Disable counting. */
> - if ( !channel )
> + if ( IS_ENABLED(CONFIG_HVM) && !channel )
> destroy_periodic_time(&pit->pt0);
> pit->count_stop_time[channel] = get_guest_time(v);
> break;
>
> base-commit: b5b2f9877a8777af6b78944407527e0a450389a2
[-- Attachment #2: Type: text/html, Size: 1970 bytes --]
next prev parent reply other threads:[~2025-02-13 20:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 18:50 [PATCH] xen/x86: fix build with CONFIG_HVM=n and -Og Stewart Hildebrand
2025-02-13 20:17 ` Oleksii Kurochko [this message]
2025-02-14 1:05 ` Andrew Cooper
2025-02-14 8:25 ` Jan Beulich
2025-03-03 21:18 ` Stewart Hildebrand
2025-03-03 18:59 ` Stewart Hildebrand
2025-03-03 19:19 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d75455fe-f588-4389-9ac2-a3004189adaf@gmail.com \
--to=oleksii.kurochko@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=stewart.hildebrand@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.