From: Alex Elder <elder@ieee.org>
To: Jay Fang <f.fangjian@huawei.com>, elder@kernel.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: ipa: Remove useless error message
Date: Tue, 16 Mar 2021 05:22:54 -0500 [thread overview]
Message-ID: <d83c4f03-245f-8230-3f67-c1cb96c8bcd2@ieee.org> (raw)
In-Reply-To: <1615887666-15064-1-git-send-email-f.fangjian@huawei.com>
On 3/16/21 4:41 AM, Jay Fang wrote:
> From: Zihao Tang <tangzihao1@hisilicon.com>
>
> Fix the following coccicheck report:
>
> drivers/net/ipa/gsi.c:1341:2-9:
> line 1341 is redundant because platform_get_irq() already prints an error
>
> Remove dev_err() messages after platform_get_irq_byname() failures.
>
> Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>
> Signed-off-by: Jay Fang <f.fangjian@huawei.com>
The error message printed by platform_get_irq_byname()
does not indicate what the error (errno) is. But in
practice we essentially won't get these errors, and
if we do the message from platform_get_irq() is
enough to know there's a problem of some kind.
Thanks for the patch.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> drivers/net/ipa/gsi.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
> index 390d340..2119367 100644
> --- a/drivers/net/ipa/gsi.c
> +++ b/drivers/net/ipa/gsi.c
> @@ -1337,10 +1337,9 @@ static int gsi_irq_init(struct gsi *gsi, struct platform_device *pdev)
> int ret;
>
> ret = platform_get_irq_byname(pdev, "gsi");
> - if (ret <= 0) {
> - dev_err(dev, "DT error %d getting \"gsi\" IRQ property\n", ret);
> + if (ret <= 0)
> return ret ? : -EINVAL;
> - }
> +
> irq = ret;
>
> ret = request_irq(irq, gsi_isr, 0, "gsi", gsi);
>
next prev parent reply other threads:[~2021-03-16 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 9:41 [PATCH] net: ipa: Remove useless error message Jay Fang
2021-03-16 10:22 ` Alex Elder [this message]
2021-03-16 22:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d83c4f03-245f-8230-3f67-c1cb96c8bcd2@ieee.org \
--to=elder@ieee.org \
--cc=elder@kernel.org \
--cc=f.fangjian@huawei.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.