From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: Jarkko Sakkinen <jarkko@kernel.org>, linux-integrity@vger.kernel.org
Cc: Hans de Goede <hdegoede@redhat.com>,
stable@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
Jason Gunthorpe <jgg@ziepe.ca>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Stefan Berger <stefanb@linux.ibm.com>,
Jerry Snitselaar <jsnitsel@redhat.com>
Subject: Re: [PATCH 1/2] tpm, tpm_tis: Extend locality handling to TPM2 in tpm_tis_gen_interrupt()
Date: Tue, 11 May 2021 01:09:35 +0200 [thread overview]
Message-ID: <daf823b3-522c-6c9a-984b-0ca849512a54@gmx.de> (raw)
In-Reply-To: <20210510122831.409608-1-jarkko@kernel.org>
Hi,
On 10.05.21 at 14:28, Jarkko Sakkinen wrote:
> The earlier fix (linked) only partially fixed the locality handling bug
> in tpm_tis_gen_interrupt(), i.e. only for TPM 1.x.
>
> Extend the locality handling to cover TPM2.
>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/linux-integrity/20210220125534.20707-1-jarkko@kernel.org/
> Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()")
> Reported-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> ---
>
> v1:
> * Testing done with Intel NUC5i5MYHE with SLB9665 TPM2 chip.
>
> drivers/char/tpm/tpm_tis_core.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
> index a2e0395cbe61..6fa150a3b75e 100644
> --- a/drivers/char/tpm/tpm_tis_core.c
> +++ b/drivers/char/tpm/tpm_tis_core.c
> @@ -709,16 +709,14 @@ static int tpm_tis_gen_interrupt(struct tpm_chip *chip)
> cap_t cap;
> int ret;
>
> - /* TPM 2.0 */
> - if (chip->flags & TPM_CHIP_FLAG_TPM2)
> - return tpm2_get_tpm_pt(chip, 0x100, &cap2, desc);
> -
> - /* TPM 1.2 */
> ret = request_locality(chip, 0);
> if (ret < 0)
> return ret;
>
> - ret = tpm1_getcap(chip, TPM_CAP_PROP_TIS_TIMEOUT, &cap, desc, 0);
> + if (chip->flags & TPM_CHIP_FLAG_TPM2)
> + ret = tpm2_get_tpm_pt(chip, 0x100, &cap2, desc);
> + else
> + ret = tpm1_getcap(chip, TPM_CAP_PROP_TIS_TIMEOUT, &cap, desc, 0);
>
> release_locality(chip, 0);
>
>
This fix works for me. Tested on a SLB9670vq2.0 and the warning message is gone.
Tested-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Regards,
Lino
next prev parent reply other threads:[~2021-05-10 23:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 12:28 [PATCH 1/2] tpm, tpm_tis: Extend locality handling to TPM2 in tpm_tis_gen_interrupt() Jarkko Sakkinen
2021-05-10 12:28 ` [PATCH 2/2] tpm, tpm_tis: Reserve locality in tpm_tis_resume() Jarkko Sakkinen
2021-05-10 23:09 ` Lino Sanfilippo [this message]
2021-05-11 23:36 ` [PATCH 1/2] tpm, tpm_tis: Extend locality handling to TPM2 in tpm_tis_gen_interrupt() Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daf823b3-522c-6c9a-984b-0ca849512a54@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hdegoede@redhat.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.