From: Jan Kiszka <jan.kiszka@siemens.com>
To: Quirin Gylstorff <quirin.gylstorff@siemens.com>,
cip-dev@lists.cip-project.org, "Arjunan,
Srinu (FT FDS CES LX PBU 2)" <srinuvasan.a@siemens.com>,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Subject: Re: [cip-dev] [isar-cip-core][PATCH] update cip-kernel-defconfig to the latest version
Date: Tue, 18 Feb 2025 12:00:57 +0100 [thread overview]
Message-ID: <dc476b85-46c8-4a8d-8269-da7aa26ace35@siemens.com> (raw)
In-Reply-To: <fdfa34e7-6ccd-4374-9231-6c4d1b2d8e13@siemens.com>
On 18.02.25 10:33, Quirin Gylstorff wrote:
>
>
> On 2/17/25 10:26, Quirin Gylstorff via lists.cip-project.org wrote:
>>
>>
>> On 2/17/25 10:15, Jan Kiszka wrote:
>>> On 17.02.25 10:05, Quirin Gylstorff wrote:
>>>>
>>>>
>>>> On 2/17/25 06:37, Arjunan, Srinu (FT FDS CES LX PBU 2) wrote:
>>>>> Hi Jan,
>>>>>
>>>>> You meant this cip_merged_defconfig is generated one?,
>>>>> in that case, is this sufficient to enable the required configuration
>>>>> in siemens_ipc227e_defconfig to use the mokutil in IPC targets?,
>>>>> Please provide your thoughts.
>>>>>
>>>> Normally you would adapt siemens_ipc227e_defconfig and then regenerate
>>>> all cip_merged_configs.
>>>>
>>>> Also if you adapt 6.1.y-cip you should also adapt the version after
>>>> that
>>>> also(6.6 ... 6.13 at time of writing).
>>>>
>>>> Quirin
>>>>
>>>>
>>>>> Many thanks,
>>>>> Srinu
>>>>>
>>>>> -----Original Message-----
>>>>> From: Kiszka, Jan (FT RPD CED) <jan.kiszka@siemens.com>
>>>>> Sent: 14 February 2025 13:47
>>>>> To: Arjunan, Srinu (FT FDS CES LX PBU 2) <srinuvasan.a@siemens.com>;
>>>>> cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu
>>>>> <nobuhiro1.iwamatsu@toshiba.co.jp>; Gylstorff, Quirin (FT RPD CED OES-
>>>>> DE) <quirin.gylstorff@siemens.com>
>>>>> Subject: Re: [isar-cip-core][PATCH] update cip-kernel-defconfig to the
>>>>> latest version
>>>>>
>>>>> On 14.02.25 06:31, srinuvasan.a@siemens.com wrote:
>>>>>> From: srinuvasan <srinuvasan.a@siemens.com>
>>>>>>
>>>>>> This revision brings the CONFIG_EFIVAR_FS to read the EFI (Extensible
>>>>>> Firmware Interface) variable information via sysfs.
>>>>>>
>>>>>> Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
>>>>>> ---
>>>>>> recipes-kernel/linux/cip-kernel-config.inc | 4 ++--
>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/recipes-kernel/linux/cip-kernel-config.inc
>>>>>> b/recipes-kernel/linux/cip-kernel-config.inc
>>>>>> index 53bee8f..e761957 100644
>>>>>> --- a/recipes-kernel/linux/cip-kernel-config.inc
>>>>>> +++ b/recipes-kernel/linux/cip-kernel-config.inc
>>>>>> @@ -1,7 +1,7 @@
>>>>>> #
>>>>>> # CIP Core, generic profile
>>>>>> #
>>>>>> -# Copyright (c) Siemens AG, 2022-2024
>>>>>> +# Copyright (c) Siemens AG, 2022-2025
>>>>>> #
>>>>>> # Authors:
>>>>>> # Jan Kiszka <jan.kiszka@siemens.com> @@ -14,7 +14,7 @@
>>>>>> SRC_URI:append = " ${@ \
>>>>>> if d.getVar('USE_CIP_KERNEL_CONFIG') == '1' else '' \
>>>>>> }"
>>>>>> -SRCREV_cip-kernel-config ?=
>>>>>> "e486c93a916cb6f78b4917b7345e8818f96069f9"
>>>>>> +SRCREV_cip-kernel-config ?=
>>>>>> "6b5db480b7a43e0217b1fa58f487f0bb997743c7"
>>>>>> do_fetch[vardeps] += "SRCREV_cip-kernel-config"
>>>>>
>>>>> Argh, the commit to cip-kernel-config is broken: We must not patch the
>>>>> merged configs only anymore, they are generated.
>>>>>
>>>>> Quirin, I suspect that plathome_obsvx2_defconfig's disabling of that
>>>>> switch causes the merged config to turn it off again. I though that
>>>>> was fixed?
>>>>
>>>> There are two configs which disable in 6.1.y the EFI_VARS_FS:
>>>> - cip_container_defconfig and obsvx2_defconfig.
>>>>
>>>> As we take all config into account this will deactivate EFI_VARS_FS.
>>>>
>>>
>>> ...and that would be a bug in the generator script: default-y in one
>>> config must be handled like explicit-y. And explicit-y + explicit-n must
>>> be y in the merged config.
>>
>> I tested the script with the changes from srinu and the option is
>> correctly set EFI_VARS_FS to m. Save defconfig removes it again so
>> there is some dependency problem which needs to be look at.
>
> EFI_VARS_FS is set to m as a default, therefore `make savedefconfig`
> removes the entry from the defconfig.
>
Sure, and that needs to be taken into account somehow when generating
the merged config.
Jan
--
Siemens AG, Foundational Technologies
Linux Expert Center
prev parent reply other threads:[~2025-02-18 11:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 5:31 [isar-cip-core][PATCH] update cip-kernel-defconfig to the latest version srinuvasan.a
2025-02-14 8:17 ` Jan Kiszka
2025-02-17 5:37 ` Arjunan, Srinu
2025-02-17 9:05 ` Quirin Gylstorff
2025-02-17 9:15 ` Jan Kiszka
2025-02-17 9:26 ` Quirin Gylstorff
2025-02-18 9:33 ` [cip-dev] " Quirin Gylstorff
2025-02-18 11:00 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc476b85-46c8-4a8d-8269-da7aa26ace35@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=quirin.gylstorff@siemens.com \
--cc=srinuvasan.a@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.