* Re: [PATCH] firmware: xilinx: Remove zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE)
[not found] <20210131143033.7441-1-iwamatsu@nigauri.org>
@ 2021-02-01 10:08 ` Michal Simek
0 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2021-02-01 10:08 UTC (permalink / raw
To: Nobuhiro Iwamatsu, michal.simek; +Cc: linux-arm-kernel, linux-kernel
Hi,
On 1/31/21 3:30 PM, Nobuhiro Iwamatsu wrote:
> zynqmp_pm_get_eemi_ops() was removed in commit 4db8180ffe7c: "Firmware: xilinx:
> Remove eemi ops for fpga related APIs", but not in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE).
> This removed zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE), and also
> modify the documentation for this driver.
>
> Fixes: 4db8180ffe7c ("firmware: xilinx: Remove eemi ops for fpga related APIs")
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
> Documentation/driver-api/xilinx/eemi.rst | 27 +-----------------------
> include/linux/firmware/xlnx-zynqmp.h | 5 -----
> 2 files changed, 1 insertion(+), 31 deletions(-)
>
> diff --git a/Documentation/driver-api/xilinx/eemi.rst b/Documentation/driver-api/xilinx/eemi.rst
> index 9dcbc6f18d75df..53416d25d309a8 100644
> --- a/Documentation/driver-api/xilinx/eemi.rst
> +++ b/Documentation/driver-api/xilinx/eemi.rst
> @@ -19,32 +19,7 @@ device to issue or respond to power management requests.
> EEMI ops is a structure containing all eemi APIs supported by Zynq MPSoC.
> The zynqmp-firmware driver maintain all EEMI APIs in zynqmp_eemi_ops
> structure. Any driver who want to communicate with PMC using EEMI APIs
The whole paragraph should be tuned. I would leave here just
"Any driver who want to communicate with PMC using EEMI APIs
use the functions provided for each function."
Because there is no reference to any eemi ops structure.
The rest looks good to me.
Thanks,
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] firmware: xilinx: Remove zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE)
@ 2021-02-01 10:08 ` Michal Simek
0 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2021-02-01 10:08 UTC (permalink / raw
To: Nobuhiro Iwamatsu, michal.simek; +Cc: linux-kernel, linux-arm-kernel
Hi,
On 1/31/21 3:30 PM, Nobuhiro Iwamatsu wrote:
> zynqmp_pm_get_eemi_ops() was removed in commit 4db8180ffe7c: "Firmware: xilinx:
> Remove eemi ops for fpga related APIs", but not in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE).
> This removed zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE), and also
> modify the documentation for this driver.
>
> Fixes: 4db8180ffe7c ("firmware: xilinx: Remove eemi ops for fpga related APIs")
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
> Documentation/driver-api/xilinx/eemi.rst | 27 +-----------------------
> include/linux/firmware/xlnx-zynqmp.h | 5 -----
> 2 files changed, 1 insertion(+), 31 deletions(-)
>
> diff --git a/Documentation/driver-api/xilinx/eemi.rst b/Documentation/driver-api/xilinx/eemi.rst
> index 9dcbc6f18d75df..53416d25d309a8 100644
> --- a/Documentation/driver-api/xilinx/eemi.rst
> +++ b/Documentation/driver-api/xilinx/eemi.rst
> @@ -19,32 +19,7 @@ device to issue or respond to power management requests.
> EEMI ops is a structure containing all eemi APIs supported by Zynq MPSoC.
> The zynqmp-firmware driver maintain all EEMI APIs in zynqmp_eemi_ops
> structure. Any driver who want to communicate with PMC using EEMI APIs
The whole paragraph should be tuned. I would leave here just
"Any driver who want to communicate with PMC using EEMI APIs
use the functions provided for each function."
Because there is no reference to any eemi ops structure.
The rest looks good to me.
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] firmware: xilinx: Remove zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE)
2021-02-01 10:08 ` Michal Simek
@ 2021-02-11 23:18 ` Nobuhiro Iwamatsu
-1 siblings, 0 replies; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2021-02-11 23:18 UTC (permalink / raw
To: Michal Simek; +Cc: linux ARM, Linux Kernel Mailing List
Hi,
Thanks for your review.
2021年2月1日(月) 19:08 Michal Simek <michal.simek@xilinx.com>:
>
> Hi,
>
> On 1/31/21 3:30 PM, Nobuhiro Iwamatsu wrote:
> > zynqmp_pm_get_eemi_ops() was removed in commit 4db8180ffe7c: "Firmware: xilinx:
> > Remove eemi ops for fpga related APIs", but not in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE).
> > This removed zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE), and also
> > modify the documentation for this driver.
> >
> > Fixes: 4db8180ffe7c ("firmware: xilinx: Remove eemi ops for fpga related APIs")
> > Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> > ---
> > Documentation/driver-api/xilinx/eemi.rst | 27 +-----------------------
> > include/linux/firmware/xlnx-zynqmp.h | 5 -----
> > 2 files changed, 1 insertion(+), 31 deletions(-)
> >
> > diff --git a/Documentation/driver-api/xilinx/eemi.rst b/Documentation/driver-api/xilinx/eemi.rst
> > index 9dcbc6f18d75df..53416d25d309a8 100644
> > --- a/Documentation/driver-api/xilinx/eemi.rst
> > +++ b/Documentation/driver-api/xilinx/eemi.rst
> > @@ -19,32 +19,7 @@ device to issue or respond to power management requests.
> > EEMI ops is a structure containing all eemi APIs supported by Zynq MPSoC.
> > The zynqmp-firmware driver maintain all EEMI APIs in zynqmp_eemi_ops
> > structure. Any driver who want to communicate with PMC using EEMI APIs
>
> The whole paragraph should be tuned. I would leave here just
>
> "Any driver who want to communicate with PMC using EEMI APIs
> use the functions provided for each function."
>
> Because there is no reference to any eemi ops structure.
>
> The rest looks good to me.
Thank you. I will add your point to the commit log and resend.
Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] firmware: xilinx: Remove zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE)
@ 2021-02-11 23:18 ` Nobuhiro Iwamatsu
0 siblings, 0 replies; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2021-02-11 23:18 UTC (permalink / raw
To: Michal Simek; +Cc: Linux Kernel Mailing List, linux ARM
Hi,
Thanks for your review.
2021年2月1日(月) 19:08 Michal Simek <michal.simek@xilinx.com>:
>
> Hi,
>
> On 1/31/21 3:30 PM, Nobuhiro Iwamatsu wrote:
> > zynqmp_pm_get_eemi_ops() was removed in commit 4db8180ffe7c: "Firmware: xilinx:
> > Remove eemi ops for fpga related APIs", but not in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE).
> > This removed zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE), and also
> > modify the documentation for this driver.
> >
> > Fixes: 4db8180ffe7c ("firmware: xilinx: Remove eemi ops for fpga related APIs")
> > Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> > ---
> > Documentation/driver-api/xilinx/eemi.rst | 27 +-----------------------
> > include/linux/firmware/xlnx-zynqmp.h | 5 -----
> > 2 files changed, 1 insertion(+), 31 deletions(-)
> >
> > diff --git a/Documentation/driver-api/xilinx/eemi.rst b/Documentation/driver-api/xilinx/eemi.rst
> > index 9dcbc6f18d75df..53416d25d309a8 100644
> > --- a/Documentation/driver-api/xilinx/eemi.rst
> > +++ b/Documentation/driver-api/xilinx/eemi.rst
> > @@ -19,32 +19,7 @@ device to issue or respond to power management requests.
> > EEMI ops is a structure containing all eemi APIs supported by Zynq MPSoC.
> > The zynqmp-firmware driver maintain all EEMI APIs in zynqmp_eemi_ops
> > structure. Any driver who want to communicate with PMC using EEMI APIs
>
> The whole paragraph should be tuned. I would leave here just
>
> "Any driver who want to communicate with PMC using EEMI APIs
> use the functions provided for each function."
>
> Because there is no reference to any eemi ops structure.
>
> The rest looks good to me.
Thank you. I will add your point to the commit log and resend.
Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-11 23:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210131143033.7441-1-iwamatsu@nigauri.org>
2021-02-01 10:08 ` [PATCH] firmware: xilinx: Remove zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE) Michal Simek
2021-02-01 10:08 ` Michal Simek
2021-02-11 23:18 ` Nobuhiro Iwamatsu
2021-02-11 23:18 ` Nobuhiro Iwamatsu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.