From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWPEa-0004MK-H7 for qemu-devel@nongnu.org; Tue, 02 Jan 2018 11:16:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWPEZ-0006rw-OD for qemu-devel@nongnu.org; Tue, 02 Jan 2018 11:16:12 -0500 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:46234) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWPEZ-0006rE-IP for qemu-devel@nongnu.org; Tue, 02 Jan 2018 11:16:11 -0500 Received: by mail-pf0-x242.google.com with SMTP id c204so25810691pfc.13 for ; Tue, 02 Jan 2018 08:16:11 -0800 (PST) References: <20180102011032.30056-1-laurent@vivier.eu> <20180102011032.30056-7-laurent@vivier.eu> From: Richard Henderson Message-ID: Date: Tue, 2 Jan 2018 08:16:07 -0800 MIME-Version: 1.0 In-Reply-To: <20180102011032.30056-7-laurent@vivier.eu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 06/17] target/m68k: manage 680x0 stack frames List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org Cc: Thomas Huth On 01/01/2018 05:10 PM, Laurent Vivier wrote: > 680x0 manages several stack frame formats: > - format 0: four-word stack frame > - format 1: four-word throwaway stack frame > - format 2: six-word stack frame > - format 3: Floating-Point post-instruction stack frame > - format 4: eight-word stack frame > - format 7: access-error stack frame > > Signed-off-by: Laurent Vivier > --- > target/m68k/op_helper.c | 158 +++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 155 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~