From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWMFP-00029M-Ck for qemu-devel@nongnu.org; Fri, 22 Jun 2018 09:37:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWMFO-0001Nf-DT for qemu-devel@nongnu.org; Fri, 22 Jun 2018 09:37:07 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:46894 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fWMFO-0001NY-7k for qemu-devel@nongnu.org; Fri, 22 Jun 2018 09:37:06 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w5MDYENM080556 for ; Fri, 22 Jun 2018 09:37:05 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2jrx6mtrnm-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 22 Jun 2018 09:37:05 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 22 Jun 2018 14:36:55 +0100 References: <20180615142108.27814-1-kwolf@redhat.com> <20180615142108.27814-26-kwolf@redhat.com> <7a310b92-f8cb-b68b-d882-9b2959794347@de.ibm.com> <20180622125502.GF4366@localhost.localdomain> From: Christian Borntraeger Date: Fri, 22 Jun 2018 15:36:50 +0200 MIME-Version: 1.0 In-Reply-To: <20180622125502.GF4366@localhost.localdomain> Content-Language: en-US Message-Id: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Boris Fiuczynski , libvir-list@redhat.com, eblake@redhat.com, pkrempa@redhat.com, Markus Armbruster , Jeff Cody , Peter Maydell On 06/22/2018 02:55 PM, Kevin Wolf wrote: > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: >> >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: >>> The -drive option serial was deprecated in QEMU 2.10. It's time to >>> remove it. >>> >>> Tests need to be updated to set the serial number with -global instead >>> of using the -drive option. >> >> libvirt 4.5 still creates those (at least on s390x) >> >> >> >> >> >> skel >> >>
>> >> >> >> -> >> [...] >> -drive file=/var/lib/libvirt/qemu/image.zhyp137,format=qcow2,if=none,id=drive-virtio-disk0,serial=skel,cache=none,aio=native -device virtio-blk-ccw,iothread=iothread1,scsi=off,devno=fe.0.0000,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1,write-cache=on >> [...] >> >> 2018-06-22T11:25:20.946024Z qemu-system-s390x: -drive file=/var/lib/libvirt/qemu/image.zhyp137,format=qcow2,if=none,id=drive-virtio-disk0,serial=skel,cache=none,aio=native: Block format 'qcow2' does not support the option 'serial' >> 2018-06-22 11:25:21.098+0000: shutting down, reason=failed >> >> So it seems that this breaks s390x. To me it seems that this is also broken on x86. > > Thanks for bringing this up. libvirt should fix this before QEMU 3.0 is > released. I think this is definitely too short notice. We should not break existing setups just by insisting that users have to update libvirt when they update QEMU. Yes, this might be our policy, but doing so "just because we can" is certainly a very bad attitude. I see no fundamental technical reason why we should not revert this change. > > Sadly, it also shows that deprecation warnings in log files go > unnoticed. In fact whoever added the deprication notice should have followed up with the libvirt team to implement that change. no?