From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA07BC2B9F4 for ; Mon, 28 Jun 2021 10:38:05 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00ED561C6C for ; Mon, 28 Jun 2021 10:38:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00ED561C6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 74AC480C72; Mon, 28 Jun 2021 12:38:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="V1u/ZdXm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9F8AC82DAD; Mon, 28 Jun 2021 12:37:59 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D8FFE82DA6 for ; Mon, 28 Jun 2021 12:37:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1624876670; bh=0012b8nIDlwm/3YmUMDAk+lQ2/w5jNtaEQvLCkbGoOM=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=V1u/ZdXmpLotwGCi6uMCVXalrW15DabGthvcb0zLHiwZULgbvQXmqjPQ1sh6qfFfG 28lYULLfFk4Vwha/Jklt9wGXQkqYjryoecvQ1Y9ed0uS396z2V37J9so4wnCWB1tD6 E9LiotbYxdglAFePm8RH/u3SAehZO9b01PvxzJA4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([88.152.144.157]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MVN6t-1lqQ6D2czP-00SRlW; Mon, 28 Jun 2021 12:37:50 +0200 Subject: Re: [PATCH 6/7] lib: Create a new Kconfig option for charset conversion To: Simon Glass Cc: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Ilias Apalodimas , Tom Rini , U-Boot Mailing List , Faiz Abbas References: <20210628014841.501036-1-sjg@chromium.org> <20210627194836.6.I70d4b350a1d009c7cd793ac207b9dc934e53c135@changeid> From: Heinrich Schuchardt Message-ID: Date: Mon, 28 Jun 2021 12:37:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210627194836.6.I70d4b350a1d009c7cd793ac207b9dc934e53c135@changeid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:WlY9+m1B0tNcFCCSrqmm7NH9O82X2K9PFLt2IsaMY00lAiNuZYb htWY/ucBLhgowY39QR2r8WgV+9Fc33UMN8pnxjssUMtQskBhYsuXzpGrqgJi6E8NskgFhkj czjEMICrFglrf/yyNqP3eGfWUiiWF+gGZAmqYnDoeVVvlEVDp0DL8uFSrZ26fQKxn4lPcxQ iIuE2UVR4mUeDeFB5BshQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:Jx3o2LYV92s=:RPTgll6W9YCkn6TNkf0Eh7 h+cfeiyqfEzxTOO4Ak/tSQUt9RlxguLKQPEU8bOkw+Jv9cIFD7o/DfnKcNFo1/0MkJS8vRTbq sW1IH0rLAEG573nTdYM2nMMdLv5apQESj8jvOrp37Dum0ITBBYPs5ybKptXgHvDjBH4lFJ6Aj dF2MdMpGxGOhBFwla1Ty+wIsV+Rg4p0VAvBSktdb5K70BwaACZ8BiJ3wwVN36QfZVDMHZ66qp gX7icBuIXYuPpT8N23Hctb+fKOmUlwv4hUhCiqzMkEDSVYROCJ6o/QODmvoSGop7WmGak8HiQ Dq1ab/EemDdQsYVA9xz4MK7s1xy0PkRdOaTk/ToW4HiYZUb7zr9bXbRUOe1W9Fo+ihstFpRkR TnnMZ+btDaDLKIoS1p4EbL6JvTNWMVhppEZ7S1gx8a7uhsGGEEPfmUgaBCjsaEOq5IZDs4F5H 3/hk8+VoF5sgj69UgMUKBWbXdsdY9Vs7CubK0koY8GNX4vkBrLIW4DCgXZBlLORwSrcZP1InW qZpwxYjUWqiCBydgKPCLxfX3nj3lcOBReq2Z6f/H2PZzxL4iH01uXHiDxhuI60bBgDS0Ixwsw RiYHBT16fGjh90kD6HhkI5xNvPBEFISlD/yjppClxfVXATG+TVRNscuGFDgWVTiKWEDZ/BqG1 7T0t7oVWFHlugLnDMHMkOqe2iTQgQN13t73H9mJTdbZ7Bjyw/CLE6qoZg18uElyB8+CnFRqDD jxX6mqleBan2m4QXLf3csq5W/WsMD/b94Ug1YsEXoPYN9LSBfw8BdLyBf5V2Dtda7VRphWdYY R7wv1zbldeX+4OgAz1hvkHxWO3YeAE4qD98y6YzXXsJb6wTnrv6G6T9lRaKRRA4gsCLHZG7cW La5v/m/5YnQ9TLBdj6b0dEaHOda5rTckct1JDWApMWH2IC6BbOGmjh8MSbB0p0pZVm7vWESae XVd/IvqRpiliR7Cc9E2ZbHWY3GCKRXIks4RbkX+3QyQlW+lNJVu08B0Kqe3u7NljkY9UTfarY HdWmJiEQHi0BsAxqRBAEVNeYYtLXP9kHFQUraVxK18GwMP6NKYfw+OjdyhXaY/qvDb1zizK9K JHqDf4lBz19zg5Z0GmmHDLImqT62ZEX7gK9 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 6/28/21 3:48 AM, Simon Glass wrote: > Rather than looking at two KConfig options in the Makefile, create a new > Kconfig option for compiling lib/charset.c > > Enable it for UFS also, which needs this support. +CC Faiz, maintainer UFS Function utf16_to_utf8() is used in ufshcd_read_string_desc(). It assumes that UTF-16 is using CPU endianness. What does UFS require on big-endian systems? > > Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt > --- > > lib/Kconfig | 8 ++++++++ > lib/Makefile | 2 +- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/lib/Kconfig b/lib/Kconfig > index ad0cd52edd8..e1415799965 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -40,6 +40,14 @@ config CC_OPTIMIZE_LIBS_FOR_SPEED > > If unsure, say N. > > +config CHARSET > + bool > + default y if UT_UNICODE || EFI_LOADER || UFS > + help > + Enables support for various conversions between different > + character sets, such as between unicode representations and > + different 'code pages'. > + > config DYNAMIC_CRC_TABLE > bool "Enable Dynamic tables for CRC" > help > diff --git a/lib/Makefile b/lib/Makefile > index 881034f4ae3..2d2b273ccef 100644 > --- a/lib/Makefile > +++ b/lib/Makefile > @@ -25,7 +25,7 @@ obj-$(CONFIG_AES) +=3D aes/ > obj-$(CONFIG_$(SPL_TPL_)BINMAN_FDT) +=3D binman.o > > ifndef API_BUILD > -ifneq ($(CONFIG_UT_UNICODE)$(CONFIG_EFI_LOADER),) > +ifneq ($(CONFIG_CHARSET),) > obj-y +=3D charset.o > endif > endif >