From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24C76C48BDF for ; Thu, 24 Jun 2021 08:05:38 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6E52613C1 for ; Thu, 24 Jun 2021 08:05:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6E52613C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.146460.269485 (Exim 4.92) (envelope-from ) id 1lwKMY-0006os-Th; Thu, 24 Jun 2021 08:05:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 146460.269485; Thu, 24 Jun 2021 08:05:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lwKMY-0006ol-Qa; Thu, 24 Jun 2021 08:05:26 +0000 Received: by outflank-mailman (input) for mailman id 146460; Thu, 24 Jun 2021 08:05:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lwKMX-0006of-DZ for xen-devel@lists.xenproject.org; Thu, 24 Jun 2021 08:05:25 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 419c2cfc-3b48-436f-bd96-54ba96aeb526; Thu, 24 Jun 2021 08:05:24 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 86BBF1FD66; Thu, 24 Jun 2021 08:05:23 +0000 (UTC) Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 5001911A97; Thu, 24 Jun 2021 08:05:23 +0000 (UTC) Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id vC9REsM81GCAFAAALh3uQQ (envelope-from ); Thu, 24 Jun 2021 08:05:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 419c2cfc-3b48-436f-bd96-54ba96aeb526 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1624521923; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L2Mvnt3OVKuGRhEfNiy42x9mGDm7XA/mK3M3R5sZitk=; b=KDWJunp+JRoEHqCVJySF+eMYhlijQDXliN40BGxTDyp0YKviZ1u7A0EqL0d5t7QIWlHg4I /wSysQcPlh/sCfIv48bAzuUbwvjMLke2pJTA1yJVLGFxhy7QUl8TlzEqylisANd6IHCcIC RZ9KDtPL0neIsgyZULAtZM4sb34ypIo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1624521923; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L2Mvnt3OVKuGRhEfNiy42x9mGDm7XA/mK3M3R5sZitk=; b=KDWJunp+JRoEHqCVJySF+eMYhlijQDXliN40BGxTDyp0YKviZ1u7A0EqL0d5t7QIWlHg4I /wSysQcPlh/sCfIv48bAzuUbwvjMLke2pJTA1yJVLGFxhy7QUl8TlzEqylisANd6IHCcIC RZ9KDtPL0neIsgyZULAtZM4sb34ypIo= Subject: Re: [PATCH 03/10] tools/xenstore: Don't assume conn->in points to the LU request To: Luca Fancellu Cc: Julien Grall , xen-devel@lists.xenproject.org, raphning@amazon.co.uk, doebel@amazon.de, Julien Grall , Ian Jackson , Wei Liu References: <20210616144324.31652-1-julien@xen.org> <20210616144324.31652-4-julien@xen.org> <2e28c385-a8ba-1dc3-c41e-8b39f624947c@suse.com> <10F0635C-2AA7-42A4-B4BB-A9DD869113C9@arm.com> From: Juergen Gross Message-ID: Date: Thu, 24 Jun 2021 10:05:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <10F0635C-2AA7-42A4-B4BB-A9DD869113C9@arm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qNnvDoqTkBB56ArsYnmgqb9IivUokgeyD" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qNnvDoqTkBB56ArsYnmgqb9IivUokgeyD Content-Type: multipart/mixed; boundary="OG8QeX7nsdG80gj0F4Hlx4DRcpZq86bIF"; protected-headers="v1" From: Juergen Gross To: Luca Fancellu Cc: Julien Grall , xen-devel@lists.xenproject.org, raphning@amazon.co.uk, doebel@amazon.de, Julien Grall , Ian Jackson , Wei Liu Message-ID: Subject: Re: [PATCH 03/10] tools/xenstore: Don't assume conn->in points to the LU request References: <20210616144324.31652-1-julien@xen.org> <20210616144324.31652-4-julien@xen.org> <2e28c385-a8ba-1dc3-c41e-8b39f624947c@suse.com> <10F0635C-2AA7-42A4-B4BB-A9DD869113C9@arm.com> In-Reply-To: <10F0635C-2AA7-42A4-B4BB-A9DD869113C9@arm.com> --OG8QeX7nsdG80gj0F4Hlx4DRcpZq86bIF Content-Type: multipart/mixed; boundary="------------20E813A14FB26FBE5936C8FE" Content-Language: en-US This is a multi-part message in MIME format. --------------20E813A14FB26FBE5936C8FE Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 24.06.21 09:56, Luca Fancellu wrote: >=20 >=20 >> On 24 Jun 2021, at 08:34, Juergen Gross wrote: >> >> On 24.06.21 09:32, Juergen Gross wrote: >>> On 16.06.21 16:43, Julien Grall wrote: >>>> From: Julien Grall >>>> >>>> call_delayed() is currently assuming that conn->in is NULL when >>>> handling delayed request. However, the connection is not paused. >>>> Therefore new request can be processed and conn->in may be non-NULL >>>> if we have only received a partial request. >>>> >>>> Furthermore, as we overwrite conn->in, the current partial request >>>> will not be transferred. This will result to corrupt the connection.= >>>> >>>> Rather than updating conn->in, stash the LU request in lu_status and= >>>> let each callback for delayed request to update conn->in when >>>> necessary. >>>> >>>> To keep a sane interface, the code to write the "OK" response the >>>> LU request is moved in xenstored_core.c. >>>> >>>> Fixes: c5ca1404b4 ("tools/xenstore: add support for delaying executi= on >> >>>> of a xenstore request") >>>> Fixes: ed6eebf17d ("tools/xenstore: dump the xenstore state for live=20 update") >>>> Signed-off-by: Julien Grall >>> With dropping the conn parameter from call_delayed as already >>> mentioned by Luca you can add my: >> >> Oh, please drop my request to delete the conn parameter, as it is bein= g >> used in patch 4 again. >> >>> Reviewed-by: Juergen Gross >> >> This stands, of course. >=20 > Hi Juergen, >=20 > I=E2=80=99m sorry but I don=E2=80=99t see when the parameter is used, i= n patch 4 we have this call: >=20 > line 2344: > if (delayed_requests) { > list_for_each_entry(conn, &connections, list) { > struct delayed_request *req, *tmp; >=20 > list_for_each_entry_safe(req, tmp, > &conn->delayed, list) > call_delayed(conn, req); > } > } >=20 > But call_delayed is still this one: >=20 > Line 273: > static void call_delayed(struct connection *conn, struct delayed_reques= t *req) > { > if (req->func(req)) { > undelay_request(req); > talloc_set_destructor(req, NULL); > } > } >=20 > Am I missing something? Hmm, I seem to have mixed up something. Yes, you are right. So off with the conn parameter (again). Juergen --------------20E813A14FB26FBE5936C8FE Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------20E813A14FB26FBE5936C8FE-- --OG8QeX7nsdG80gj0F4Hlx4DRcpZq86bIF-- --qNnvDoqTkBB56ArsYnmgqb9IivUokgeyD Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmDUPMIFAwAAAAAACgkQsN6d1ii/Ey+6 /Af/Ys39lhMGEZuybikffryZM+RZru7f+Lbm96tkcVdAUApgSEMrRtPoPsg9AkHF0ylqpWqpBKby E9GBQBvgW6UTjClwdziLDjUPMt9Sg/l4ZXGhSwflapQ8jSAImFiceOlNeC+rPnx5EQz2+/mjehp3 eneGgDvYavUbBhWDbzn3c8TfXMVscJGs7m9QqQhl4dgvKLlBiHwEfstdu8BIZ0k8feATZVC63+vb 6qlli9nlE7/yQp5/AfFu0/idiBtnuwvexx/VPQyfwChvOiOtE2XkAF2/Zqcrms10wAbUOL2q6yB+ KOABNPqTdp4OJjt6dJ7N0g3/9Sregc26fpVvOX5Edw== =ZH21 -----END PGP SIGNATURE----- --qNnvDoqTkBB56ArsYnmgqb9IivUokgeyD--