From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v4] drm/i915/execlists: Pull CSB reset under the timeline.lock Date: Wed, 27 Jun 2018 10:33:01 +0100 Message-ID: References: <20180625094842.8499-4-chris@chris-wilson.co.uk> <20180626115015.8521-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3087B6E794 for ; Wed, 27 Jun 2018 09:33:05 +0000 (UTC) In-Reply-To: <20180626115015.8521-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI2LzA2LzIwMTggMTI6NTAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJbiB0aGUgZm9sbG93 aW5nIHBhdGNoLCB3ZSB3aWxsIHByb2Nlc3MgdGhlIENTQiBldmVudHMgdW5kZXIgdGhlCj4gdGlt ZWxpbmUubG9jayBhbmQgbm90IHNlcmlhbGlzZWQgYnkgdGhlIHRhc2tsZXQuIFRoaXMgYWxzbyBt ZWFucyB0aGF0IHdlCj4gd2lsbCBuZWVkIHRvIHByb3RlY3QgYWNjZXNzIHRvIGNvbW1vbiB2YXJp YWJsZXMgc3VjaCBhcwo+IGV4ZWNsaXN0cy0+Y3NiX2hlYWQgd2l0aCB0aGUgdGltZWxpbmUubG9j ayBkdXJpbmcgcmVzZXQuCj4gCj4gdjI6IE1vdmUgc3luY19pcnEgdG8gYXZvaWQgZGVhZGxvY2tz IGJldHdlZW4gdGFraW5nIHRpbWVsaW5lLmxvY2sgZnJvbQo+IG91ciBpbnRlcnJ1cHQgaGFuZGxl ci4KPiB2MzogS2lsbCBvZmYgdGhlIHN5bmNocm9uaXplX2hhcmRpcnEgYXMgaXQgcmFpc2VzIG1v cmUgcXVlc3Rpb25zIHRoYW4KPiBhbnN3ZXJlZDsgbm93IHdlIHVzZSB0aGUgdGltZWxpbmUubG9j ayBlbnRpcmVseSBmb3IgQ1NCIHNlcmlhbGlzYXRpb24KPiBiZXR3ZWVuIHRoZSBpcnEgYW5kIGVs c2V3aGVyZSwgd2UgZG9uJ3QgbmVlZCB0byBiZSBzbyBoZWF2eSBoYW5kZWQgd2l0aAo+IGZsdXNo aW5nCj4gdjQ6IFRyZWF0IHJlcXVlc3QgY2FuY2VsbGF0aW9uICh3ZWRnaW5nIGFmdGVyIGZhaWxl ZCByZXNldCkgc2ltaWxhcmx5Cj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJp c0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxp bkBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyB8 IDE2ICsrKystLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyks IDEyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggMDA5 ZGI5MmI2N2Q3Li40YjMxZThmNDJhZWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfbHJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ IEBAIC04NzEsNyArODcxLDYgQEAgc3RhdGljIHZvaWQgcmVzZXRfaXJxKHN0cnVjdCBpbnRlbF9l bmdpbmVfY3MgKmVuZ2luZSkKPiAgIHsKPiAgIAkvKiBNYXJrIGFsbCBDUyBpbnRlcnJ1cHRzIGFz IGNvbXBsZXRlICovCj4gICAJc21wX3N0b3JlX21iKGVuZ2luZS0+ZXhlY2xpc3RzLmFjdGl2ZSwg MCk7Cj4gLQlzeW5jaHJvbml6ZV9oYXJkaXJxKGVuZ2luZS0+aTkxNS0+ZHJtLmlycSk7Cj4gICAK PiAgIAljbGVhcl9ndGlpcihlbmdpbmUpOwo+ICAgCj4gQEAgLTkwOCwxNCArOTA3LDEyIEBAIHN0 YXRpYyB2b2lkIGV4ZWNsaXN0c19jYW5jZWxfcmVxdWVzdHMoc3RydWN0IGludGVsX2VuZ2luZV9j cyAqZW5naW5lKQo+ICAgCSAqIHN1Ym1pc3Npb24ncyBpcnEgc3RhdGUsIHdlIGFsc28gd2lzaCB0 byByZW1pbmQgb3Vyc2VsdmVzIHRoYXQKPiAgIAkgKiBpdCBpcyBpcnEgc3RhdGUuKQo+ICAgCSAq Lwo+IC0JbG9jYWxfaXJxX3NhdmUoZmxhZ3MpOwo+ICsJc3Bpbl9sb2NrX2lycXNhdmUoJmVuZ2lu ZS0+dGltZWxpbmUubG9jaywgZmxhZ3MpOwo+ICAgCj4gICAJLyogQ2FuY2VsIHRoZSByZXF1ZXN0 cyBvbiB0aGUgSFcgYW5kIGNsZWFyIHRoZSBFTFNQIHRyYWNrZXIuICovCj4gICAJZXhlY2xpc3Rz X2NhbmNlbF9wb3J0X3JlcXVlc3RzKGV4ZWNsaXN0cyk7Cj4gICAJcmVzZXRfaXJxKGVuZ2luZSk7 Cj4gICAKPiAtCXNwaW5fbG9jaygmZW5naW5lLT50aW1lbGluZS5sb2NrKTsKPiAtCj4gICAJLyog TWFyayBhbGwgZXhlY3V0aW5nIHJlcXVlc3RzIGFzIHNraXBwZWQuICovCj4gICAJbGlzdF9mb3Jf ZWFjaF9lbnRyeShycSwgJmVuZ2luZS0+dGltZWxpbmUucmVxdWVzdHMsIGxpbmspIHsKPiAgIAkJ R0VNX0JVR19PTighcnEtPmdsb2JhbF9zZXFubyk7Cj4gQEAgLTk0OSw5ICs5NDYsNyBAQCBzdGF0 aWMgdm9pZCBleGVjbGlzdHNfY2FuY2VsX3JlcXVlc3RzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZSkKPiAgIAlleGVjbGlzdHMtPmZpcnN0ID0gTlVMTDsKPiAgIAlHRU1fQlVHX09OKHBv cnRfaXNzZXQoZXhlY2xpc3RzLT5wb3J0KSk7Cj4gICAKPiAtCXNwaW5fdW5sb2NrKCZlbmdpbmUt PnRpbWVsaW5lLmxvY2spOwo+IC0KPiAtCWxvY2FsX2lycV9yZXN0b3JlKGZsYWdzKTsKPiArCXNw aW5fdW5sb2NrX2lycXJlc3RvcmUoJmVuZ2luZS0+dGltZWxpbmUubG9jaywgZmxhZ3MpOwo+ICAg fQo+ICAgCj4gICBzdGF0aWMgdm9pZCBwcm9jZXNzX2NzYihzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICplbmdpbmUpCj4gQEAgLTE5NjksOCArMTk2NCw3IEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19y ZXNldChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gICAJCSAgZW5naW5lLT5uYW1l LCByZXF1ZXN0ID8gcmVxdWVzdC0+Z2xvYmFsX3NlcW5vIDogMCwKPiAgIAkJICBpbnRlbF9lbmdp bmVfZ2V0X3NlcW5vKGVuZ2luZSkpOwo+ICAgCj4gLQkvKiBTZWUgZXhlY2xpc3RzX2NhbmNlbF9y ZXF1ZXN0cygpIGZvciB0aGUgaXJxL3NwaW5sb2NrIHNwbGl0LiAqLwo+IC0JbG9jYWxfaXJxX3Nh dmUoZmxhZ3MpOwo+ICsJc3Bpbl9sb2NrX2lycXNhdmUoJmVuZ2luZS0+dGltZWxpbmUubG9jaywg ZmxhZ3MpOwo+ICAgCj4gICAJLyoKPiAgIAkgKiBDYXRjaCB1cCB3aXRoIGFueSBtaXNzZWQgY29u dGV4dC1zd2l0Y2ggaW50ZXJydXB0cy4KPiBAQCAtMTk4NSwxNCArMTk3OSwxMiBAQCBzdGF0aWMg dm9pZCBleGVjbGlzdHNfcmVzZXQoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+ICAg CXJlc2V0X2lycShlbmdpbmUpOwo+ICAgCj4gICAJLyogUHVzaCBiYWNrIGFueSBpbmNvbXBsZXRl IHJlcXVlc3RzIGZvciByZXBsYXkgYWZ0ZXIgdGhlIHJlc2V0LiAqLwo+IC0Jc3Bpbl9sb2NrKCZl bmdpbmUtPnRpbWVsaW5lLmxvY2spOwo+ICAgCV9fdW53aW5kX2luY29tcGxldGVfcmVxdWVzdHMo ZW5naW5lKTsKPiAtCXNwaW5fdW5sb2NrKCZlbmdpbmUtPnRpbWVsaW5lLmxvY2spOwo+ICAgCj4g ICAJLyogRm9sbG93aW5nIHRoZSByZXNldCwgd2UgbmVlZCB0byByZWxvYWQgdGhlIENTQiByZWFk L3dyaXRlIHBvaW50ZXJzICovCj4gICAJZW5naW5lLT5leGVjbGlzdHMuY3NiX2hlYWQgPSBHRU44 X0NTQl9FTlRSSUVTIC0gMTsKPiAgIAo+IC0JbG9jYWxfaXJxX3Jlc3RvcmUoZmxhZ3MpOwo+ICsJ c3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZW5naW5lLT50aW1lbGluZS5sb2NrLCBmbGFncyk7Cj4g ICAKPiAgIAkvKgo+ICAgCSAqIElmIHRoZSByZXF1ZXN0IHdhcyBpbm5vY2VudCwgd2UgbGVhdmUg dGhlIHJlcXVlc3QgaW4gdGhlIEVMU1AKPiAKClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK