From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B51DDC19F2D for ; Thu, 11 Aug 2022 11:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234414AbiHKLxi (ORCPT ); Thu, 11 Aug 2022 07:53:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235078AbiHKLxQ (ORCPT ); Thu, 11 Aug 2022 07:53:16 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF6D978BD9 for ; Thu, 11 Aug 2022 04:53:14 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id bq11so25243399lfb.5 for ; Thu, 11 Aug 2022 04:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=5HiYzFHc/9Xp6EzsvXqUwFD4ssSumNPG0+vT3T1mUK0=; b=eDCPKHKlMIy/f4StHh/b1bfEoZExC+kNQgf1fkCBF1qyOR9H1Ay5YCMC+cVsuh3Ght 7DwYOLrllPXCy0IOKoA0Hx2PkH60cTX4/lZhWvGtdYpKDiKUtj7iH6fTITy0GpOfXkRt 6gH0sIXYVXySMUtSPGLVP8OEiu7T/lIj8aNVDWyZsw+ofnklpDrmfg91S70EM4aQt3W1 ZJY6c8wC+QbVt4Wv/iWIDZyxEw5Bz9wmaM64t0vzSpKgxyCuzCG5G38uMrLwLguv8yap es/32BddycSQ26VJhiRINI8pyT2lJrA+VZpENMgnS27aa/fMesWvf3NAz3h7GAcHsFdx zRYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=5HiYzFHc/9Xp6EzsvXqUwFD4ssSumNPG0+vT3T1mUK0=; b=qR8E0yrPbpMn8dsNMRgpN+OLegmvI7vzzjMF6VmR6G3OFNLtDtz24WzzLHxBz58lBO bvEJxwb6P1eX6B4ap+Aqw+VPMpESmPVzXffpEIYpUPCC0HcIQCY+XIalSDwHtasxTrA1 dOk3J0fPjUi2f4Pu/MVdUoOyGJ88lPr6BEHkF8g7RW3l9AMUrffZbtmX/xW32xZjWSRQ +PLDGnDK4woQ022YRRcR9oZFlG7+MZL5WK0dPzRSm8azfUqmZlUnsOJCpmzFmN+qKyXD VEHUUvjx5jzMp+Qrj+ZW0C/9kNHc/MzbGVLSGV08fU2lJSaUt5NhH8RRue/tB/AJbgwr plGw== X-Gm-Message-State: ACgBeo1Dj4WMVnxli3lhEKjmJ8c+Bpi1b+NbLaMhwzFASsyDBJ26xtPe cKxH/tDVuN55/NrlHxRm0WP4hw== X-Google-Smtp-Source: AA6agR4xWcrV3sC9joYRds2dRPdF5QYf+E49P5o/1hiFlngFTfZ6XBB3+3ZXhz0ewEzcMt8g6j4ThQ== X-Received: by 2002:ac2:418a:0:b0:48b:aa2:1d9f with SMTP id z10-20020ac2418a000000b0048b0aa21d9fmr12284425lfh.195.1660218793156; Thu, 11 Aug 2022 04:53:13 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id t21-20020a056512209500b0048b37616f13sm679005lfr.206.2022.08.11.04.53.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Aug 2022 04:53:12 -0700 (PDT) Message-ID: Date: Thu, 11 Aug 2022 14:53:11 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs Content-Language: en-US To: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Cc: krzysztof.kozlowski+dt@linaro.org, avri.altman@wdc.com, bvanassche@acm.org, martin.petersen@oracle.com, chanho61.park@samsung.com, linux-samsung-soc@vger.kernel.org References: <20220811113550.31914-1-alim.akhtar@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220811113550.31914-1-alim.akhtar@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/08/2022 14:35, Alim Akhtar wrote: > struct fsd_ufs_drvs is not used outside this file, so made it static. > This fixes sparse warning: > > drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse: > symbol 'fsd_ufs_drvs' was not declared. Should it be static? > > Reported-by: kernel test robot > Fixes: 216f74e8059a ("scsi: ufs: host: ufs-exynos: Add support for FSD UFS HCI") > Signed-off-by: Alim Akhtar This should be static const. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17D45C19F2A for ; Thu, 11 Aug 2022 11:54:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aAiau7n+vcVHtaYjhKWCu1UWCCoTsGRlBBA50RpEzY8=; b=vaMo0bGrfhcDky WyeQnSusbojQnkBhQrJRvYrRhGGc/4UxfdDMxOuWaWwpEyE9d0rjLryUVTtEsH2WWvnTSqMULStSf 0PMvW0x2hq8lrwSDbDFvSL84tDcPBmbFCLSr2bFRB5BfFHvtKC7KWzfXBXHMBPmn0bhdn8EzPa0bs aszo6sdCwpppBZtwAr1+e4FQgKoLxbY1MxRa1h2rkmiiTb+AyQoPdwl/RBJSQz5jFgyIPspA03K/i HTaVYLuQ82AmgSdHBVHPE8nTArfgDSf8q2yfYzUiSwnBM6K9fFxdQV+kfGokxY98p+eKoKftBUjC8 gm81U/uBXBRZIg8HybKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oM6kY-00Bpg4-UM; Thu, 11 Aug 2022 11:53:19 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oM6kV-00Bpe6-RI for linux-arm-kernel@lists.infradead.org; Thu, 11 Aug 2022 11:53:17 +0000 Received: by mail-lf1-x129.google.com with SMTP id a9so25184872lfm.12 for ; Thu, 11 Aug 2022 04:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=5HiYzFHc/9Xp6EzsvXqUwFD4ssSumNPG0+vT3T1mUK0=; b=eDCPKHKlMIy/f4StHh/b1bfEoZExC+kNQgf1fkCBF1qyOR9H1Ay5YCMC+cVsuh3Ght 7DwYOLrllPXCy0IOKoA0Hx2PkH60cTX4/lZhWvGtdYpKDiKUtj7iH6fTITy0GpOfXkRt 6gH0sIXYVXySMUtSPGLVP8OEiu7T/lIj8aNVDWyZsw+ofnklpDrmfg91S70EM4aQt3W1 ZJY6c8wC+QbVt4Wv/iWIDZyxEw5Bz9wmaM64t0vzSpKgxyCuzCG5G38uMrLwLguv8yap es/32BddycSQ26VJhiRINI8pyT2lJrA+VZpENMgnS27aa/fMesWvf3NAz3h7GAcHsFdx zRYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=5HiYzFHc/9Xp6EzsvXqUwFD4ssSumNPG0+vT3T1mUK0=; b=Qg5Shla3g7eAKIcOF06Qd6iVxcpbVC8+QUWSisL8yvhpNC+0Bkn+guGGPG5dnAkCdx wTD5Mb6CrF24pUN/yKkzHj8zNTZGYWz/nzURFJHcjmawe154ggJnHpEGUMrMIJHJJrkK wNkNigg+Q/sodHTEJElqPWYrbgUGe/ZCh6ie6ubbxRMtpyVB5fvygsgVCe8V+N2fEIVD rWUHp8C4YdsCRZjN7crmhu336h4Z2zW+fGr+n8MjzBiaea3FL5K1L4noO1/Jv9WmgYUR S+LMbqezKay1Fk766/7kwecrQVS1qdoRLhu8WM9LYVRJjvwfxkqrpVsl37TzAVYuytEi nfkw== X-Gm-Message-State: ACgBeo3LU1vjWt3FsjL4PLrWw2CZdNPp6WRK+Nth4wk7zSwwpcrOZEW6 J1P9+FAAlRfJooadQzja+UUwOQ== X-Google-Smtp-Source: AA6agR4xWcrV3sC9joYRds2dRPdF5QYf+E49P5o/1hiFlngFTfZ6XBB3+3ZXhz0ewEzcMt8g6j4ThQ== X-Received: by 2002:ac2:418a:0:b0:48b:aa2:1d9f with SMTP id z10-20020ac2418a000000b0048b0aa21d9fmr12284425lfh.195.1660218793156; Thu, 11 Aug 2022 04:53:13 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id t21-20020a056512209500b0048b37616f13sm679005lfr.206.2022.08.11.04.53.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Aug 2022 04:53:12 -0700 (PDT) Message-ID: Date: Thu, 11 Aug 2022 14:53:11 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs Content-Language: en-US To: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Cc: krzysztof.kozlowski+dt@linaro.org, avri.altman@wdc.com, bvanassche@acm.org, martin.petersen@oracle.com, chanho61.park@samsung.com, linux-samsung-soc@vger.kernel.org References: <20220811113550.31914-1-alim.akhtar@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220811113550.31914-1-alim.akhtar@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220811_045315_934452_30A86A9C X-CRM114-Status: GOOD ( 10.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/08/2022 14:35, Alim Akhtar wrote: > struct fsd_ufs_drvs is not used outside this file, so made it static. > This fixes sparse warning: > > drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse: > symbol 'fsd_ufs_drvs' was not declared. Should it be static? > > Reported-by: kernel test robot > Fixes: 216f74e8059a ("scsi: ufs: host: ufs-exynos: Add support for FSD UFS HCI") > Signed-off-by: Alim Akhtar This should be static const. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel