* [PATCH] iio: light: Add raw attribute
@ 2022-08-11 10:14 Shreeya Patel
2022-08-11 10:43 ` Dmitry Osipenko
2022-08-11 13:25 ` Jonathan Cameron
0 siblings, 2 replies; 5+ messages in thread
From: Shreeya Patel @ 2022-08-11 10:14 UTC (permalink / raw)
To: jic23, lars
Cc: linux-iio, linux-kernel, krisman, kernel, alvaro.soliverez,
Shreeya Patel
Add IIO_CHAN_INFO_RAW to the mask to be able to read raw values
from the light sensor.
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
---
drivers/iio/light/ltrf216a.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/iio/light/ltrf216a.c b/drivers/iio/light/ltrf216a.c
index e6e24e70d2b9..a717bf99bd2a 100644
--- a/drivers/iio/light/ltrf216a.c
+++ b/drivers/iio/light/ltrf216a.c
@@ -93,6 +93,7 @@ static const struct iio_chan_spec ltrf216a_channels[] = {
{
.type = IIO_LIGHT,
.info_mask_separate =
+ BIT(IIO_CHAN_INFO_RAW) |
BIT(IIO_CHAN_INFO_PROCESSED) |
BIT(IIO_CHAN_INFO_INT_TIME),
.info_mask_separate_available =
@@ -259,6 +260,18 @@ static int ltrf216a_read_raw(struct iio_dev *indio_dev,
int ret;
switch (mask) {
+ case IIO_CHAN_INFO_RAW:
+ ret = ltrf216a_set_power_state(data, true);
+ if (ret)
+ return ret;
+ mutex_lock(&data->lock);
+ ret = ltrf216a_read_data(data, LTRF216A_ALS_DATA_0);
+ mutex_unlock(&data->lock);
+ if (ret < 0)
+ return ret;
+ *val = ret;
+ ltrf216a_set_power_state(data, false);
+ return IIO_VAL_INT;
case IIO_CHAN_INFO_PROCESSED:
mutex_lock(&data->lock);
ret = ltrf216a_get_lux(data);
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: light: Add raw attribute
2022-08-11 10:14 [PATCH] iio: light: Add raw attribute Shreeya Patel
@ 2022-08-11 10:43 ` Dmitry Osipenko
2022-08-11 10:51 ` Shreeya Patel
2022-08-11 13:25 ` Jonathan Cameron
1 sibling, 1 reply; 5+ messages in thread
From: Dmitry Osipenko @ 2022-08-11 10:43 UTC (permalink / raw)
To: Shreeya Patel, jic23, lars
Cc: linux-iio, linux-kernel, krisman, kernel, alvaro.soliverez
On 8/11/22 13:14, Shreeya Patel wrote:
> + case IIO_CHAN_INFO_RAW:
> + ret = ltrf216a_set_power_state(data, true);
> + if (ret)
> + return ret;
> + mutex_lock(&data->lock);
> + ret = ltrf216a_read_data(data, LTRF216A_ALS_DATA_0);
> + mutex_unlock(&data->lock);
ltrf216a_set_power_state(data, false) should be called before return.
> + if (ret < 0)
> + return ret;
> + *val = ret;
> + ltrf216a_set_power_state(data, false);
--
Best regards,
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: light: Add raw attribute
2022-08-11 10:43 ` Dmitry Osipenko
@ 2022-08-11 10:51 ` Shreeya Patel
0 siblings, 0 replies; 5+ messages in thread
From: Shreeya Patel @ 2022-08-11 10:51 UTC (permalink / raw)
To: Dmitry Osipenko, jic23, lars
Cc: linux-iio, linux-kernel, krisman, kernel, alvaro.soliverez
On 11/08/22 16:13, Dmitry Osipenko wrote:
> On 8/11/22 13:14, Shreeya Patel wrote:
>> + case IIO_CHAN_INFO_RAW:
>> + ret = ltrf216a_set_power_state(data, true);
>> + if (ret)
>> + return ret;
>> + mutex_lock(&data->lock);
>> + ret = ltrf216a_read_data(data, LTRF216A_ALS_DATA_0);
>> + mutex_unlock(&data->lock);
> ltrf216a_set_power_state(data, false) should be called before return.
ah! yes, missed that. Thanks for pointing out. I'll send a v2.
Thanks,
Shreeya Patel
>> + if (ret < 0)
>> + return ret;
>> + *val = ret;
>> + ltrf216a_set_power_state(data, false);
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: light: Add raw attribute
2022-08-11 10:14 [PATCH] iio: light: Add raw attribute Shreeya Patel
2022-08-11 10:43 ` Dmitry Osipenko
@ 2022-08-11 13:25 ` Jonathan Cameron
2022-08-11 14:18 ` Shreeya Patel
1 sibling, 1 reply; 5+ messages in thread
From: Jonathan Cameron @ 2022-08-11 13:25 UTC (permalink / raw)
To: Shreeya Patel
Cc: jic23, lars, linux-iio, linux-kernel, krisman, kernel,
alvaro.soliverez
On Thu, 11 Aug 2022 15:44:43 +0530
Shreeya Patel <shreeya.patel@collabora.com> wrote:
> Add IIO_CHAN_INFO_RAW to the mask to be able to read raw values
> from the light sensor.
Why is this useful? It's rare to support _PROCESSED and _RAW for the same channel.
Normally occurred to avoid breaking ABI.
Jonathan
>
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> ---
> drivers/iio/light/ltrf216a.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/iio/light/ltrf216a.c b/drivers/iio/light/ltrf216a.c
> index e6e24e70d2b9..a717bf99bd2a 100644
> --- a/drivers/iio/light/ltrf216a.c
> +++ b/drivers/iio/light/ltrf216a.c
> @@ -93,6 +93,7 @@ static const struct iio_chan_spec ltrf216a_channels[] = {
> {
> .type = IIO_LIGHT,
> .info_mask_separate =
> + BIT(IIO_CHAN_INFO_RAW) |
> BIT(IIO_CHAN_INFO_PROCESSED) |
> BIT(IIO_CHAN_INFO_INT_TIME),
> .info_mask_separate_available =
> @@ -259,6 +260,18 @@ static int ltrf216a_read_raw(struct iio_dev *indio_dev,
> int ret;
>
> switch (mask) {
> + case IIO_CHAN_INFO_RAW:
> + ret = ltrf216a_set_power_state(data, true);
> + if (ret)
> + return ret;
> + mutex_lock(&data->lock);
> + ret = ltrf216a_read_data(data, LTRF216A_ALS_DATA_0);
> + mutex_unlock(&data->lock);
> + if (ret < 0)
> + return ret;
> + *val = ret;
> + ltrf216a_set_power_state(data, false);
> + return IIO_VAL_INT;
> case IIO_CHAN_INFO_PROCESSED:
> mutex_lock(&data->lock);
> ret = ltrf216a_get_lux(data);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: light: Add raw attribute
2022-08-11 13:25 ` Jonathan Cameron
@ 2022-08-11 14:18 ` Shreeya Patel
0 siblings, 0 replies; 5+ messages in thread
From: Shreeya Patel @ 2022-08-11 14:18 UTC (permalink / raw)
To: Jonathan Cameron
Cc: jic23, lars, linux-iio, linux-kernel, krisman, kernel,
alvaro.soliverez
On 11/08/22 18:55, Jonathan Cameron wrote:
> On Thu, 11 Aug 2022 15:44:43 +0530
> Shreeya Patel <shreeya.patel@collabora.com> wrote:
>
>> Add IIO_CHAN_INFO_RAW to the mask to be able to read raw values
>> from the light sensor.
> Why is this useful? It's rare to support _PROCESSED and _RAW for the same channel.
> Normally occurred to avoid breaking ABI.
Hi Jonathan,
For some context, we have been using a downstream driver for ltrf216a
in steam deck. The formula for Lux calculation used in that driver is
incorrect which we corrected in the driver that has been upstreamed now.
The userspace code to handle brightness on steam deck uses the
in_illuminance_input
value from sysfs and multiplies that value with some constant stored in
BIOS at
factory calibration time.
With the Lux calculation change in upstreamed driver,
in_illuminance_input gives us
a different value leading to change in the brightness on steam deck. It
is also not possible
for us to recalculate the constant stored in BIOS.
We need a way to add some magic in userspace code so that brightness
adjustment
works like before. So I'm trying to calculate a constant using the
current formula
that we are using :-
( greendata * 45 * LTRF216A_WIN_FAC ) / ( data->als_data_gain *
data->int_time_fac)
Except for the greendata which is ALS_DATA, I have all the other values
to calculate
a constant, hence, I added RAW attribute so I can read the ALS_DATA
value from userspace.
Thanks,
Shreeya Patel
>
> Jonathan
>
>> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
>> ---
>> drivers/iio/light/ltrf216a.c | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/drivers/iio/light/ltrf216a.c b/drivers/iio/light/ltrf216a.c
>> index e6e24e70d2b9..a717bf99bd2a 100644
>> --- a/drivers/iio/light/ltrf216a.c
>> +++ b/drivers/iio/light/ltrf216a.c
>> @@ -93,6 +93,7 @@ static const struct iio_chan_spec ltrf216a_channels[] = {
>> {
>> .type = IIO_LIGHT,
>> .info_mask_separate =
>> + BIT(IIO_CHAN_INFO_RAW) |
>> BIT(IIO_CHAN_INFO_PROCESSED) |
>> BIT(IIO_CHAN_INFO_INT_TIME),
>> .info_mask_separate_available =
>> @@ -259,6 +260,18 @@ static int ltrf216a_read_raw(struct iio_dev *indio_dev,
>> int ret;
>>
>> switch (mask) {
>> + case IIO_CHAN_INFO_RAW:
>> + ret = ltrf216a_set_power_state(data, true);
>> + if (ret)
>> + return ret;
>> + mutex_lock(&data->lock);
>> + ret = ltrf216a_read_data(data, LTRF216A_ALS_DATA_0);
>> + mutex_unlock(&data->lock);
>> + if (ret < 0)
>> + return ret;
>> + *val = ret;
>> + ltrf216a_set_power_state(data, false);
>> + return IIO_VAL_INT;
>> case IIO_CHAN_INFO_PROCESSED:
>> mutex_lock(&data->lock);
>> ret = ltrf216a_get_lux(data);
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-11 14:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-11 10:14 [PATCH] iio: light: Add raw attribute Shreeya Patel
2022-08-11 10:43 ` Dmitry Osipenko
2022-08-11 10:51 ` Shreeya Patel
2022-08-11 13:25 ` Jonathan Cameron
2022-08-11 14:18 ` Shreeya Patel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.