* [Qemu-devel] [PATCH v1 1/1] xlnx-ep108: Fix minimum RAM check
@ 2015-11-20 12:09 Alistair Francis
2015-11-23 16:51 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Alistair Francis @ 2015-11-20 12:09 UTC (permalink / raw
To: qemu-devel, peter.maydell; +Cc: crosthwaitepeter, stefanha, alistair.francis
The minimum RAM check logic for the Xiilnx EP108 was off by one,
which caused a false positive. Correct the logic to only print
warnings when the RAM is below 0x8000000.
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
hw/arm/xlnx-ep108.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c
index 2899698..85b978f 100644
--- a/hw/arm/xlnx-ep108.c
+++ b/hw/arm/xlnx-ep108.c
@@ -51,7 +51,7 @@ static void xlnx_ep108_init(MachineState *machine)
machine->ram_size = EP108_MAX_RAM_SIZE;
}
- if (machine->ram_size <= 0x08000000) {
+ if (machine->ram_size < 0x08000000) {
qemu_log("WARNING: RAM size " RAM_ADDR_FMT " is small for EP108",
machine->ram_size);
}
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] xlnx-ep108: Fix minimum RAM check
2015-11-20 12:09 [Qemu-devel] [PATCH v1 1/1] xlnx-ep108: Fix minimum RAM check Alistair Francis
@ 2015-11-23 16:51 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2015-11-23 16:51 UTC (permalink / raw
To: Alistair Francis; +Cc: Peter Crosthwaite, QEMU Developers, Stefan Hajnoczi
On 20 November 2015 at 12:09, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> The minimum RAM check logic for the Xiilnx EP108 was off by one,
> which caused a false positive. Correct the logic to only print
> warnings when the RAM is below 0x8000000.
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
>
> hw/arm/xlnx-ep108.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c
> index 2899698..85b978f 100644
> --- a/hw/arm/xlnx-ep108.c
> +++ b/hw/arm/xlnx-ep108.c
> @@ -51,7 +51,7 @@ static void xlnx_ep108_init(MachineState *machine)
> machine->ram_size = EP108_MAX_RAM_SIZE;
> }
>
> - if (machine->ram_size <= 0x08000000) {
> + if (machine->ram_size < 0x08000000) {
> qemu_log("WARNING: RAM size " RAM_ADDR_FMT " is small for EP108",
> machine->ram_size);
> }
> --
> 2.5.0
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-23 16:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-20 12:09 [Qemu-devel] [PATCH v1 1/1] xlnx-ep108: Fix minimum RAM check Alistair Francis
2015-11-23 16:51 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.