From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, "Thomas Huth" <thuth@redhat.com>
Cc: "Willian Rampazzo" <willianr@redhat.com>,
"Stefan Weil" <sw@weilnetz.de>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2
Date: Wed, 12 May 2021 13:44:51 +0200 [thread overview]
Message-ID: <fcb6b808-c1de-d5f3-064c-1725c49999e0@redhat.com> (raw)
In-Reply-To: <20210511132641.1022161-13-berrange@redhat.com>
On 5/11/21 3:26 PM, Daniel P. Berrangé wrote:
> Several distros have been dropped since the last time we bumped the
> minimum required CLang version.
>
> Per repology, currently shipping versions are:
>
> RHEL-8: 10.0.1
> Debian Stretch: 7.0.1
> Debian Buster: 7.0.1
> openSUSE Leap 15.2: 9.0.1
> Ubuntu LTS 18.04: 10.0.0
> Ubuntu LTS 20.04: 11.0.0
> FreeBSD 12: 8.0.1
> Fedora 33: 11.0.0
> Fedora 34: 11.1.0
>
> With this list Debian Stretch is the constraint at 7.0.1
>
> An LLVM version of 7.0.1 corresponds to macOS XCode version of 10.2
> which dates from March 2019.
But we still rely on Travis-CI (Ubuntu Bionic 18.04 LTS)
for non-x86 targets until we have figured out who is willing
to share/maintain such non-x86 native runners on Gitlab.
There:
$ clang --version
clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
If we don't use Travis-CI, then your patch is fine, but we
need a previous patch removing .travis.yml.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> configure | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/configure b/configure
> index 43d2470bb6..c41a3e5eef 100755
> --- a/configure
> +++ b/configure
> @@ -2050,12 +2050,12 @@ fi
> cat > $TMPC << EOF
> #if defined(__clang_major__) && defined(__clang_minor__)
> # ifdef __apple_build_version__
> -# if __clang_major__ < 5 || (__clang_major__ == 5 && __clang_minor__ < 1)
> -# error You need at least XCode Clang v5.1 to compile QEMU
> +# if __clang_major__ < 10 || (__clang_major__ == 10 && __clang_minor__ < 2)
> +# error You need at least XCode Clang v10.2 to compile QEMU
> # endif
> # else
> -# if __clang_major__ < 3 || (__clang_major__ == 3 && __clang_minor__ < 4)
> -# error You need at least Clang v3.4 to compile QEMU
> +# if __clang_major__ < 7 || (__clang_major__ == 7 && __clang_minor__ < 0)
> +# error You need at least Clang v7.0 to compile QEMU
> # endif
> # endif
> #elif defined(__GNUC__) && defined(__GNUC_MINOR__)
> @@ -2068,7 +2068,7 @@ cat > $TMPC << EOF
> int main (void) { return 0; }
> EOF
> if ! compile_prog "" "" ; then
> - error_exit "You need at least GCC v6.3 or Clang v3.4 (or XCode Clang v5.1)"
> + error_exit "You need at least GCC v6.3 or Clang v7.0 (or XCode Clang v10.2)"
> fi
>
> # Accumulate -Wfoo and -Wno-bar separately.
>
next prev parent reply other threads:[~2021-05-12 11:46 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 13:26 [PATCH 00/12] Wave goodbye to RHEL 7 vintage distros Daniel P. Berrangé
2021-05-11 13:26 ` [PATCH 01/12] gitlab: move linux user build job from CentOS 7 to CentOS 8 Daniel P. Berrangé
2021-05-11 13:54 ` Thomas Huth
2021-05-11 14:04 ` Daniel P. Berrangé
2021-05-12 16:19 ` Philippe Mathieu-Daudé
2021-05-12 16:28 ` Peter Maydell
2021-05-11 13:26 ` [PATCH 02/12] patchew: move quick build job from CentOS 7 to CentOS 8 container Daniel P. Berrangé
2021-05-11 13:57 ` Thomas Huth
2021-05-11 13:26 ` [PATCH 03/12] crypto: bump min nettle to 3.3, dropping RHEL-7 support Daniel P. Berrangé
2021-05-11 14:01 ` Thomas Huth
2021-05-11 20:56 ` Willian Rampazzo
2021-05-12 0:40 ` Richard Henderson
2021-05-11 13:26 ` [PATCH 04/12] crypto: drop back compatibility typedefs for nettle Daniel P. Berrangé
2021-05-11 14:03 ` Thomas Huth
2021-05-12 0:40 ` Richard Henderson
2021-05-11 13:26 ` [PATCH 05/12] crypto: bump min gcrypt to 1.7.6, dropping RHEL-7 support Daniel P. Berrangé
2021-05-11 14:06 ` Thomas Huth
2021-05-11 20:58 ` Willian Rampazzo
2021-05-12 0:40 ` Richard Henderson
2021-05-11 13:26 ` [PATCH 06/12] crypto: bump min gnutls to 3.5.8, " Daniel P. Berrangé
2021-05-11 14:07 ` Thomas Huth
2021-05-11 20:59 ` Willian Rampazzo
2021-05-12 0:39 ` Richard Henderson
2021-05-11 13:26 ` [PATCH 07/12] crypto: drop used conditional check Daniel P. Berrangé
2021-05-11 21:01 ` Willian Rampazzo
2021-05-12 0:41 ` Richard Henderson
2021-05-11 13:26 ` [PATCH 08/12] tests/vm: convert centos VM recipe to CentOS 8 Daniel P. Berrangé
2021-05-11 15:04 ` Daniel P. Berrangé
2021-05-11 13:26 ` [PATCH 09/12] tests/docker: drop CentOS 7 container Daniel P. Berrangé
2021-05-11 14:09 ` Thomas Huth
2021-05-11 14:25 ` Alex Bennée
2021-05-11 20:52 ` Willian Rampazzo
2021-05-11 13:26 ` [PATCH 10/12] bump min required glib version to 2.50 Daniel P. Berrangé
2021-05-11 14:11 ` Thomas Huth
2021-05-11 21:03 ` Willian Rampazzo
2021-05-11 13:26 ` [PATCH 11/12] configure: bump min required GCC to 6.3.0 Daniel P. Berrangé
2021-05-11 14:15 ` Thomas Huth
2021-05-11 14:31 ` Daniel P. Berrangé
2021-05-11 21:04 ` Willian Rampazzo
2021-05-12 0:43 ` Richard Henderson
2021-05-11 13:26 ` [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2 Daniel P. Berrangé
2021-05-11 14:18 ` Thomas Huth
2021-05-11 14:32 ` Daniel P. Berrangé
2021-05-11 21:05 ` Willian Rampazzo
2021-05-12 0:44 ` Richard Henderson
2021-05-12 11:44 ` Philippe Mathieu-Daudé [this message]
2021-05-12 11:53 ` non-x86 runners in the Gitlab-CI (was: Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2) Thomas Huth
2021-05-12 13:47 ` Willian Rampazzo
2021-05-12 13:55 ` Thomas Huth
2021-05-12 13:59 ` Willian Rampazzo
2021-05-12 14:33 ` Thomas Huth
2021-05-12 14:00 ` Daniel P. Berrangé
2021-05-12 14:51 ` Philippe Mathieu-Daudé
2021-05-12 15:29 ` Daniel P. Berrangé
2021-05-12 12:25 ` [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2 Daniel P. Berrangé
2021-05-12 14:10 ` Philippe Mathieu-Daudé
2021-05-12 14:43 ` Daniel P. Berrangé
2021-05-11 14:33 ` [PATCH 00/12] Wave goodbye to RHEL 7 vintage distros Thomas Huth
2021-05-13 10:05 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcb6b808-c1de-d5f3-064c-1725c49999e0@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sw@weilnetz.de \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.