From: Brian King <brking@linux.vnet.ibm.com>
To: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
james.bottomley@hansenpartnership.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com
Subject: Re: [PATCH] ibmvscsi: use GFP_KERNEL with dma_alloc_coherent in initialize_event_pool
Date: Thu, 10 Jan 2019 08:56:56 -0600 [thread overview]
Message-ID: <fd33df0e-012b-e437-c6e9-29cd0883808d@linux.vnet.ibm.com> (raw)
In-Reply-To: <1547089149-20577-1-git-send-email-tyreld@linux.vnet.ibm.com>
On 01/09/2019 08:59 PM, Tyrel Datwyler wrote:
> During driver probe we allocate a dma region for our event pool.
> Currently, zero is passed for the gfp_flags parameter. Driver probe
> callbacks run in process context and we hold no locks so we can sleep
> here if necessary.
>
> Fix by passing GFP_KERNEL explicitly to dma_alloc_coherent().
>
> Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
> ---
> drivers/scsi/ibmvscsi/ibmvscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index cb8535e..10d5e77 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -465,7 +465,7 @@ static int initialize_event_pool(struct event_pool *pool,
> pool->iu_storage =
> dma_alloc_coherent(hostdata->dev,
> pool->size * sizeof(*pool->iu_storage),
> - &pool->iu_token, 0);
> + &pool->iu_token, GFP_KERNEL);
> if (!pool->iu_storage) {
> kfree(pool->events);
> return -ENOMEM;
>
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
--
Brian King
Power Linux I/O
IBM Linux Technology Center
next prev parent reply other threads:[~2019-01-10 14:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 2:59 [PATCH] ibmvscsi: use GFP_KERNEL with dma_alloc_coherent in initialize_event_pool Tyrel Datwyler
2019-01-10 14:56 ` Brian King [this message]
2021-10-14 23:15 ` Tyrel Datwyler
2021-10-14 23:15 ` Tyrel Datwyler
2021-10-15 4:36 ` Michael Ellerman
2021-10-15 4:36 ` Michael Ellerman
2021-10-15 19:37 ` Tyrel Datwyler
2021-10-15 19:37 ` Tyrel Datwyler
2021-10-17 2:20 ` Martin K. Petersen
2021-10-17 2:20 ` Martin K. Petersen
2021-10-21 3:42 ` Martin K. Petersen
2021-10-21 3:42 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd33df0e-012b-e437-c6e9-29cd0883808d@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.