From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 911C2C433FE for ; Thu, 24 Mar 2022 18:47:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352731AbiCXSsr (ORCPT ); Thu, 24 Mar 2022 14:48:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232392AbiCXSsq (ORCPT ); Thu, 24 Mar 2022 14:48:46 -0400 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD9364163D; Thu, 24 Mar 2022 11:47:13 -0700 (PDT) Received: by mail-wr1-f44.google.com with SMTP id b19so7867581wrh.11; Thu, 24 Mar 2022 11:47:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=KDJpjxd6iOA3qWDHcyReo9R0utRfpUnP8h7B7fwBi2g=; b=3XuGON3DxzT6DBDjZK75nsDGsCeX+ECY+sdXsjA94aWIb2A+DGlQNnTf0Ye8i4Vjbr 0WF8mpGMqDFqxtdaB1la30Ca6KCbWzDMn9F9IKksddiQzvUdU22azYJm+IlClJbLAJbf 2/ZS5wRFgvCHAHPmb/AeXLyQ2J53Pbo7PcMOckCYfOg7MsOaRJMuZsJVuUkv6rudRX2q WIuddjng85TaS2/tKgne6WPLFqvgcYPTySW8oQi9zNExo43XKQ9b8K1Sw/pRDh0T08v7 vr2NRDsRW1gcmvjN8QJBi3Hu/N5LqrxzMPyYqWc4WVitCzPyvWXGQS9rxaHUNqkFYGDE 3K3Q== X-Gm-Message-State: AOAM532eC/jr8/cSXbGvh6EBusMvLl5i9y43CrvQvCC+w3UM+wj0YLVC /2de2OOog0ybO/JBNEk7dJlMUinNlsAG8A== X-Google-Smtp-Source: ABdhPJyosxIuUQaMs6KYbGUBTrKWWFzdvtClypQ8lyIFfEwbQZ22wFQ5SU62O0nK9gFjmopcNxDwPA== X-Received: by 2002:a5d:424d:0:b0:204:7fc:d6c6 with SMTP id s13-20020a5d424d000000b0020407fcd6c6mr5601658wrr.291.1648147632374; Thu, 24 Mar 2022 11:47:12 -0700 (PDT) Received: from [192.168.0.158] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.googlemail.com with ESMTPSA id bj26-20020a0560001e1a00b0020597757ebcsm2186322wrb.7.2022.03.24.11.47.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Mar 2022 11:47:11 -0700 (PDT) Message-ID: Date: Thu, 24 Mar 2022 19:47:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 1/2] dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711 Content-Language: en-US To: Adrien Thierry , linux-kernel@vger.kernel.org Cc: Rob Herring , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Stefan Wahren , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Gaston Gonzalez , Ojaswin Mujoo , linux-staging@lists.linux.dev References: <20220324172647.167617-1-athierry@redhat.com> <20220324172647.167617-2-athierry@redhat.com> From: Krzysztof Kozlowski In-Reply-To: <20220324172647.167617-2-athierry@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/03/2022 18:26, Adrien Thierry wrote: > Add a new compatible string for BCM2711. This is the chip used on the > Raspberry Pi 4. > > Signed-off-by: Adrien Thierry > --- > Changes since v1: > - Removed duplicate compatible string for bcm2711 > > .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml > index e04439b3355b..9cb957facae0 100644 > --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml > +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml > @@ -27,6 +27,11 @@ properties: > - brcm,bcm2836-vchiq > - const: brcm,bcm2835-vchiq > > + - description: BCM2711 based boards > + items: > + - enum: > + - brcm,bcm2711-vchiq This oneOf here - just to add description which is copy-paste of compatible - does not make sense. It should be just enum with compatibles. At least for 2711 and 2835 (and put them in alphabetical order). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51D86C433EF for ; Thu, 24 Mar 2022 18:48:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mksZDPldUVhBdKDm15+5mwxZCDnGxo/Jv9nWnXW1kRU=; b=YNQiqBIy5pjDtz 0+h7b4/XKh7z3vzusiRB7S993/THBqaRSU30rBh/s0XDfN7sUSeIi5V7pveC4HVnKhjfnDsy76hbf cw8JlyYywely5EDPoeeN+YMHK6QaAfJ/YoTAE6asX3lwRVaZZBQXl9ce6NZqCYfyjs/DQLiJh6nBg Ftzb98uSPIgQUloYxa+WYIP0Wxi+YF7M98rnRAEL5iqdedTZceZRMtyXgMJ5LozLniBx9LfjDVlH4 +QKKgepADKou7gqI+m3iqv3OZBGjnyjAR0Zi8RSLIZEcM9NYgf/sxFQLomOGm1/dIbzFUGi0F9D6D d3AG5uHA/u0PV/YtGESA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXSUP-00HaEp-OI; Thu, 24 Mar 2022 18:47:17 +0000 Received: from mail-wr1-f53.google.com ([209.85.221.53]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXSUL-00HaEA-LY; Thu, 24 Mar 2022 18:47:15 +0000 Received: by mail-wr1-f53.google.com with SMTP id w4so7874728wrg.12; Thu, 24 Mar 2022 11:47:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=KDJpjxd6iOA3qWDHcyReo9R0utRfpUnP8h7B7fwBi2g=; b=CrzGcohqKM+PyUihQFWRg010NVSLWnfD766maVp3cGjgZqZZXPufkfDTEXPRjfLoEl gbyO3z0yv3cqFGf1xZ4Zq77M6YBzTnWxLF1NGdNgvr4CdgxJi/Jxi8PUuQXJf53H3fes UE7M40+qG34MnZJAVdmCL382uB/M7685s+d6Pi0rxnmTtFpgYDQX3X4n4kEmuUuzj1cs 9XsUT6rHTb4upXzuBzsBA+n1Qx5/5kThzhmKU7yS1ymd5zDAfNYotS5Zu5KBuIaa0Pc/ 8TsnHj8U/L0GogSnHiwPhjs2W2vJe5tFq2XnStOOmxotMLwBEXZpW5yAuMw8/UC+GYeO BPAw== X-Gm-Message-State: AOAM532V5fePo28wHvetY9BC7bEpor3tYM2UKUk4EAqf1rlgds62/bkx 0Al+TJxWcIJusj4tNQqwScw= X-Google-Smtp-Source: ABdhPJyosxIuUQaMs6KYbGUBTrKWWFzdvtClypQ8lyIFfEwbQZ22wFQ5SU62O0nK9gFjmopcNxDwPA== X-Received: by 2002:a5d:424d:0:b0:204:7fc:d6c6 with SMTP id s13-20020a5d424d000000b0020407fcd6c6mr5601658wrr.291.1648147632374; Thu, 24 Mar 2022 11:47:12 -0700 (PDT) Received: from [192.168.0.158] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.googlemail.com with ESMTPSA id bj26-20020a0560001e1a00b0020597757ebcsm2186322wrb.7.2022.03.24.11.47.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Mar 2022 11:47:11 -0700 (PDT) Message-ID: Date: Thu, 24 Mar 2022 19:47:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 1/2] dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711 Content-Language: en-US To: Adrien Thierry , linux-kernel@vger.kernel.org Cc: Rob Herring , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Stefan Wahren , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Gaston Gonzalez , Ojaswin Mujoo , linux-staging@lists.linux.dev References: <20220324172647.167617-1-athierry@redhat.com> <20220324172647.167617-2-athierry@redhat.com> From: Krzysztof Kozlowski In-Reply-To: <20220324172647.167617-2-athierry@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220324_114713_767076_BE977AB5 X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/03/2022 18:26, Adrien Thierry wrote: > Add a new compatible string for BCM2711. This is the chip used on the > Raspberry Pi 4. > > Signed-off-by: Adrien Thierry > --- > Changes since v1: > - Removed duplicate compatible string for bcm2711 > > .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml > index e04439b3355b..9cb957facae0 100644 > --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml > +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml > @@ -27,6 +27,11 @@ properties: > - brcm,bcm2836-vchiq > - const: brcm,bcm2835-vchiq > > + - description: BCM2711 based boards > + items: > + - enum: > + - brcm,bcm2711-vchiq This oneOf here - just to add description which is copy-paste of compatible - does not make sense. It should be just enum with compatibles. At least for 2711 and 2835 (and put them in alphabetical order). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel