From: Takashi Iwai <tiwai@suse.de>
To: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Cc: patches.audio@intel.com, Vinod Koul <vinod.koul@intel.com>,
alsa-devel@alsa-project.org, broonie@kernel.org,
lgirdwood@gmail.com
Subject: Re: [PATCH v3 07/15] ASoC: hdac_hdmi: create dais based on number of streams
Date: Mon, 07 Dec 2015 17:11:01 +0100 [thread overview]
Message-ID: <s5h1tayme7e.wl-tiwai@suse.de> (raw)
In-Reply-To: <1449523469-4395-7-git-send-email-subhransu.s.prusty@intel.com>
On Mon, 07 Dec 2015 22:24:21 +0100,
Subhransu S. Prusty wrote:
>
> A stream is mapped to a converter. So based on the converters
> queried, dais are created.
>
> The streams can be dynamically routed to any converter. For
> now it is mapped statically. The dynamic mapping of stream
> to converter will be added when required.
>
> Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> ---
> sound/soc/codecs/hdac_hdmi.c | 108 ++++++++++++++++++++++++++++++-------------
> 1 file changed, 76 insertions(+), 32 deletions(-)
>
> diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c
> index 27d1a54..01d063e 100644
> --- a/sound/soc/codecs/hdac_hdmi.c
> +++ b/sound/soc/codecs/hdac_hdmi.c
> @@ -30,6 +30,8 @@
> #include <sound/pcm_drm_eld.h>
> #include "../../hda/local.h"
>
> +#define NAME_SIZE 32
> +
> #define AMP_OUT_MUTE 0xb080
> #define AMP_OUT_UNMUTE 0xb000
> #define PIN_OUT (AC_PINCTL_OUT_EN)
> @@ -685,11 +687,67 @@ static void hdac_hdmi_skl_enable_dp12(struct hdac_device *hdac)
>
> }
>
> +static struct snd_soc_dai_ops hdmi_dai_ops = {
> + .startup = hdac_hdmi_pcm_open,
> + .shutdown = hdac_hdmi_pcm_close,
> + .hw_params = hdac_hdmi_set_hw_params,
> + .prepare = hdac_hdmi_playback_prepare,
> + .hw_free = hdac_hdmi_playback_cleanup,
> +};
> +
> +static int hdac_hdmi_create_dais(struct hdac_device *hdac,
> + struct snd_soc_dai_driver **dais,
> + struct hdac_hdmi_priv *hdmi, int num_dais)
> +{
> + struct snd_soc_dai_driver *hdmi_dais;
> + struct hdac_hdmi_cvt *cvt;
> + char name[NAME_SIZE], dai_name[NAME_SIZE];
> + int i = 0;
> + u32 rates, bps;
> + unsigned int rate_max = 384000, rate_min = 8000;
> + u64 formats;
> + int ret;
> +
> + hdmi_dais = devm_kzalloc(&hdac->dev, (sizeof(*hdmi_dais) * num_dais),
> + GFP_KERNEL);
> + if (!hdmi_dais)
> + return -ENOMEM;
> +
> + list_for_each_entry(cvt, &hdmi->cvt_list, head) {
> + ret = snd_hdac_query_supported_pcm(hdac, cvt->nid, &rates,
> + &formats, &bps);
> + if (ret)
> + return ret;
> +
> + sprintf(dai_name, "intel-hdmi-hifi%d", i+1);
> + hdmi_dais[i].name = devm_kstrdup(&hdac->dev, dai_name,
> + GFP_KERNEL);
> +
Missing NULL check.
> + snprintf(name, sizeof(name), "hifi%d", i+1);
> + hdmi_dais[i].playback.stream_name =
> + devm_kstrdup(&hdac->dev, name, GFP_KERNEL);
Ditto.
Takashi
next prev parent reply other threads:[~2015-12-07 16:11 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 21:17 [PATCH v3 00/15] ASoC: hdac_hdmi: Add DP & notification support Subhransu S. Prusty
2015-12-07 20:12 ` Mark Brown
2015-12-08 11:24 ` Subhransu S. Prusty
2015-12-07 21:24 ` [PATCH v3 01/15] ASoC: hdac_hdmi: Fix to check num nodes correctly Subhransu S. Prusty
2015-12-07 21:24 ` [PATCH v3 02/15] ASoC: hdac_hdmi: Fix to warn instead of err for no connected nids Subhransu S. Prusty
2015-12-07 21:24 ` [PATCH v3 03/15] ASoC: hdac_hdmi: Use list to add pins and converters Subhransu S. Prusty
2016-01-08 13:44 ` Applied "ASoC: hdac_hdmi: Use list to add pins and converters" to the asoc tree Mark Brown
2015-12-07 21:24 ` [PATCH v3 04/15] ASoC: hdac_hdmi: Add hotplug notification and read eld Subhransu S. Prusty
2015-12-07 21:24 ` [PATCH v3 05/15] ASoC: hdac_hdmi: Apply constraints based on ELD Subhransu S. Prusty
2015-12-07 21:24 ` [PATCH v3 06/15] ASoC: hdac_hdmi: Enable DP1.2 and all converters/pins Subhransu S. Prusty
2015-12-07 21:24 ` [PATCH v3 07/15] ASoC: hdac_hdmi: create dais based on number of streams Subhransu S. Prusty
2015-12-07 16:11 ` Takashi Iwai [this message]
2015-12-07 21:24 ` [PATCH v3 08/15] ASoC: hdac_hdmi: Create widget/route based on nodes enumerated Subhransu S. Prusty
2015-12-07 16:14 ` Takashi Iwai
2015-12-08 11:28 ` Subhransu S. Prusty
2015-12-07 21:24 ` [PATCH v3 09/15] ASoC: hdac_hdmi: Assign pin for stream based on dapm connection Subhransu S. Prusty
2015-12-07 21:24 ` [PATCH v3 10/15] drm/edid: Add API to help find connection type Subhransu S. Prusty
2015-12-08 14:01 ` Jani Nikula
2015-12-07 21:24 ` [PATCH v3 11/15] ASoC: hdac_hdmi: Add infoframe support for dp audio Subhransu S. Prusty
2015-12-07 21:24 ` [PATCH v3 12/15] ASoC: hdac_hdmi: Add codec suspend/resume handler Subhransu S. Prusty
2015-12-07 21:24 ` [PATCH v3 13/15] ASoC: hdac_hdmi: Fix to keep display active while enumerating codec Subhransu S. Prusty
2015-12-07 21:24 ` [PATCH v3 14/15] ASoC: hdac_hdmi: Add jack reporting for user space Subhransu S. Prusty
2015-12-07 16:18 ` Takashi Iwai
2015-12-08 6:31 ` Vinod Koul
2015-12-08 6:38 ` Takashi Iwai
2015-12-08 7:42 ` Vinod Koul
2015-12-08 7:52 ` Takashi Iwai
2015-12-08 8:38 ` Vinod Koul
2015-12-08 8:42 ` Takashi Iwai
2015-12-08 10:20 ` Vinod Koul
2015-12-08 10:28 ` Takashi Iwai
2015-12-08 10:42 ` Vinod Koul
2015-12-08 10:51 ` Takashi Iwai
2015-12-08 10:59 ` Takashi Iwai
2015-12-09 5:44 ` Vinod Koul
2015-12-09 8:03 ` Subhransu S. Prusty
2015-12-09 8:13 ` Takashi Iwai
2015-12-09 11:14 ` Subhransu S. Prusty
2015-12-09 11:37 ` Takashi Iwai
2015-12-07 21:24 ` [PATCH v3 15/15] ASoC: hdac_hdmi: Fix to enable device configuration in hw_params Subhransu S. Prusty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1tayme7e.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches.audio@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.