All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: aoa: Drop owner assignment from i2c_driver
@ 2015-07-10  6:39 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-10  6:39 UTC (permalink / raw
  To: Johannes Berg, Jaroslav Kysela, Takashi Iwai, Krzysztof Kozlowski,
	open list:AOA (Apple Onboard Audio) ALSA DRIVER,
	moderated list:AOA (Apple Onboard Audio) ALSA DRIVER, open list

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

---

The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
 sound/aoa/codecs/onyx.c | 1 -
 sound/aoa/codecs/tas.c  | 1 -
 2 files changed, 2 deletions(-)

diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c
index 23c371ecfb6b..a04edff8b729 100644
--- a/sound/aoa/codecs/onyx.c
+++ b/sound/aoa/codecs/onyx.c
@@ -1050,7 +1050,6 @@ MODULE_DEVICE_TABLE(i2c,onyx_i2c_id);
 static struct i2c_driver onyx_driver = {
 	.driver = {
 		.name = "aoa_codec_onyx",
-		.owner = THIS_MODULE,
 	},
 	.probe = onyx_i2c_probe,
 	.remove = onyx_i2c_remove,
diff --git a/sound/aoa/codecs/tas.c b/sound/aoa/codecs/tas.c
index 364c7c4416e8..78ed1ffbf786 100644
--- a/sound/aoa/codecs/tas.c
+++ b/sound/aoa/codecs/tas.c
@@ -939,7 +939,6 @@ MODULE_DEVICE_TABLE(i2c,tas_i2c_id);
 static struct i2c_driver tas_driver = {
 	.driver = {
 		.name = "aoa_codec_tas",
-		.owner = THIS_MODULE,
 	},
 	.probe = tas_i2c_probe,
 	.remove = tas_i2c_remove,
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ALSA: aoa: Drop owner assignment from i2c_driver
@ 2015-07-10  6:39 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-10  6:39 UTC (permalink / raw
  To: Johannes Berg, Jaroslav Kysela, Takashi Iwai, Krzysztof Kozlowski,
	open list:AOA Apple Onboard Audio ALSA DRIVER,
	moderated list:AOA Apple Onboard Audio ALSA DRIVER, open list

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

---

The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
 sound/aoa/codecs/onyx.c | 1 -
 sound/aoa/codecs/tas.c  | 1 -
 2 files changed, 2 deletions(-)

diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c
index 23c371ecfb6b..a04edff8b729 100644
--- a/sound/aoa/codecs/onyx.c
+++ b/sound/aoa/codecs/onyx.c
@@ -1050,7 +1050,6 @@ MODULE_DEVICE_TABLE(i2c,onyx_i2c_id);
 static struct i2c_driver onyx_driver = {
 	.driver = {
 		.name = "aoa_codec_onyx",
-		.owner = THIS_MODULE,
 	},
 	.probe = onyx_i2c_probe,
 	.remove = onyx_i2c_remove,
diff --git a/sound/aoa/codecs/tas.c b/sound/aoa/codecs/tas.c
index 364c7c4416e8..78ed1ffbf786 100644
--- a/sound/aoa/codecs/tas.c
+++ b/sound/aoa/codecs/tas.c
@@ -939,7 +939,6 @@ MODULE_DEVICE_TABLE(i2c,tas_i2c_id);
 static struct i2c_driver tas_driver = {
 	.driver = {
 		.name = "aoa_codec_tas",
-		.owner = THIS_MODULE,
 	},
 	.probe = tas_i2c_probe,
 	.remove = tas_i2c_remove,
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: aoa: Drop owner assignment from i2c_driver
  2015-07-10  6:39 ` Krzysztof Kozlowski
@ 2015-07-10  7:54   ` Takashi Iwai
  -1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2015-07-10  7:54 UTC (permalink / raw
  To: Krzysztof Kozlowski
  Cc: Johannes Berg, Jaroslav Kysela,
	open list:AOA (Apple Onboard Audio) ALSA DRIVER,
	moderated list:AOA (Apple Onboard Audio) ALSA DRIVER, open list

On Fri, 10 Jul 2015 08:39:02 +0200,
Krzysztof Kozlowski wrote:
> 
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Applied, thanks.


Takashi

> 
> ---
> 
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
>  sound/aoa/codecs/onyx.c | 1 -
>  sound/aoa/codecs/tas.c  | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c
> index 23c371ecfb6b..a04edff8b729 100644
> --- a/sound/aoa/codecs/onyx.c
> +++ b/sound/aoa/codecs/onyx.c
> @@ -1050,7 +1050,6 @@ MODULE_DEVICE_TABLE(i2c,onyx_i2c_id);
>  static struct i2c_driver onyx_driver = {
>  	.driver = {
>  		.name = "aoa_codec_onyx",
> -		.owner = THIS_MODULE,
>  	},
>  	.probe = onyx_i2c_probe,
>  	.remove = onyx_i2c_remove,
> diff --git a/sound/aoa/codecs/tas.c b/sound/aoa/codecs/tas.c
> index 364c7c4416e8..78ed1ffbf786 100644
> --- a/sound/aoa/codecs/tas.c
> +++ b/sound/aoa/codecs/tas.c
> @@ -939,7 +939,6 @@ MODULE_DEVICE_TABLE(i2c,tas_i2c_id);
>  static struct i2c_driver tas_driver = {
>  	.driver = {
>  		.name = "aoa_codec_tas",
> -		.owner = THIS_MODULE,
>  	},
>  	.probe = tas_i2c_probe,
>  	.remove = tas_i2c_remove,
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: aoa: Drop owner assignment from i2c_driver
@ 2015-07-10  7:54   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2015-07-10  7:54 UTC (permalink / raw
  To: Krzysztof Kozlowski
  Cc: Johannes Berg, Jaroslav Kysela,
	open list:AOA Apple Onboard Audio ALSA DRIVER,
	moderated list:AOA Apple Onboard Audio ALSA DRIVER, open list

On Fri, 10 Jul 2015 08:39:02 +0200,
Krzysztof Kozlowski wrote:
> 
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Applied, thanks.


Takashi

> 
> ---
> 
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
>  sound/aoa/codecs/onyx.c | 1 -
>  sound/aoa/codecs/tas.c  | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c
> index 23c371ecfb6b..a04edff8b729 100644
> --- a/sound/aoa/codecs/onyx.c
> +++ b/sound/aoa/codecs/onyx.c
> @@ -1050,7 +1050,6 @@ MODULE_DEVICE_TABLE(i2c,onyx_i2c_id);
>  static struct i2c_driver onyx_driver = {
>  	.driver = {
>  		.name = "aoa_codec_onyx",
> -		.owner = THIS_MODULE,
>  	},
>  	.probe = onyx_i2c_probe,
>  	.remove = onyx_i2c_remove,
> diff --git a/sound/aoa/codecs/tas.c b/sound/aoa/codecs/tas.c
> index 364c7c4416e8..78ed1ffbf786 100644
> --- a/sound/aoa/codecs/tas.c
> +++ b/sound/aoa/codecs/tas.c
> @@ -939,7 +939,6 @@ MODULE_DEVICE_TABLE(i2c,tas_i2c_id);
>  static struct i2c_driver tas_driver = {
>  	.driver = {
>  		.name = "aoa_codec_tas",
> -		.owner = THIS_MODULE,
>  	},
>  	.probe = tas_i2c_probe,
>  	.remove = tas_i2c_remove,
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-07-10  7:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-10  6:39 [PATCH] ALSA: aoa: Drop owner assignment from i2c_driver Krzysztof Kozlowski
2015-07-10  6:39 ` Krzysztof Kozlowski
2015-07-10  7:54 ` Takashi Iwai
2015-07-10  7:54   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.