From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC13EC4338F for ; Fri, 30 Jul 2021 18:14:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D7B560F4A for ; Fri, 30 Jul 2021 18:14:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230119AbhG3SOM (ORCPT ); Fri, 30 Jul 2021 14:14:12 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:58492 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230327AbhG3SOK (ORCPT ); Fri, 30 Jul 2021 14:14:10 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id D05D51FE18; Fri, 30 Jul 2021 18:14:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627668844; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=idx3YgWYCV0+BlxRTpZYV7ghIt+Y0zRtysPXY1vhzOM=; b=njyF0EWEYUOoZoXKnFriXFx+NKF90A4AMUszVeqFp+WPuRStXgtLUI6ztymFrcjgNvnrr8 g425JuQ6Re+W6kY0yUavSaby/ZZ8cyN15TmP/Es7t2E9FCjSF9yNvXwZAB/x6ufz+wxkC8 xAVgBx9YKxMQyQCMS+ggTgjRrFX4Vtk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627668844; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=idx3YgWYCV0+BlxRTpZYV7ghIt+Y0zRtysPXY1vhzOM=; b=EOHwbthka2/gAiluGxqixTljzkoaBnaAAqi5rpiGINWMg1qO904zx9hjnwdDNppBpz4uDP 1BxtmalPfCvnvTBQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id C374AA3B88; Fri, 30 Jul 2021 18:14:04 +0000 (UTC) Date: Fri, 30 Jul 2021 20:14:04 +0200 Message-ID: From: Takashi Iwai To: Mark Brown Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org Subject: Re: [PATCH 1/5] ASoC: amd: Fix reference to PCM buffer address In-Reply-To: <20210730162025.GB4670@sirena.org.uk> References: <20210728112353.6675-1-tiwai@suse.de> <20210728112353.6675-2-tiwai@suse.de> <20210730162025.GB4670@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, 30 Jul 2021 18:20:25 +0200, Mark Brown wrote: > > On Wed, Jul 28, 2021 at 01:23:49PM +0200, Takashi Iwai wrote: > > PCM buffers might be allocated dynamically when the buffer > > preallocation failed or a larger buffer is requested, and it's not > > guaranteed that substream->dma_buffer points to the actually used > > buffer. The driver needs to refer to substream->runtime->dma_addr > > instead for the buffer address. > > This breaks the build for me on an x86-64 allmodconfig: > > /mnt/kernel/sound/soc/amd/renoir/acp3x-pdm-dma.c: In function 'acp_pdm_dma_hw_params': > /mnt/kernel/sound/soc/amd/renoir/acp3x-pdm-dma.c:245:18: error: 'runtime' undeclared (first use in this function); did you mean 'vtime'? > rtd->dma_addr = runtime->dma_addr; > ^~~~~~~ > vtime Oops, will resubmit the fixed patch set. thanks, Takashi