From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67DEBC4338F for ; Fri, 30 Jul 2021 18:13:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4377460F5E for ; Fri, 30 Jul 2021 18:13:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230094AbhG3SNE (ORCPT ); Fri, 30 Jul 2021 14:13:04 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:58458 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230119AbhG3SNE (ORCPT ); Fri, 30 Jul 2021 14:13:04 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id F24CD1FE18; Fri, 30 Jul 2021 18:12:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627668778; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MGEsSw+8h28RTdpyuS/LsATTQxuq5VuD93DHe5vosi0=; b=hNOJRekzzq85hAL+ZYNnRmBfrROMev/voEE2+17lYixs3wWm/TU79QbVtUno/BW2RnvKIC GcHMo+wBOJolv/NIZ8C0Y7sAtrXpxG0OFIkYO3VEQtt9P+1GnbLc/6JPNUmkOeqTRjumO2 3ry74KMntDsyfk0tNzLGHfE8hKyfcSY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627668778; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MGEsSw+8h28RTdpyuS/LsATTQxuq5VuD93DHe5vosi0=; b=uOkVmqSF5D5FygTIc7r7UCqM51i7nYz7W4FPbQNrpTn/Y6s5Y3FAz+3WpdDL2xUaz2ZGAC RUxE5RVtS5mQWjBQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id E78B3A3B87; Fri, 30 Jul 2021 18:12:57 +0000 (UTC) Date: Fri, 30 Jul 2021 20:12:57 +0200 Message-ID: From: Takashi Iwai To: Alan Young Cc: Greg KH , stable@vger.kernel.org, tiwai@suse.de Subject: Re: FAILED: patch "[PATCH] ALSA: pcm: Call substream ack() method upon compat mmap" failed to apply to 5.4-stable tree In-Reply-To: References: <162728697013399@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, 30 Jul 2021 13:15:14 +0200, Alan Young wrote: > > On 30/07/2021 10:26, Greg KH wrote: > > On Fri, Jul 30, 2021 at 09:38:52AM +0100, Alan Young wrote: > >> This commit is not applicable before the 64-bit time_t in user space with > >> 32-bit compatibility changes introduces by > >> 80fe7430c7085951d1246d83f638cc17e6c0be36 in 5.6. > > That is odd, as that is not what you wrote in the patch itself: > > > >> Fixes: 9027c4639ef1 ("ALSA: pcm: Call ack() whenever appl_ptr is updated") > > So is the Fixes: tag here incorrect? > > > > thanks, > > > > greg k-h > > I did not add the Fixes tag. I guess Takashi Iwai did. > > I think that 9027c4639ef1 added some functionality that was broken by > 80fe7430c7085951 and which my patch corrects. So the Fixes: > 9027c4639ef1 tag refers to the actual functionality, not the breaking > of it. > > I have no idea if that is the correct usage of the Fixes tag which, as > I said, I did not add. Yeah, sorry for the mess, I was confused that the function already missed that point. But the patch can't be applied in anyway, so it can't go wrong at least :) Takashi