From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-media-owner@vger.kernel.org>
Received: from cantor2.suse.de ([195.135.220.15]:33095 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932314AbbGTJA7 (ORCPT <rfc822;linux-media@vger.kernel.org>);
	Mon, 20 Jul 2015 05:00:59 -0400
Date: Mon, 20 Jul 2015 11:00:51 +0200
Message-ID: <s5hio9ffbjw.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Shuah Khan <shuahkh@osg.samsung.com>, mchehab@osg.samsung.com,
	hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com,
	perex@perex.cz, crope@iki.fi, sakari.ailus@linux.intel.com,
	arnd@arndb.de, stefanr@s5r6.in-berlin.de,
	ruchandani.tina@gmail.com, chehabrafael@gmail.com,
	prabhakar.csengg@gmail.com, chris.j.arges@canonical.com,
	agoode@google.com, pierre-louis.bossart@linux.intel.com,
	gtmkramer@xs4all.nl, clemens@ladisch.de, daniel@zonque.org,
	vladcatoi@gmail.com, misterpib@gmail.com, damien@zamaudio.com,
	pmatilai@laiskiainen.org, takamichiho@gmail.com,
	normalperson@yhbt.net, bugzilla.frnkcg@spamgourmet.com,
	joe@oampo.co.uk, calcprogrammer1@gmail.com, jussi@sonarnerd.net,
	linux-media@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 7/7] sound/usb: Update ALSA driver to use Managed Media Controller API
In-Reply-To: <20150720084746.GH5422@mwanda>
References: <cover.1436917513.git.shuahkh@osg.samsung.com>
	<656c6578247d86262b7999d85db9f9995058eb36.1436917513.git.shuahkh@osg.samsung.com>
	<20150720084746.GH5422@mwanda>
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-media-owner@vger.kernel.org
List-ID: <linux-media.vger.kernel.org>

On Mon, 20 Jul 2015 10:47:46 +0200,
Dan Carpenter wrote:
> 
> On Tue, Jul 14, 2015 at 06:34:06PM -0600, Shuah Khan wrote:
> > +		ret = media_entity_setup_link(link, flags);
> > +		if (ret) {
> > +			dev_err(mctl->media_dev->dev,
> > +				"Couldn't change tuner link",
> > +				"%s->%s to %s. Error %d\n",
> 
> Add a space after "link".
> 
> 				"Couldn't change tuner link ",
> 				"%s->%s to %s. Error %d\n",

Such a message string would be better to be in a single line even if
it's over 80 chars.  Otherwise it becomes hard to grep.


thanks,

Takashi