* [PATCH] sound: core: Fix structure definition for X32 ABI
@ 2017-09-21 6:03 Baolin Wang
2017-09-22 9:25 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Baolin Wang @ 2017-09-21 6:03 UTC (permalink / raw
To: perex, tiwai
Cc: o-takashi, arnd, broonie, deepa.kernel, baolin.wang, alsa-devel,
linux-kernel
X32 ABI uses the 64bit timespec in addition to 64bit alignment of 64bit
values. We have added compat ABI for these ioctls, but this patch adds
one missing padding into 'struct snd_pcm_mmap_status_x32' to fix
incompatibilities.
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
sound/core/pcm_compat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/core/pcm_compat.c b/sound/core/pcm_compat.c
index 10f537f..29ab480 100644
--- a/sound/core/pcm_compat.c
+++ b/sound/core/pcm_compat.c
@@ -547,6 +547,7 @@ struct snd_pcm_mmap_status_x32 {
u32 pad2; /* alignment */
struct timespec tstamp;
s32 suspended_state;
+ s32 pad3;
struct timespec audio_tstamp;
} __packed;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sound: core: Fix structure definition for X32 ABI
2017-09-21 6:03 [PATCH] sound: core: Fix structure definition for X32 ABI Baolin Wang
@ 2017-09-22 9:25 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2017-09-22 9:25 UTC (permalink / raw
To: Baolin Wang
Cc: perex, alsa-devel, arnd, deepa.kernel, broonie, o-takashi,
linux-kernel
On Thu, 21 Sep 2017 08:03:29 +0200,
Baolin Wang wrote:
>
> X32 ABI uses the 64bit timespec in addition to 64bit alignment of 64bit
> values. We have added compat ABI for these ioctls, but this patch adds
> one missing padding into 'struct snd_pcm_mmap_status_x32' to fix
> incompatibilities.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sound: core: Fix structure definition for X32 ABI
@ 2017-09-22 9:25 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2017-09-22 9:25 UTC (permalink / raw
To: Baolin Wang
Cc: alsa-devel, arnd, linux-kernel, o-takashi, broonie, deepa.kernel
On Thu, 21 Sep 2017 08:03:29 +0200,
Baolin Wang wrote:
>
> X32 ABI uses the 64bit timespec in addition to 64bit alignment of 64bit
> values. We have added compat ABI for these ioctls, but this patch adds
> one missing padding into 'struct snd_pcm_mmap_status_x32' to fix
> incompatibilities.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-22 9:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-21 6:03 [PATCH] sound: core: Fix structure definition for X32 ABI Baolin Wang
2017-09-22 9:25 ` Takashi Iwai
2017-09-22 9:25 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.