From: Daniel Xu <dxu@dxuuu.xyz>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: dwarves@vger.kernel.org, Alan Maguire <alan.maguire@oracle.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Jiri Olsa <jolsa@kernel.org>,
Clark Williams <williams@redhat.com>,
Kate Carcia <kcarcia@redhat.com>,
bpf@vger.kernel.org, Eduard Zingerman <eddyz87@gmail.com>
Subject: Re: [PATCHES 0/2] Introduce --btf_features=+extra_features syntax
Date: Mon, 22 Apr 2024 20:29:35 -0600 [thread overview]
Message-ID: <uhpbft44tp3arrmvdryd23hfobndoubu3c33d6bntsuyovrtq3@r766mv2yfdqw> (raw)
In-Reply-To: <20240419205747.1102933-1-acme@kernel.org>
Hi Arnaldo,
On Fri, Apr 19, 2024 at 05:57:43PM -0300, Arnaldo Carvalho de Melo wrote:
> Hi,
>
> Please take a look if you agree this is a more compact, less
> confusing way of asking for the set of standard BTF features + some
> extra features such as 'reproducible_build'.
>
> We have this in perf, for things like:
>
> ⬢[acme@toolbox pahole]$ perf report -h -F
>
> Usage: perf report [<options>]
>
> -F, --fields <key[,keys...]>
> output field(s): overhead period sample overhead overhead_sys
> overhead_us overhead_guest_sys overhead_guest_us overhead_children
> sample period weight1 weight2 weight3 ins_lat retire_lat
> p_stage_cyc pid comm dso symbol parent cpu socket
> srcline srcfile local_weight weight transaction trace
> symbol_size dso_size cgroup cgroup_id ipc_null time
> code_page_size local_ins_lat ins_lat local_p_stage_cyc
> p_stage_cyc addr local_retire_lat retire_lat simd
> type typeoff symoff dso_from dso_to symbol_from symbol_to
> mispredict abort in_tx cycles srcline_from srcline_to
> ipc_lbr addr_from addr_to symbol_daddr dso_daddr locked
> tlb mem snoop dcacheline symbol_iaddr phys_daddr data_page_size
> blocked
>
> ⬢[acme@toolbox pahole]$
>
> From the 'perf report' man page for '-F':
>
> If the keys starts with a prefix '+', then it will append the specified
> field(s) to the default field order. For example: perf report -F +period,sample.
I think for perf it makes sense to have compact representation b/c
folks might be doing a lot of ad-hoc work. But encoding BTF seems more
like a write-once, read mostly. So having `+` notation doesn't feel like
it'd help that much.
As someone who's not seen that style of syntax before, it's not
immediately obvious what it does. But seeing `all`, I have a pretty
good idea.
[..]
Thanks,
Daniel
next prev parent reply other threads:[~2024-04-23 2:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 20:57 [PATCHES 0/2] Introduce --btf_features=+extra_features syntax Arnaldo Carvalho de Melo
2024-04-19 20:57 ` [PATCH 1/2] pahole: Factor out routine to process "--btf_features=all" Arnaldo Carvalho de Melo
2024-04-19 20:57 ` [PATCH 2/2] pahole: Allow asking for extra features using the '+' prefix in --btf_features Arnaldo Carvalho de Melo
2024-04-26 20:26 ` Andrii Nakryiko
2024-04-26 20:47 ` Arnaldo Carvalho de Melo
2024-04-29 11:16 ` Alan Maguire
2024-04-29 16:46 ` Andrii Nakryiko
2024-04-29 18:48 ` Arnaldo Carvalho de Melo
2024-04-23 2:29 ` Daniel Xu [this message]
2024-04-23 9:02 ` [PATCHES 0/2] Introduce --btf_features=+extra_features syntax Alan Maguire
2024-04-23 14:22 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uhpbft44tp3arrmvdryd23hfobndoubu3c33d6bntsuyovrtq3@r766mv2yfdqw \
--to=dxu@dxuuu.xyz \
--cc=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=dwarves@vger.kernel.org \
--cc=eddyz87@gmail.com \
--cc=jolsa@kernel.org \
--cc=kcarcia@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.