From: Jeff Moyer <jmoyer@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Benjamin LaHaise <bcrl@kvack.org>,
linux-aio@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] aio: make aio_ring->dead boolean
Date: Thu, 18 Jun 2015 14:02:47 -0400 [thread overview]
Message-ID: <x49oakclws8.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20150618175209.GA10060@redhat.com> (Oleg Nesterov's message of "Thu, 18 Jun 2015 19:52:09 +0200")
Oleg Nesterov <oleg@redhat.com> writes:
> "atomic_t dead" makes no sense. atomic_read() is the plain LOAD,
> it doesn't have some "additional" synchronization with xchg().
>
> And now that kill_ioctx() sets "dead" under mm->ioctx_lock we do
> not even need xchg().
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
> @@ -765,7 +765,7 @@ static struct kioctx *ioctx_alloc(unsigned nr_events)
> err_cleanup:
> aio_nr_sub(ctx->max_reqs);
> err_ctx:
> - atomic_set(&ctx->dead, 1);
> + ctx->dead = true; /* unneeded */
I was hoping you'd remove this line entirely.
-Jeff
next prev parent reply other threads:[~2015-06-18 18:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 17:51 [PATCH v3 0/3] aio: ctx->dead cleanups Oleg Nesterov
2015-06-18 17:52 ` [PATCH v3 1/3] aio_ring_remap: kill the bogus ctx->dead check Oleg Nesterov
2015-06-18 17:52 ` [PATCH v3 2/3] aio: make aio_ring->dead boolean Oleg Nesterov
2015-06-18 18:02 ` Jeff Moyer [this message]
2015-06-18 18:27 ` Oleg Nesterov
2015-06-18 17:52 ` [PATCH v3 3/3] aio_free_ring: don't do page_count(NULL) Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49oakclws8.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.