From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Andrei Rybak <rybak.a.v@gmail.com>, git@vger.kernel.org
Subject: Re: [BUG] range expressions in GIT_SKIP_TESTS are broken in master (was [BUG] question mark in GIT_SKIP_TESTS is broken in master)
Date: Wed, 16 Jun 2021 13:12:09 +0900 [thread overview]
Message-ID: <xmqq4kdysb1i.fsf@gitster.g> (raw)
In-Reply-To: <xmqqa6nqsd2i.fsf@gitster.g> (Junio C. Hamano's message of "Wed, 16 Jun 2021 12:28:21 +0900")
Junio C Hamano <gitster@pobox.com> writes:
> Interestingly enough, edc23840b0 (test-lib: bring $remove_trash out
> of retirement, 2021-05-10) cleanly reverts without being depended on
> by anything else in the series.
>
> Ævar?
With the crude debugging aid patch (attached at the end) applied,
running
$ GIT_SKIP_TESTS='t?000' sh -x t0000-basic.sh -v
will show something interesting in the trace.
++ this_test=t0000
++ _s_k_i_p_='t?000'
++ match_pattern_list t0000 t5000
The variable $GIT_SKIP_TESTS on this line:
if match_pattern_list "$this_test" $GIT_SKIP_TESTS
globs to t5000. We don't quote the variable because we want them
separated at $IFS boundaries, but we didn't want the glob specials
in its value to take any effect. Sigh.
The reason why edc23840b0 appears to break this is probably because
we are still in $TEST_DIRECTORY when this match_pattern_list is
executed; before that change, we've created $TRASH_DIRECTORY and
chdir'd there already, and when we check "do we want to skip all?",
there is nothing for the glob to match.
That also explains why GIT_SKIP_TESTS="t000?" appears to work.
There is no such filesystem entity directly in $TEST_DIRECTORY.
$ echo t000? t00?0 t0?00 t?000
t000? t00?0 t0200 t5000
diff --git i/t/test-lib.sh w/t/test-lib.sh
index 54938c6427..8ee0540532 100644
--- i/t/test-lib.sh
+++ w/t/test-lib.sh
@@ -1346,13 +1346,17 @@ fi
remove_trash=
this_test=${0##*/}
this_test=${this_test%%-*}
+_s_k_i_p_=$GIT_SKIP_TESTS
+
if match_pattern_list "$this_test" $GIT_SKIP_TESTS
then
say_color info >&3 "skipping test $this_test altogether"
skip_all="skip all tests in $this_test"
test_done
fi
+exit
+
# Last-minute variable setup
HOME="$TRASH_DIRECTORY"
GNUPGHOME="$HOME/gnupg-home-not-used"
next prev parent reply other threads:[~2021-06-16 4:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 20:55 [BUG] question mark in GIT_SKIP_TESTS is broken in master Andrei Rybak
2021-06-15 23:28 ` [BUG] range expressions in GIT_SKIP_TESTS are broken in master (was [BUG] question mark in GIT_SKIP_TESTS is broken in master) Andrei Rybak
2021-06-16 3:28 ` Junio C Hamano
2021-06-16 4:12 ` Junio C Hamano [this message]
2021-06-16 8:29 ` Jeff King
2021-06-16 9:19 ` Junio C Hamano
2021-06-16 8:24 ` [PATCH] test-lib: fix "$remove_trash" regression and match_pattern_list() bugs Ævar Arnfjörð Bjarmason
2021-06-16 8:36 ` Jeff King
2021-06-16 9:22 ` Junio C Hamano
2021-06-16 10:23 ` Jeff King
2021-06-16 10:24 ` Jeff King
2021-06-16 11:38 ` Ævar Arnfjörð Bjarmason
2021-06-16 11:50 ` Jeff King
2021-06-17 0:29 ` Junio C Hamano
2021-06-16 9:49 ` Ævar Arnfjörð Bjarmason
2021-06-16 11:43 ` Jeff King
2021-06-17 0:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4kdysb1i.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.