From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Andrei Rybak" <rybak.a.v@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [BUG] range expressions in GIT_SKIP_TESTS are broken in master (was [BUG] question mark in GIT_SKIP_TESTS is broken in master)
Date: Wed, 16 Jun 2021 12:28:21 +0900 [thread overview]
Message-ID: <xmqqa6nqsd2i.fsf@gitster.g> (raw)
In-Reply-To: <6980e906-8076-1436-ecdb-6775eff55d39@gmail.com> (Andrei Rybak's message of "Wed, 16 Jun 2021 01:28:33 +0200")
Andrei Rybak <rybak.a.v@gmail.com> writes:
> I sent this originally with incorrect subject. Question marks, e.g.
>
> $ GIT_SKIP_TESTS='t000?' make
>
> work. It is the range expressions, like [0-9] that are broken:
>
> $ GIT_SKIP_TESTS='t[0-9]000' make
This reproduces for me, and
$ GIT_SKIP_TESTS=t?000' sh t0000-basic.sh
$ GIT_SKIP_TESTS=t0?00' sh t0000-basic.sh
$ GIT_SKIP_TESTS=t00?0' sh t0000-basic.sh
tells me that "Question marks work" above is not exactly correct.
It is an exception that this
$ GIT_SKIP_TESTS=t000?' sh t0000-basic.sh
happens to skip.
Interestingly enough, edc23840b0 (test-lib: bring $remove_trash out
of retirement, 2021-05-10) cleanly reverts without being depended on
by anything else in the series.
Ævar?
Thanks.
next prev parent reply other threads:[~2021-06-16 3:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 20:55 [BUG] question mark in GIT_SKIP_TESTS is broken in master Andrei Rybak
2021-06-15 23:28 ` [BUG] range expressions in GIT_SKIP_TESTS are broken in master (was [BUG] question mark in GIT_SKIP_TESTS is broken in master) Andrei Rybak
2021-06-16 3:28 ` Junio C Hamano [this message]
2021-06-16 4:12 ` Junio C Hamano
2021-06-16 8:29 ` Jeff King
2021-06-16 9:19 ` Junio C Hamano
2021-06-16 8:24 ` [PATCH] test-lib: fix "$remove_trash" regression and match_pattern_list() bugs Ævar Arnfjörð Bjarmason
2021-06-16 8:36 ` Jeff King
2021-06-16 9:22 ` Junio C Hamano
2021-06-16 10:23 ` Jeff King
2021-06-16 10:24 ` Jeff King
2021-06-16 11:38 ` Ævar Arnfjörð Bjarmason
2021-06-16 11:50 ` Jeff King
2021-06-17 0:29 ` Junio C Hamano
2021-06-16 9:49 ` Ævar Arnfjörð Bjarmason
2021-06-16 11:43 ` Jeff King
2021-06-17 0:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa6nqsd2i.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.