From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Dan Demp <drdemp@gmail.com>, git@vger.kernel.org
Subject: Re: Git Bug Report: git add --patch > "e" makes keyboard unresponsive
Date: Wed, 24 Apr 2024 15:23:27 -0700 [thread overview]
Message-ID: <xmqqedauwgbk.fsf@gitster.g> (raw)
In-Reply-To: <Zil_m_1B0wcLejNH@tapette.crustytoothpaste.net> (brian m. carlson's message of "Wed, 24 Apr 2024 21:54:35 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> Using the "e" option should invoke your editor and wait until it exits.
> The only way Git has to know that you're done editing is that the editor
> process it invokes has exited.
Whichever editor was launched, unless the user explicitly said the hint
is not necessary by setting advice.waitingForEditor to false, the code
should have given something like this:
hint: Waiting for your editor to close the file...
so ...
> What does "git var GIT_EDITOR" at a Git Bash prompt print? If you have
> your editor configured to open in an existing editor window, does
> closing the new editor tab or window that Git causes to be opened fix
> the problem?
... I would expect that there may be something more than a silly
"the editor is running elsewhere and the user is stuck, expecting
something to happen but the editor is waiting for the user" problem
here. For example, could there be funny interaction with "single
key" mode with editor on Windows (which I do not use myself but I
think I saw the word in the original report)? Is the configuration
"interactive.singlekey" enabled?
next prev parent reply other threads:[~2024-04-24 22:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 16:22 Git Bug Report: git add --patch > "e" makes keyboard unresponsive Dan Demp
2024-04-24 21:54 ` brian m. carlson
2024-04-24 22:23 ` Junio C Hamano [this message]
2024-04-25 4:13 ` Dan Demp
2024-04-25 4:24 ` Junio C Hamano
2024-04-25 4:15 ` Dan Demp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqedauwgbk.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=drdemp@gmail.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.