From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C20DBC433EF for ; Fri, 10 Sep 2021 16:56:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EB646108B for ; Fri, 10 Sep 2021 16:56:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229734AbhIJQ5g (ORCPT ); Fri, 10 Sep 2021 12:57:36 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:64999 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229466AbhIJQ5f (ORCPT ); Fri, 10 Sep 2021 12:57:35 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 09E801481FC; Fri, 10 Sep 2021 12:56:24 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=GxcLvwMqD+lw qD1oisQhEUqALOrPCWetw9bdpRdDpd4=; b=HIpsx7bbkvMLkHeJwMRP2GrSCJVS xoETqGToMC/oQ1XXPc8FsJrFVZZ308Gg4PQJnuwjYqpxFzDPR1SowoPxh0xgiWG/ Jc7b1M4AOSTsJGgbZdtsrz36gQWXC5oDmlIbzuTht2sqm9aaPLnhHWaNXVokFlNE GI8rYKuW6pMRzRE= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 026591481FB; Fri, 10 Sep 2021 12:56:24 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.196.172.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 4DD7A1481F8; Fri, 10 Sep 2021 12:56:21 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jeff King Cc: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , git@vger.kernel.org, "brian m . carlson" , Bagas Sanjaya Subject: Re: [PATCH v2 2/8] INSTALL: mention that we need libcurl 7.19.4 or newer to build References: Date: Fri, 10 Sep 2021 09:56:19 -0700 In-Reply-To: (Jeff King's message of "Fri, 10 Sep 2021 10:54:27 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 064690CA-1258-11EC-8C0D-F327CE9DA9D6-77302942!pb-smtp20.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff King writes: > On Fri, Sep 10, 2021 at 01:04:27PM +0200, =C3=86var Arnfj=C3=B6r=C3=B0 = Bjarmason wrote: > >> Without NO_CURL=3DY we require at least version "7.19.4" of libcurl, s= ee >> 644de29e220 (http: drop support for curl < 7.19.4, 2021-07-30). Let's >> document this in the "INSTALL" document. > > Makes sense. > >> diff --git a/INSTALL b/INSTALL >> index 5c6ecf03c27..81f3a6cf018 100644 >> --- a/INSTALL >> +++ b/INSTALL >> @@ -141,6 +141,9 @@ Issues of note: >> - "libcurl" library is used by git-http-fetch, git-fetch, and, if >> the curl version >=3D 7.34.0, for git-imap-send. >> =20 >> + Git version "7.19.4" of "libcurl" or later to build. This >> + version requirement may be bumped in the future. >> + > > s/to build/is needed &/ or similar? "Get version X of "libcurl" or later to build." probably.