From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Alexander Kuleshov <kuleshovmail@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] format-patch: introduce format.outputDirectory configuration
Date: Thu, 18 Jun 2015 13:05:55 -0700 [thread overview]
Message-ID: <xmqqoakceq8s.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150618195751.GA14550@peff.net> (Jeff King's message of "Thu, 18 Jun 2015 15:57:51 -0400")
Jeff King <peff@peff.net> writes:
>> This change looks ugly and unnecessary. All the machinery after and
>> including the point set_outdir() is called, including reopen_stdout(),
>> work on output_directory variable and only that variable.
>>
>> Wouldn't it work equally well to have
>>
>> if (!output_directory)
>> output_directory = config_output_directory;
>>
>> before a call to set_outdir() is made but after the configuration is
>> read (namely, soon after parse_options() returns), without making
>> any change to this function?
>
> Don't we load the config before parsing options here? In that case, we
> can use our usual strategy to just set output_directory (which is
> already a static global) from the config callback, and everything Just
> Works.
>
> We do have to bump the definition of output_directory up above the
> config callback, like so (while we are here, we might also want to
> drop the unnecessary static initializers, which violate our style guide):
You would also need to remove the "oh you gave me -o twice?" check,
and change the semantics to "later -o overrides an earlier one",
wouldn't you? Otherwise you would never be able to override what
you read from the config, I am afraid.
next prev parent reply other threads:[~2015-06-18 20:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 11:18 [PATCH] format-patch: introduce format.outputDirectory configuration Alexander Kuleshov
2015-06-18 17:13 ` Junio C Hamano
2015-06-18 19:57 ` Jeff King
2015-06-18 20:05 ` Junio C Hamano [this message]
2015-06-18 20:06 ` Junio C Hamano
2015-06-18 20:13 ` Jeff King
2015-06-18 20:22 ` Jeff King
2015-06-18 21:46 ` Junio C Hamano
2015-06-19 4:14 ` Jeff King
2015-06-19 7:06 ` Alexander Kuleshov
2015-06-19 13:33 ` Alexander Kuleshov
2015-06-19 15:59 ` Junio C Hamano
2015-06-19 17:19 ` Alexander Kuleshov
2015-06-19 17:27 ` Alexander Kuleshov
2015-06-19 17:49 ` Alexander Kuleshov
2015-06-19 18:14 ` Junio C Hamano
2015-06-19 11:34 ` Remi Galan Alfonso
2015-06-19 11:34 ` Alexander Kuleshov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoakceq8s.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kuleshovmail@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.