From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Gregory Anders <greg@gpanders.com>, git@vger.kernel.org
Subject: Re: Syntax for specifying a command in git config
Date: Wed, 12 May 2021 12:25:16 +0900 [thread overview]
Message-ID: <xmqqtun8hbvn.fsf@gitster.g> (raw)
In-Reply-To: <YJsiKDNbKclFU00b@coredump.intra.peff.net> (Jeff King's message of "Tue, 11 May 2021 20:32:40 -0400")
Jeff King <peff@peff.net> writes:
>> git send-email --smtp-server="/usr/bin/env msmtp"
>> git send-email --smtp-server="!my-msa --emulate-sendmail"
>
> Yes, the patch under discussion does apply to both the command-line
> option and the config option (and I agree it should).
>
> I didn't think about arguments, but you're right that may be a useful
> feature. And if done via the shell, as brian suggested elsewhere, would
> be more consistent with other parts of Git using "!" syntax.
Heh, it was my tongue-in-cheek way to say we do not need this '!'
new feature, as long as everybody has 'env' in /usr/bin ;-)
> It does make things a little weird in that:
>
> git send-email --smtp-server='/path/to/my-sendmail foo'
>
> and
>
> git send-email --smtp-server '!my-sendmail foo'
>
> behave differently (the first does not work; it looks for an executable
> with a space in the name).
True. Hopefully we do not have to worry about $IFS whitespaces in
an absolute path to the mail submission program? ... Nah, that's a
wishful thinking.
But then nobody stops you from saying
git send-email --smtp-server '!/path/to/my-sendmail foo'
so it probably is OK. We can gradually deprecate the "absolute path"
form and standardise on the "!prefix" form.
prev parent reply other threads:[~2021-05-12 3:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 18:07 Syntax for specifying a command in git config Gregory Anders
2021-05-11 18:17 ` Jeff King
2021-05-11 22:56 ` Junio C Hamano
2021-05-12 0:32 ` Jeff King
2021-05-12 3:25 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtun8hbvn.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=greg@gpanders.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.