From: Junio C Hamano <gitster@pobox.com>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: Luke Diamand <luke@diamand.org>, git@vger.kernel.org
Subject: Re: [PATCH v5 6/7] git-p4: add support for large file systems
Date: Wed, 16 Sep 2015 08:20:20 -0700 [thread overview]
Message-ID: <xmqqzj0ms85n.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <5329966D-1A0C-42A1-9099-AC449D50AA52@gmail.com> (Lars Schneider's message of "Wed, 16 Sep 2015 14:05:40 +0200")
Lars Schneider <larsxschneider@gmail.com> writes:
>>> +git-p4.largeFileSystem::
>>> + Specify the system that is used for large (binary) files. Please note
>>> + that large file systems do not support the 'git p4 submit' command.
>>
>> Why is that? Is it just that you haven't implemented support, or
>> is it fundamentally impossible?
>
> If we detect LFS files only by file extension then we could make
> it work. But then we must not use any git-p4 settings. We would
> need to rely only on the “.gitattributes” file that is stored in
> the P4 repository. My implementation also looks at the file size
> and decides on a individual file basis if a file is stored in
> LFS. That means all clients need the same file size threshold.
>
> Junio explained the problem in the v4 thread:
>> ...
Hmm, I am not sure if Luke's question was answered with the above,
and I do not think I explained anything, either. I did point out
that with _your_ code I didn't see how "submit" would not work, but
that is quite different from the problem being fundamentally not
solvable.
>>> +test_file_in_mock () {
>>> + FILE="$1"
>> Missing &&
>> Plus the next few lines
> Are they strictly necessary? I believe you can define variables all in “one line”
Absolutely. Making multiple assignments as a single statment like
X=A Y=B Z=C &&
...
is fine, but do not break &&-chain.
>>
>>> + CONTENT="$2"
>>> + LOCAL_STORAGE=".git/mock-storage/local/$CONTENT"
>>> + SERVER_STORAGE=".git/mock-storage/remote/$CONTENT"
... and to be sure, these 'echo' also must not break &&-chain.
>>> + echo "pointer-$CONTENT" >expect_pointer
>>> + echo "$CONTENT" >expect_content
>>> +test_file_count_in_dir () {
>>> + DIR="$1"
>>> + EXPECTED_COUNT="$2"
>>> + find "$DIR" -type f >actual
... so are these.
>>> + test_line_count = $EXPECTED_COUNT actual
>>> +}
Thanks.
next prev parent reply other threads:[~2015-09-16 15:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 13:26 [PATCH v5 0/7] git-p4: add support for large file systems larsxschneider
2015-09-14 13:26 ` [PATCH v5 1/7] git-p4: add optional type specifier to gitConfig reader larsxschneider
2015-09-15 7:34 ` Luke Diamand
2015-09-14 13:26 ` [PATCH v5 2/7] git-p4: add gitConfigInt reader larsxschneider
2015-09-14 13:26 ` [PATCH v5 3/7] git-p4: return an empty list if a list config has no values larsxschneider
2015-09-14 13:26 ` [PATCH v5 4/7] git-p4: add file streaming progress in verbose mode larsxschneider
2015-09-14 13:26 ` [PATCH v5 5/7] git-p4: check free space during streaming larsxschneider
2015-09-14 13:26 ` [PATCH v5 6/7] git-p4: add support for large file systems larsxschneider
2015-09-16 8:36 ` Luke Diamand
2015-09-16 12:05 ` Lars Schneider
2015-09-16 14:59 ` Eric Sunshine
2015-09-16 15:20 ` Junio C Hamano [this message]
2015-09-20 21:26 ` Lars Schneider
2015-09-14 13:26 ` [PATCH v5 7/7] git-p4: add Git LFS backend for large file system larsxschneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzj0ms85n.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=luke@diamand.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.