From: Cezary Rojewski <cezary.rojewski@intel.com>
To: broonie@kernel.org
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
tiwai@suse.com, perex@perex.cz,
amadeuszx.slawinski@linux.intel.com, hdegoede@redhat.com,
Cezary Rojewski <cezary.rojewski@intel.com>
Subject: [PATCH 0/2] ASoC: Intel: avs: Refactor IRQ handling
Date: Fri, 19 Apr 2024 10:48:55 +0200 [thread overview]
Message-ID: <20240419084857.2719593-1-cezary.rojewski@intel.com> (raw)
The existing code can be both improved and simplified. To make this
change easier to manage, first add new implementation and then remove
deadcode in a separate patch.
Simplification achieved with:
- reduce the amount of resources requested by the driver i.e.: IPC and
CLDMA request_irq() merged into one
- reduce the number of DSP ops from 2 to 1:
irq_handler/thread() vs dsp_interrupt()
- drop ambiguity around CLDMA interrupt, let skl.c handle that
explicitly as it is the only user
With that done, switch to the new implementation and remove unused
members. While the change is non-trivial, from functional perspective
status quo is achieved.
Cezary Rojewski (2):
ASoC: Intel: avs: New IRQ handling implementation
ASoC: Intel: avs: Remove unused IRQ-related code
sound/soc/intel/avs/apl.c | 20 +++++++-
sound/soc/intel/avs/avs.h | 8 ++--
sound/soc/intel/avs/cldma.c | 42 ++++-------------
sound/soc/intel/avs/cldma.h | 1 +
sound/soc/intel/avs/cnl.c | 91 ++++++++++++++++++++++++-------------
sound/soc/intel/avs/core.c | 85 ++++++++++++++++------------------
sound/soc/intel/avs/icl.c | 3 +-
sound/soc/intel/avs/ipc.c | 48 -------------------
sound/soc/intel/avs/skl.c | 73 +++++++++++++++++++++--------
sound/soc/intel/avs/tgl.c | 3 +-
10 files changed, 186 insertions(+), 188 deletions(-)
--
2.25.1
next reply other threads:[~2024-04-19 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 8:48 Cezary Rojewski [this message]
2024-04-19 8:48 ` [PATCH 1/2] ASoC: Intel: avs: New IRQ handling implementation Cezary Rojewski
2024-04-19 8:48 ` [PATCH 2/2] ASoC: Intel: avs: Remove unused IRQ-related code Cezary Rojewski
2024-04-21 1:03 ` [PATCH 0/2] ASoC: Intel: avs: Refactor IRQ handling Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419084857.2719593-1-cezary.rojewski@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).