From: Takashi Iwai <tiwai@suse.de>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: <broonie@kernel.org>, <andriy.shevchenko@linux.intel.com>,
<lgirdwood@gmail.com>, <perex@perex.cz>,
<pierre-louis.bossart@linux.intel.com>, <13916275206@139.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<liam.r.girdwood@intel.com>, <bard.liao@intel.com>,
<yung-chuan.liao@linux.intel.com>, <kevin-lu@ti.com>,
<cameron.berkenpas@gmail.com>, <baojun.xu@ti.com>, <soyer@irl.hu>,
<Baojun.Xu@fpt.com>
Subject: Re: [PATCH v1] ALSA: ASoc/tas2781: Fix an issue reported by robot kernel test
Date: Sat, 04 May 2024 10:08:38 +0200 [thread overview]
Message-ID: <871q6i9eyh.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240504004704.1738-1-shenghao-ding@ti.com>
On Sat, 04 May 2024 02:47:03 +0200,
Shenghao Ding wrote:
>
> Fix an issue reported by robot kernel test and two harmless changes.
You need to describe more what was actually an issue reported by robot
kernel test here. Otherwise it's nothing but a voodoo magic.
Also enumerate two harmless changes, too: it's an update of copyright
year and a correction of the comments.
Last but not least, the subject suffix should be "ASoC: tas2781: ..."
(not "ASoc", and without "ALSA:")
thanks,
Takashi
>
> Fixes: ef3bcde75d06 ("ASoc: tas2781: Add tas2781 driver")
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
>
> ---
> v1:
> - Changed the copyright year to 2024
> - tasdevice-fmw.c --> tas2781-fmwlib.c
> - | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202405021200.YHInjV43-lkp@intel.com/
> ---
> sound/soc/codecs/tas2781-fmwlib.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c
> index 45760fe19523..a6be81adcb83 100644
> --- a/sound/soc/codecs/tas2781-fmwlib.c
> +++ b/sound/soc/codecs/tas2781-fmwlib.c
> @@ -1,8 +1,8 @@
> // SPDX-License-Identifier: GPL-2.0
> //
> -// tasdevice-fmw.c -- TASDEVICE firmware support
> +// tas2781-fmwlib.c -- TASDEVICE firmware support
> //
> -// Copyright 2023 Texas Instruments, Inc.
> +// Copyright 2023 - 2024 Texas Instruments, Inc.
> //
> // Author: Shenghao Ding <shenghao-ding@ti.com>
>
> @@ -1878,7 +1878,7 @@ int tas2781_load_calibration(void *context, char *file_name,
> {
> struct tasdevice_priv *tas_priv = (struct tasdevice_priv *)context;
> struct tasdevice *tasdev = &(tas_priv->tasdevice[i]);
> - const struct firmware *fw_entry;
> + const struct firmware *fw_entry = NULL;
> struct tasdevice_fw *tas_fmw;
> struct firmware fmw;
> int offset = 0;
> --
> 2.34.1
>
prev parent reply other threads:[~2024-05-04 8:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 0:47 [PATCH v1] ALSA: ASoc/tas2781: Fix an issue reported by robot kernel test Shenghao Ding
2024-05-04 8:08 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q6i9eyh.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=13916275206@139.com \
--cc=Baojun.Xu@fpt.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=cameron.berkenpas@gmail.com \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).