From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Xu, Baojun" <baojun.xu@ti.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"Lu, Kevin" <kevin-lu@ti.com>,
"Ding, Shenghao" <shenghao-ding@ti.com>,
"Navada Kanyana, Mukund" <navada@ti.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"liam.r.girdwood@intel.com" <liam.r.girdwood@intel.com>,
"yung-chuan.liao@linux.intel.com"
<yung-chuan.liao@linux.intel.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"soyer@irl.hu" <soyer@irl.hu>
Subject: Re: [EXTERNAL] Re: [PATCH v2 2/3] ALSA: hda/tas2781: Main code of tas2781 driver for SPI
Date: Thu, 18 Apr 2024 14:53:38 +0300 [thread overview]
Message-ID: <ZiEJwr5iv77wLkwd@smile.fi.intel.com> (raw)
In-Reply-To: <e3f73d92d1fa466cb70e3d738a7926c9@ti.com>
On Thu, Apr 18, 2024 at 05:12:03AM +0000, Xu, Baojun wrote:
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Sent: 09 April 2024 21:21
> > To: Xu, Baojun
> > On Tue, Apr 09, 2024 at 10: 48: 14AM +0800, Baojun Xu wrote:
> > On Tue, Apr 09, 2024 at 10:48:14AM +0800, Baojun Xu wrote:
...
> > > +#ifndef __TAS2781_SPI_H__
> > > +#define __TAS2781_SPI_H__
> >
> > + bits.h
> > + mutex.h
> > + time.h? (for struct tm)
> > + types.h
> >
> > struct calidata is from?..
> >
> > > +#include <sound/tas2781-dsp.h>
> >
> > Not sure how this is being used.
>
> Was used for firmware binary file parser, all of file format information
> was defined in this header file. It can be shared between SPI & I2C.
_This header_ file seems not using anything from it, does it?
> > Also some forward declarations:
> >
> > + struct device;
> > + struct firmware;
> > + struct gpio_desc;
> > + struct regmap;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-18 11:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 2:48 [PATCH v2 0/3] ALSA: hda/tas2781: Add tas2781 driver for SPI Baojun Xu
2024-04-09 2:48 ` [PATCH v2 1/3] ALSA: hda/tas2781: Modification for add " Baojun Xu
2024-04-09 13:02 ` Andy Shevchenko
2024-04-16 7:45 ` [EXTERNAL] " Xu, Baojun
2024-04-16 14:02 ` Andy Shevchenko
2024-04-09 2:48 ` [PATCH v2 2/3] ALSA: hda/tas2781: Main code of " Baojun Xu
2024-04-09 13:21 ` Andy Shevchenko
2024-04-18 5:12 ` [EXTERNAL] " Xu, Baojun
2024-04-18 11:53 ` Andy Shevchenko [this message]
2024-04-09 17:00 ` kernel test robot
2024-04-09 2:48 ` [PATCH v2 3/3] ALSA: hda/tas2781: Firmware load for " Baojun Xu
2024-04-09 13:26 ` Andy Shevchenko
2024-04-09 18:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiEJwr5iv77wLkwd@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navada@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).