From: Bjorn Andersson <quic_bjorande@quicinc.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: <alsa-devel@alsa-project.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
<linux-arm-msm@vger.kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH 0/3] slimbus: use 'time_left' instead of 'timeout' with wait_for_*() functions
Date: Tue, 30 Apr 2024 06:30:00 -0700 [thread overview]
Message-ID: <ZjDyWFlx2cjfi1MJ@hu-bjorande-lv.qualcomm.com> (raw)
In-Reply-To: <20240430120102.29459-1-wsa+renesas@sang-engineering.com>
On Tue, Apr 30, 2024 at 02:00:58PM +0200, Wolfram Sang wrote:
> There is a confusing pattern in the kernel to use a variable named 'timeout' to
> store the result of wait_for_*() functions causing patterns like:
>
> timeout = wait_for_completion_timeout(...)
> if (!timeout) return -ETIMEDOUT;
>
> with all kinds of permutations. Use 'time_left' as a variable to make the code
> obvious and self explaining.
>
> This is part of a tree-wide series. The rest of the patches can be found here
> (some parts may still be WIP):
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/time_left
>
> Because these patches are generated, I audit them before sending. This is why I
> will send series step by step. Build bot is happy with these patches, though.
> No functional changes intended.
>
Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Regards,
Bjorn
> Wolfram Sang (3):
> slimbus: messaging: use 'time_left' variable with
> wait_for_completion_timeout()
> slimbus: qcom-ctrl: use 'time_left' variable with
> wait_for_completion_timeout()
> slimbus: qcom-ngd-ctrl: use 'time_left' variable with
> wait_for_completion_timeout()
>
> drivers/slimbus/messaging.c | 9 +++++----
> drivers/slimbus/qcom-ctrl.c | 7 ++++---
> drivers/slimbus/qcom-ngd-ctrl.c | 29 ++++++++++++++++-------------
> 3 files changed, 25 insertions(+), 20 deletions(-)
>
> --
> 2.43.0
>
prev parent reply other threads:[~2024-04-30 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 12:00 [PATCH 0/3] slimbus: use 'time_left' instead of 'timeout' with wait_for_*() functions Wolfram Sang
2024-04-30 12:00 ` [PATCH 1/3] slimbus: messaging: use 'time_left' variable with wait_for_completion_timeout() Wolfram Sang
2024-04-30 12:01 ` [PATCH 2/3] slimbus: qcom-ctrl: " Wolfram Sang
2024-04-30 12:01 ` [PATCH 3/3] slimbus: qcom-ngd-ctrl: " Wolfram Sang
2024-04-30 13:30 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjDyWFlx2cjfi1MJ@hu-bjorande-lv.qualcomm.com \
--to=quic_bjorande@quicinc.com \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).