From: Aurabindo Pillai <aurabindo.pillai@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: <harry.wentland@amd.com>, <sunpeng.li@amd.com>,
<rodrigo.siqueira@amd.com>, <aurabindo.pillai@amd.com>,
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Subject: [PATCH 08/13] drm/amd/display: Remove incorrect FP context start
Date: Thu, 23 May 2024 19:20:22 +0000 [thread overview]
Message-ID: <20240523192027.50630-8-aurabindo.pillai@amd.com> (raw)
In-Reply-To: <20240523192027.50630-1-aurabindo.pillai@amd.com>
All the DC_FP_START/END should be used before call anything from DML2,
for this reason, the use of those guards inside DML it is not correct.
This commit removes two unnecessary DC_FP_START/END from a dml2
function.
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c
index 22f6a59d8ed2..5fe1110c4816 100644
--- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c
+++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c
@@ -759,7 +759,6 @@ static void dml2_init(const struct dc *in_dc, const struct dml2_configuration_op
bool dml2_create(const struct dc *in_dc, const struct dml2_configuration_options *config, struct dml2_context **dml2)
{
- DC_FP_START();
// TODO : Temporarily add DCN_VERSION_3_2 for N-1 validation. Remove DCN_VERSION_3_2 after N-1 validation phase is complete.
if ((in_dc->debug.using_dml21) && (in_dc->ctx->dce_version == DCN_VERSION_4_01 || in_dc->ctx->dce_version == DCN_VERSION_3_2)) {
return dml21_create(in_dc, dml2, config);
@@ -773,7 +772,6 @@ bool dml2_create(const struct dc *in_dc, const struct dml2_configuration_options
dml2_init(in_dc, config, dml2);
- DC_FP_END();
return true;
}
--
2.39.2
next prev parent reply other threads:[~2024-05-23 19:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 19:20 [PATCH 01/13] drm/amd/display: Fix incorrect cursor position for dcn401 Aurabindo Pillai
2024-05-23 19:20 ` [PATCH 02/13] drm/amd/display: Enable ISHARP support for DCN401 Aurabindo Pillai
2024-05-23 19:20 ` [PATCH 03/13] drm/amd/display: Remove unused code Aurabindo Pillai
2024-05-23 19:20 ` [PATCH 04/13] drm/amd/display: Refactor HUBP into component folder Aurabindo Pillai
2024-05-23 19:20 ` [PATCH 05/13] drm/amd/display: Update DML2.1 generated code Aurabindo Pillai
2024-05-23 19:20 ` [PATCH 06/13] drm/amd/display: Remove unnecessary HPD entry for DCN401 Aurabindo Pillai
2024-05-23 19:20 ` [PATCH 07/13] drm/amd/display: Use DCN 410 includes " Aurabindo Pillai
2024-05-23 19:20 ` Aurabindo Pillai [this message]
2024-05-23 19:20 ` [PATCH 09/13] drm/amd/display: Fix null pointer dereference for dcn401 Aurabindo Pillai
2024-05-23 19:20 ` [PATCH 10/13] drm/amd/display: Add missing registers for DCN401 Aurabindo Pillai
2024-05-23 19:20 ` [PATCH 11/13] drm/amd/display: Move some init routines to dm_sw_init() Aurabindo Pillai
2024-05-23 19:20 ` [PATCH 12/13] drm/amd/display: Add new GPINT command definitions Aurabindo Pillai
2024-05-23 19:20 ` [PATCH 13/13] drm/amd/display: Enable copying of bounding box data from VBIOS DMUB Aurabindo Pillai
2024-05-27 14:50 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240523192027.50630-8-aurabindo.pillai@amd.com \
--to=aurabindo.pillai@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=rodrigo.siqueira@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).