From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: Tamizh Chelvam Raja <quic_tamizhr@quicinc.com>,
<ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
"Venkateswara Naralasetty" <quic_vnaralas@quicinc.com>
Subject: Re: [PATCHv5] wifi: ath11k: skip status ring entry processing
Date: Fri, 3 May 2024 07:55:34 -0700 [thread overview]
Message-ID: <143e04a0-3bda-4718-8647-1ed31e1f5774@quicinc.com> (raw)
In-Reply-To: <871q6jnipu.fsf@kernel.org>
On 5/3/2024 6:11 AM, Kalle Valo wrote:
> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>
>>> Also I removed one unrelated change and removed unnecessary else. Please
>>> check my changes:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=6e88d559268779107715008c51e006f7a5f62045
>>
>> So looking at the 'pending' change I have the observation that
>> ath11k_dp_rx_mon_buf_done() only returns one of two values:
>> DP_MON_STATUS_NO_DMA
>> DP_MON_STATUS_REPLINISH
>>
>> And the return value handling has explicit handling for those values, without
>> any logic for other values:
>> + if (reap_status == DP_MON_STATUS_NO_DMA)
>> + continue;
>> +
>> + if (reap_status == DP_MON_STATUS_REPLINISH) {
>>
>> if we only expect these two values to ever be returned, then we could remove
>> the testing for DP_MON_STATUS_REPLINISH since, it it isn't NO_DMA then it must
>> be REPLINISH
>
> Nice, I simplified this error handling now. Less indentation now which
> is much better.
>
>> + ath11k_warn(ab, "mon status DONE not set %lx, buf_id %d\n",
>> + FIELD_GET(HAL_TLV_HDR_TAG, tlv->tl),
>> + buf_id);
>>
>> I don't think we should log anything here. we already warn before calling the
>> new function. if we get here it means the next buffer had DONE set so we can
>> replenish the current buffer
>
> Yeah, I removed the warning altogether. Please check my changes:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=49c28a9720959fb5daf702fe1732a716f3cff15c
>
LGTM, thanks!
next prev parent reply other threads:[~2024-05-03 14:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 7:36 [PATCHv5] wifi: ath11k: skip status ring entry processing Tamizh Chelvam Raja
2024-04-29 18:12 ` Jeff Johnson
2024-04-30 13:48 ` Kalle Valo
2024-04-30 14:44 ` Tamizh Chelvam Raja
2024-04-30 15:14 ` Jeff Johnson
2024-05-03 13:11 ` Kalle Valo
2024-05-03 14:55 ` Jeff Johnson [this message]
2024-05-07 10:00 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=143e04a0-3bda-4718-8647-1ed31e1f5774@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_tamizhr@quicinc.com \
--cc=quic_vnaralas@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).