* [PATCH 0/2] wifi: ath: Remove unused struct ieee80211_ops *ops
@ 2023-11-06 18:21 Jeff Johnson
2023-11-06 18:21 ` [PATCH 1/2] wifi: ath11k: Remove struct ath11k::ops Jeff Johnson
2023-11-06 18:21 ` [PATCH 2/2] wifi: ath12k: Remove struct ath12k::ops Jeff Johnson
0 siblings, 2 replies; 4+ messages in thread
From: Jeff Johnson @ 2023-11-06 18:21 UTC (permalink / raw
To: Kalle Valo; +Cc: ath11k, linux-wireless, linux-kernel, ath12k, Jeff Johnson
Both ath11k and ath12k define the following:
struct ieee80211_ops *ops;
This is being flagged by checkpatch.pl:
WARNING: struct ieee80211_ops should normally be const
But it turns out that in both cases this is unused, so remove it.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
Jeff Johnson (2):
wifi: ath11k: Remove struct ath11k::ops
wifi: ath12k: Remove struct ath12k::ops
drivers/net/wireless/ath/ath11k/core.h | 1 -
drivers/net/wireless/ath/ath12k/core.h | 3 +--
2 files changed, 1 insertion(+), 3 deletions(-)
---
base-commit: ac2f43d3d34e52b0d388b4c573ff6bbac90235b9
change-id: 20231103-ath12k-remove-ieee80211_ops-160d865e9ea4
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] wifi: ath11k: Remove struct ath11k::ops
2023-11-06 18:21 [PATCH 0/2] wifi: ath: Remove unused struct ieee80211_ops *ops Jeff Johnson
@ 2023-11-06 18:21 ` Jeff Johnson
2023-11-22 18:24 ` Kalle Valo
2023-11-06 18:21 ` [PATCH 2/2] wifi: ath12k: Remove struct ath12k::ops Jeff Johnson
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Johnson @ 2023-11-06 18:21 UTC (permalink / raw
To: Kalle Valo; +Cc: ath11k, linux-wireless, linux-kernel, ath12k, Jeff Johnson
Currently struct ath11k defines the following member:
struct ieee80211_ops *ops;
This is being flagged by checkpatch.pl:
WARNING: struct ieee80211_ops should normally be const
The original plan was to add the const qualifier. However, it turns
out this is actually unused, so remove it.
No functional changes, compile tested only.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/net/wireless/ath/ath11k/core.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/core.h b/drivers/net/wireless/ath/ath11k/core.h
index f12b606e2d2e..7e3b6779f4e9 100644
--- a/drivers/net/wireless/ath/ath11k/core.h
+++ b/drivers/net/wireless/ath/ath11k/core.h
@@ -599,7 +599,6 @@ struct ath11k {
struct ath11k_base *ab;
struct ath11k_pdev *pdev;
struct ieee80211_hw *hw;
- struct ieee80211_ops *ops;
struct ath11k_pdev_wmi *wmi;
struct ath11k_pdev_dp dp;
u8 mac_addr[ETH_ALEN];
--
2.42.0
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] wifi: ath12k: Remove struct ath12k::ops
2023-11-06 18:21 [PATCH 0/2] wifi: ath: Remove unused struct ieee80211_ops *ops Jeff Johnson
2023-11-06 18:21 ` [PATCH 1/2] wifi: ath11k: Remove struct ath11k::ops Jeff Johnson
@ 2023-11-06 18:21 ` Jeff Johnson
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Johnson @ 2023-11-06 18:21 UTC (permalink / raw
To: Kalle Valo; +Cc: ath11k, linux-wireless, linux-kernel, ath12k, Jeff Johnson
Currently struct ath12k defines the following member:
struct ieee80211_ops *ops;
This is being flagged by checkpatch.pl:
WARNING: struct ieee80211_ops should normally be const
The original plan was to add the const qualifier. However, it turns
out this is actually unused, so remove it.
No functional changes, compile tested only.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/net/wireless/ath/ath12k/core.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h
index 68c42ca44fcb..6dbe817d2ec7 100644
--- a/drivers/net/wireless/ath/ath12k/core.h
+++ b/drivers/net/wireless/ath/ath12k/core.h
@@ -1,7 +1,7 @@
/* SPDX-License-Identifier: BSD-3-Clause-Clear */
/*
* Copyright (c) 2018-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
*/
#ifndef ATH12K_CORE_H
@@ -467,7 +467,6 @@ struct ath12k {
struct ath12k_base *ab;
struct ath12k_pdev *pdev;
struct ieee80211_hw *hw;
- struct ieee80211_ops *ops;
struct ath12k_wmi_pdev *wmi;
struct ath12k_pdev_dp dp;
u8 mac_addr[ETH_ALEN];
--
2.42.0
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] wifi: ath11k: Remove struct ath11k::ops
2023-11-06 18:21 ` [PATCH 1/2] wifi: ath11k: Remove struct ath11k::ops Jeff Johnson
@ 2023-11-22 18:24 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2023-11-22 18:24 UTC (permalink / raw
To: Jeff Johnson; +Cc: ath11k, linux-wireless, linux-kernel, ath12k, Jeff Johnson
Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> Currently struct ath11k defines the following member:
> struct ieee80211_ops *ops;
>
> This is being flagged by checkpatch.pl:
> WARNING: struct ieee80211_ops should normally be const
>
> The original plan was to add the const qualifier. However, it turns
> out this is actually unused, so remove it.
>
> No functional changes, compile tested only.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
2 patches applied to ath-next branch of ath.git, thanks.
199a78565cc2 wifi: ath11k: Remove struct ath11k::ops
3b6ec0409fe8 wifi: ath12k: Remove struct ath12k::ops
--
https://patchwork.kernel.org/project/linux-wireless/patch/20231106-ath12k-remove-ieee80211_ops-v1-1-d72cef1a855b@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-22 18:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-06 18:21 [PATCH 0/2] wifi: ath: Remove unused struct ieee80211_ops *ops Jeff Johnson
2023-11-06 18:21 ` [PATCH 1/2] wifi: ath11k: Remove struct ath11k::ops Jeff Johnson
2023-11-22 18:24 ` Kalle Valo
2023-11-06 18:21 ` [PATCH 2/2] wifi: ath12k: Remove struct ath12k::ops Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).