* [PATCH] wifi: ath11k: drop NULL pointer check in ath11k_dp_rx_mon_dest_process()
@ 2023-09-07 8:38 Dmitry Antipov
2023-09-07 14:52 ` Jeff Johnson
2023-09-28 15:46 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Antipov @ 2023-09-07 8:38 UTC (permalink / raw
To: Jeff Johnson
Cc: Kalle Valo, linux-wireless, lvc-project, ath11k, Dmitry Antipov
Since 'srng_list' is a fixed-size array of 'struct hal_srng'
in 'struct ath11_hal', any of its member can't be NULL and
so relevant check may be dropped.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
---
drivers/net/wireless/ath/ath11k/dp_rx.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 146201d8dba2..4463e308968c 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -5094,13 +5094,6 @@ static void ath11k_dp_rx_mon_dest_process(struct ath11k *ar, int mac_id,
mon_dst_srng = &ar->ab->hal.srng_list[ring_id];
- if (!mon_dst_srng) {
- ath11k_warn(ar->ab,
- "HAL Monitor Destination Ring Init Failed -- %p",
- mon_dst_srng);
- return;
- }
-
spin_lock_bh(&pmon->mon_lock);
ath11k_hal_srng_access_begin(ar->ab, mon_dst_srng);
--
2.41.0
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] wifi: ath11k: drop NULL pointer check in ath11k_dp_rx_mon_dest_process()
2023-09-07 8:38 [PATCH] wifi: ath11k: drop NULL pointer check in ath11k_dp_rx_mon_dest_process() Dmitry Antipov
@ 2023-09-07 14:52 ` Jeff Johnson
2023-09-28 15:46 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Johnson @ 2023-09-07 14:52 UTC (permalink / raw
To: Dmitry Antipov; +Cc: Kalle Valo, linux-wireless, lvc-project, ath11k
On 9/7/2023 1:38 AM, Dmitry Antipov wrote:
> Since 'srng_list' is a fixed-size array of 'struct hal_srng'
> in 'struct ath11_hal', any of its member can't be NULL and
> so relevant check may be dropped.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/net/wireless/ath/ath11k/dp_rx.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
> index 146201d8dba2..4463e308968c 100644
> --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
> @@ -5094,13 +5094,6 @@ static void ath11k_dp_rx_mon_dest_process(struct ath11k *ar, int mac_id,
>
> mon_dst_srng = &ar->ab->hal.srng_list[ring_id];
>
> - if (!mon_dst_srng) {
> - ath11k_warn(ar->ab,
> - "HAL Monitor Destination Ring Init Failed -- %p",
> - mon_dst_srng);
> - return;
> - }
> -
> spin_lock_bh(&pmon->mon_lock);
>
> ath11k_hal_srng_access_begin(ar->ab, mon_dst_srng);
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] wifi: ath11k: drop NULL pointer check in ath11k_dp_rx_mon_dest_process()
2023-09-07 8:38 [PATCH] wifi: ath11k: drop NULL pointer check in ath11k_dp_rx_mon_dest_process() Dmitry Antipov
2023-09-07 14:52 ` Jeff Johnson
@ 2023-09-28 15:46 ` Kalle Valo
2023-09-28 17:22 ` Dmitry Antipov
1 sibling, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2023-09-28 15:46 UTC (permalink / raw
To: Dmitry Antipov
Cc: Jeff Johnson, linux-wireless, lvc-project, ath11k, Dmitry Antipov
Dmitry Antipov <dmantipov@yandex.ru> wrote:
> Since 'srng_list' is a fixed-size array of 'struct hal_srng'
> in 'struct ath11_hal', any of its member can't be NULL and
> so relevant check may be dropped.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Failed to apply.
error: patch failed: drivers/net/wireless/ath/ath11k/dp_rx.c:5094
error: drivers/net/wireless/ath/ath11k/dp_rx.c: patch does not apply
stg import: Diff does not apply cleanly
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230907083852.10775-1-dmantipov@yandex.ru/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] wifi: ath11k: drop NULL pointer check in ath11k_dp_rx_mon_dest_process()
2023-09-28 15:46 ` Kalle Valo
@ 2023-09-28 17:22 ` Dmitry Antipov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Antipov @ 2023-09-28 17:22 UTC (permalink / raw
To: Kalle Valo; +Cc: Jeff Johnson, linux-wireless, lvc-project, ath11k
On 9/28/23 18:46, Kalle Valo wrote:
> Patch set to Changes Requested.
Probably I miss something around your internal ath-specific workflow
but AFAICS this fix is not needed for ath-next branch of ath.git
(there is no redundant NULL pointer check there).
Dmitry
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-28 17:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-07 8:38 [PATCH] wifi: ath11k: drop NULL pointer check in ath11k_dp_rx_mon_dest_process() Dmitry Antipov
2023-09-07 14:52 ` Jeff Johnson
2023-09-28 15:46 ` Kalle Valo
2023-09-28 17:22 ` Dmitry Antipov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).