From: Aditya Kumar Singh <quic_adisi@quicinc.com>
To: Wen Gong <quic_wgong@quicinc.com>, <ath11k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>, <kvalo@kernel.org>,
<quic_jjohnson@quicinc.com>
Subject: Re: [PATCH v6 05/13] wifi: ath11k: update regulatory rules when connect to AP on 6 GHz band for station
Date: Fri, 22 Sep 2023 18:48:26 +0530 [thread overview]
Message-ID: <47e2ce79-2885-489c-b567-fdbcb120d056@quicinc.com> (raw)
In-Reply-To: <1f739d62-d5c0-a64b-ef9b-d5fd7b79755e@quicinc.com>
On 9/22/23 15:32, Wen Gong wrote:
> On 9/22/2023 5:39 PM, Aditya Kumar Singh wrote:
>> On 9/20/23 13:53, Wen Gong wrote:
>>
>>> + if (ath11k_mac_supports_6ghz_cc_ext(ar) &&
>>> + ctx->def.chan->band == NL80211_BAND_6GHZ &&
>>> + arvif->vdev_type == WMI_VDEV_TYPE_STA) {
>>> + reg_info = &ab->reg_info_store[ar->pdev_idx];
>>> + power_type = vif->bss_conf.power_type;
>>> + ath11k_dbg(ab, ATH11K_DBG_MAC, "mac chanctx power type %d\n",
>>> + power_type);
>>> + if (power_type == IEEE80211_REG_UNSET_AP)
>>> + power_type = IEEE80211_REG_LPI_AP;
>> Why having _UNSET_ power type in vif->bss_conf.power_type is fine?
>> Typically, during association, we would be setting this from the
>> beacon/association response frame's HE 6 GHz Operation Info Field. So
>> is it fine if the field is carrying some info which we don't know (or
>> may be don't support it yet)? Why are we masking it with _LPI_ mode?
>>
>> Also, I see that currently mac80211 only sets LPI or SP. So let's say
>> STA is trying to connect to VLP AP, mac80211 will set it as _UNSET_.
>> And then here, we will be treating it as LPI AP. Is that fine?
>
> Currently only SP/LPI are defined in "Table E-12—Regulatory Info
> subfield encoding in the United States" of IEEE Std 802.11ax™‐2021.
>
> So maybe I need to set power_type to VLP when it is UNSET here.
Yeah, or may be deny association if we don't support that mode? I would
let others comment on this.
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2023-09-22 13:18 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 8:23 [PATCH v6 00/13] wifi: ath11k: add support for 6 GHz station for various modes : LPI, SP and VLP Wen Gong
2023-09-20 8:23 ` [PATCH v6 01/13] wifi: ath11k: add support to select 6 GHz regulatory type Wen Gong
2023-09-20 8:23 ` [PATCH v6 02/13] wifi: ath11k: store cur_regulatory_info for each radio Wen Gong
2023-09-21 19:51 ` Jeff Johnson
2023-09-29 13:16 ` Kalle Valo
2023-09-20 8:23 ` [PATCH v6 03/13] wifi: ath11k: fix a possible dead lock caused by ab->base_lock Wen Gong
2023-09-21 19:54 ` Jeff Johnson
2023-09-25 10:35 ` Kalle Valo
2023-10-02 15:51 ` Kalle Valo
2023-09-20 8:23 ` [PATCH v6 04/13] wifi: ath11k: update regulatory rules when interface added Wen Gong
2023-09-21 19:58 ` Jeff Johnson
2023-09-22 9:32 ` Aditya Kumar Singh
2023-09-20 8:23 ` [PATCH v6 05/13] wifi: ath11k: update regulatory rules when connect to AP on 6 GHz band for station Wen Gong
2023-09-21 19:59 ` Jeff Johnson
2023-09-22 9:39 ` Aditya Kumar Singh
2023-09-22 10:02 ` Wen Gong
2023-09-22 13:18 ` Aditya Kumar Singh [this message]
2023-09-25 10:43 ` Wen Gong
2023-09-25 10:52 ` Aditya Kumar Singh
2023-09-25 10:57 ` Wen Gong
2023-09-20 8:23 ` [PATCH v6 06/13] wifi: ath11k: save power spectral density(psd) of regulatory rule Wen Gong
2023-09-21 20:00 ` Jeff Johnson
2023-09-22 9:49 ` Aditya Kumar Singh
2023-09-20 8:23 ` [PATCH v6 07/13] wifi: ath11k: add parse of transmit power envelope element Wen Gong
2023-09-21 20:04 ` Jeff Johnson
2023-09-20 8:23 ` [PATCH v6 08/13] wifi: ath11k: save max tx power in vdev start response event from firmware Wen Gong
2023-09-21 20:04 ` Jeff Johnson
2023-09-20 8:23 ` [PATCH v6 09/13] wifi: ath11k: fill parameters for vdev set tpc power WMI command Wen Gong
2023-09-21 20:09 ` Jeff Johnson
2023-09-21 20:11 ` Jeff Johnson
2023-09-25 10:46 ` Wen Gong
2023-09-29 13:18 ` Kalle Valo
2023-09-20 8:23 ` [PATCH v6 10/13] wifi: ath11k: add WMI_TLV_SERVICE_EXT_TPC_REG_SUPPORT service bit Wen Gong
2023-09-21 20:13 ` Jeff Johnson
2023-09-20 8:23 ` [PATCH v6 11/13] wifi: ath11k: discard BSS_CHANGED_TXPOWER when EXT_TPC_REG_SUPPORT for 6 GHz Wen Gong
2023-09-21 20:39 ` Jeff Johnson
2023-09-22 9:04 ` Aditya Kumar Singh
2023-09-22 9:17 ` Wen Gong
2023-09-20 8:23 ` [PATCH v6 12/13] wifi: ath11k: add handler for WMI_VDEV_SET_TPC_POWER_CMDID Wen Gong
2023-09-21 20:37 ` Jeff Johnson
2023-09-20 8:23 ` [PATCH v6 13/13] wifi: ath11k: send TPC power to firmware for 6 GHz station Wen Gong
2023-09-21 20:38 ` Jeff Johnson
2023-09-22 9:24 ` Aditya Kumar Singh
2023-09-22 10:12 ` Wen Gong
2023-09-22 13:25 ` Aditya Kumar Singh
2023-09-25 2:15 ` Wen Gong
2023-09-25 5:41 ` Aditya Kumar Singh
2023-09-25 10:50 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47e2ce79-2885-489c-b567-fdbcb120d056@quicinc.com \
--to=quic_adisi@quicinc.com \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_wgong@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).