From: Kalle Valo <kvalo@kernel.org>
To: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>
Cc: Baochen Qiang <quic_bqiang@quicinc.com>,
<ath11k@lists.infradead.org>, <manivannan.sadhasivam@linaro.org>,
<linux-wireless@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <mhi@lists.linux.dev>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH v7 2/3] net: qrtr: support suspend/hibernation
Date: Fri, 05 Apr 2024 16:27:35 +0300 [thread overview]
Message-ID: <8734s02b3s.fsf@kernel.org> (raw)
In-Reply-To: <20240305021320.3367-3-quic_bqiang@quicinc.com> (Baochen Qiang's message of "Tue, 5 Mar 2024 10:13:19 +0800")
Hi netdev maintainers,
Baochen Qiang <quic_bqiang@quicinc.com> writes:
> MHI devices may not be destroyed during suspend/hibernation, so need
> to unprepare/prepare MHI channels throughout the transition, this is
> done by adding suspend/resume callbacks.
>
> The suspend callback is called in the late suspend stage, this means
> MHI channels are still alive at suspend stage, and that makes it
> possible for an MHI controller driver to communicate with others over
> those channels at suspend stage. While the resume callback is called
> in the early resume stage, for a similar reason.
>
> Also note that we won't do unprepare/prepare when MHI device is in
> suspend state because it's pointless if MHI is only meant to go through
> a suspend/resume transition, instead of a complete power cycle.
>
> Tested-on: WCN6855 hw2.0 PCI
> WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.30
>
> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Could I take this patch via ath.git tree? Full patch here (same patch
but links to both patchwork projects):
https://patchwork.kernel.org/project/linux-wireless/patch/20240305021320.3367-3-quic_bqiang@quicinc.com/
https://patchwork.kernel.org/project/netdevbpf/patch/20240305021320.3367-3-quic_bqiang@quicinc.com/
I ask because we need it to get hibernation working on ath11k (and ath12k):
https://patchwork.kernel.org/project/linux-wireless/patch/20240305021320.3367-4-quic_bqiang@quicinc.com/
Kalle
next prev parent reply other threads:[~2024-04-05 13:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 2:13 [PATCH v7 0/3] wifi: ath11k: hibernation support Baochen Qiang
2024-03-05 2:13 ` [PATCH v7 1/3] bus: mhi: host: add mhi_power_down_keep_dev() Baochen Qiang
2024-04-01 10:49 ` Manivannan Sadhasivam
2024-04-05 12:30 ` Kalle Valo
2024-03-05 2:13 ` [PATCH v7 2/3] net: qrtr: support suspend/hibernation Baochen Qiang
2024-04-05 13:27 ` Kalle Valo [this message]
2024-04-09 9:29 ` Kalle Valo
2024-04-09 21:36 ` Jakub Kicinski
2024-04-09 11:43 ` Kalle Valo
2024-03-05 2:13 ` [PATCH v7 3/3] wifi: ath11k: support hibernation Baochen Qiang
2024-03-05 2:46 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734s02b3s.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_bqiang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).