From: Kalle Valo <kvalo@kernel.org>
To: Baochen Qiang <quic_bqiang@quicinc.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
"Kalle Valo (QUIC)" <quic_kvalo@quicinc.com>,
<ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <mhi@lists.linux.dev>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 1/3] bus: mhi: host: add mhi_power_down_keep_dev()
Date: Thu, 29 Feb 2024 21:35:34 +0200 [thread overview]
Message-ID: <87le7383nd.fsf@kernel.org> (raw)
In-Reply-To: <531daaa9-cf14-4812-8908-c617bd25bc08@quicinc.com> (Baochen Qiang's message of "Thu, 29 Feb 2024 18:33:43 +0800")
Baochen Qiang <quic_bqiang@quicinc.com> writes:
> On 2/29/2024 6:12 PM, Manivannan Sadhasivam wrote:
>> On Wed, Feb 28, 2024 at 10:22:41AM +0800, Baochen Qiang wrote:
>>> ath11k fails to resume:
>>>
>>> ath11k_pci 0000:06:00.0: timeout while waiting for restart complete
>>>
>>> This happens because when calling mhi_sync_power_up() the MHI subsystem
>>> eventually calls device_add() from mhi_create_devices() but the device
>>> creation is deferred:
>>>
>>> mhi mhi0_IPCR: Driver qcom_mhi_qrtr force probe deferral
>>>
>>> The reason for deferring device creation is explained in dpm_prepare():
>>>
>>> /*
>>> * It is unsafe if probing of devices will happen during suspend or
>>> * hibernation and system behavior will be unpredictable in this case.
>>> * So, let's prohibit device's probing here and defer their probes
>>> * instead. The normal behavior will be restored in dpm_complete().
>>> */
>>>
>>> Because the device probe is deferred, the qcom_mhi_qrtr_probe() is not
>>> called and thus MHI channels are not prepared:
>>>
>>> So what this means that QRTR is not delivering messages and the QMI connection
>>> is not working between ath11k and the firmware, resulting a failure in firmware
>>> initialization.
>>>
>>> To fix this add new function mhi_power_down_keep_dev() which doesn't destroy
>>> the devices for channels during power down. This way we avoid probe defer issue
>>> and finally can get ath11k hibernation working with the following patches.
>>>
>>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.30
>>>
>>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
>>
>> Did Kalle co-author this patch? If so, his Co-developed-by tag should
>> be added.
>
> Hmm, I'm not sure... I would like Kalle's thoughts on this.
IIRC I did only some simple cleanup before submitting the patch so I
don't think Co-developed-by is justified. I'm also fine with removing my
Signed-off-by.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-02-29 19:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 2:22 [PATCH v4 0/3] wifi: ath11k: hibernation support Baochen Qiang
2024-02-28 2:22 ` [PATCH v4 1/3] bus: mhi: host: add mhi_power_down_keep_dev() Baochen Qiang
2024-02-28 15:09 ` Jeff Johnson
2024-02-29 10:12 ` Manivannan Sadhasivam
2024-02-29 10:33 ` Baochen Qiang
2024-02-29 19:35 ` Kalle Valo [this message]
2024-03-01 2:04 ` Baochen Qiang
2024-03-01 12:25 ` Manivannan Sadhasivam
2024-03-04 2:01 ` Baochen Qiang
2024-02-28 2:22 ` [PATCH v4 2/3] net: qrtr: support suspend/hibernation Baochen Qiang
2024-02-28 15:12 ` Jeff Johnson
2024-02-29 10:12 ` Manivannan Sadhasivam
2024-02-28 2:22 ` [PATCH v4 3/3] wifi: ath11k: support hibernation Baochen Qiang
2024-02-28 15:31 ` Jeff Johnson
2024-02-29 2:30 ` Baochen Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le7383nd.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_bqiang@quicinc.com \
--cc=quic_kvalo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).