From: Carl Huang <quic_cjhuang@quicinc.com>
To: Kalle Valo <kvalo@kernel.org>, Luca Weiss <luca.weiss@fairphone.com>
Cc: <quic_cjhuang@quicinc.com>, <ath11k@lists.infradead.org>,
<linux-wireless@vger.kernel.org>, <regressions@lists.linux.dev>
Subject: Re: [PATCH 1/2] wifi: ath11k: supports 2 station interfaces
Date: Fri, 10 May 2024 20:03:28 +0800 [thread overview]
Message-ID: <93c15c59-f24c-4472-ae7e-969fd1e3bfec@quicinc.com> (raw)
In-Reply-To: <87jzk2km0g.fsf@kernel.org>
On 2024/5/10 18:18, Kalle Valo wrote:
> "Luca Weiss" <luca.weiss@fairphone.com> writes:
>
>> On Fri Jul 14, 2023 at 4:38 AM CEST, Carl Huang wrote:
>>> Add hardware parameter support_dual_stations to indicate
>>> whether 2 station interfaces are supported. For chips which
>>> support this feature, limit total number of AP interface and
>>> mesh point to 1. The max interfaces are 3 for such chips.
>>>
>>> The chips affected are:
>>> QCA6390 hw2.0
>>> WCN6855 hw2.0
>>> WCN6855 hw2.1
>>> Other chips are not affected.
>>>
>>> For affected chips, remove radar_detect_widths because now
>>> num_different_channels is set to 2. radar_detect_widths can
>>> be set only when num_different_channels is 1. See mac80211
>>> function wiphy_verify_combinations for details.
>>>
>>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
>>
>> Hi Carl,
>>
>> Unfortunately this commit breaks wifi on a QCM6490 smartphone
>> (qcm6490-fairphone-fp5) and makes the board crash.
>>
>> Reverting this commit (plus for conflict resolution 5dc9d1a55e95 ("wifi:
>> ath11k: add support for QCA2066") and 24395ec11707 ("wifi: ath11k:
>> provide address list if chip supports 2 stations")) makes wifi work
>> again.
>
> Thanks for the report. So the broken commit is:
>
> f019f4dff2e4 wifi: ath11k: support 2 station interfaces
>
> This went into v6.9-rc1 so I'm guessing that WCN6750 support will be
> fully broken in v6.9? Not good. And most likely Linus will release v6.9
> on Sunday so it's too late to get a fix included in the final release.
>
> Carl, can you fix this ASAP? Or should we just revert the broken
> commits?
>
> Adding this to our regression tracking:
>
> #regzbot introduced: f019f4dff2e4 ^
> #regzbot title: ath11k: WCN6750 firmware crashes during initialisation
>
Kalle, looks we're not able to fix it before Sunday as I don't have
WCN6750 setup to verify the fix. The fix could be to define a dedicated
function ath11k_init_wmi_config_wcn6750() for WCN6750. I'll send the
patch out so others like Luca can have a try.
next prev parent reply other threads:[~2024-05-10 12:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 2:37 [PATCH 0/2] wifi: ath11k: support 2 station interfaces Carl Huang
2023-07-14 2:38 ` [PATCH 1/2] wifi: ath11k: supports " Carl Huang
2024-02-13 16:17 ` Kalle Valo
2024-02-15 11:23 ` Kalle Valo
2024-05-10 8:22 ` Luca Weiss
2024-05-10 10:18 ` Kalle Valo
2024-05-10 12:03 ` Carl Huang [this message]
2024-05-10 13:04 ` Carl Huang
2024-05-10 13:26 ` Luca Weiss
2024-05-11 2:50 ` Carl Huang
2024-05-10 13:57 ` Kalle Valo
2024-05-11 3:12 ` Carl Huang
2024-05-16 11:45 ` Linux regression tracking (Thorsten Leemhuis)
2024-05-16 14:11 ` Jeff Johnson
2024-05-17 5:25 ` Kalle Valo
2024-05-17 6:04 ` Thorsten Leemhuis
2024-05-17 7:39 ` Kalle Valo
2024-05-19 17:51 ` Linux regression tracking (Thorsten Leemhuis)
2024-05-10 11:35 ` Carl Huang
2024-05-10 12:58 ` Luca Weiss
2023-07-14 2:38 ` [PATCH 2/2] wifi: ath11k: reports address list if chip supports 2 stations Carl Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93c15c59-f24c-4472-ae7e-969fd1e3bfec@quicinc.com \
--to=quic_cjhuang@quicinc.com \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).