From: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>,
<ath12k@lists.infradead.org>, <ath11k@lists.infradead.org>,
<ath10k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/3] wifi: ath10k: replace ENOTSUPP with EOPNOTSUPP
Date: Thu, 4 Jan 2024 08:33:52 +0530 [thread overview]
Message-ID: <9636aec8-8fa3-6129-294a-69dec53276fa@quicinc.com> (raw)
In-Reply-To: <2269025d-d1ef-4940-a438-c67d3d94baf9@quicinc.com>
On 1/3/2024 10:06 PM, Jeff Johnson wrote:
> On 1/2/2024 8:12 PM, Karthikeyan Periyasamy wrote:
>> ENOTSUPP is not a standard error code, don't use it. Replace with
>> EOPNOTSUPP instead.
>>
>> No functional changes, compile tested only.
>>
>> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
>> ---
>> diff --git a/drivers/net/wireless/ath/ath10k/htt.c b/drivers/net/wireless/ath/ath10k/htt.c
>> index 907e1e13871a..3835c5cc07f9 100644
>> --- a/drivers/net/wireless/ath/ath10k/htt.c
>> +++ b/drivers/net/wireless/ath/ath10k/htt.c
>> @@ -2,6 +2,8 @@
>> /*
>> * Copyright (c) 2005-2011 Atheros Communications Inc.
>> * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
>> + * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved.
> You are not working on behalf of The Linux Foundation so you should not
> be adding or modifying Linux Foundation copyrights
Sure
>> + * Copyright (c) 2021-2024 Qualcomm Innovation Center, Inc. All rights reserved.
> And this should only have 2024 since there were not any Qualcomm changes
> in 2021-2023
Sure
>> diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> index 0ce08e9a0a3d..9a1889599729 100644
>> --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> @@ -3,6 +3,7 @@
>> * Copyright (c) 2005-2011 Atheros Communications Inc.
>> * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
>> * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved.
>> + * Copyright (c) 2021-2024 Qualcomm Innovation Center, Inc. All rights reserved.
> Again this should only have 2024
Will address in the next version of the patch
Thanks,
Karthikeyan
prev parent reply other threads:[~2024-01-04 3:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 4:12 [PATCH 0/3] wifi: ath: replace ENOTSUPP with EOPNOTSUPP Karthikeyan Periyasamy
2024-01-03 4:12 ` [PATCH 1/3] wifi: ath12k: " Karthikeyan Periyasamy
2024-01-03 16:23 ` Jeff Johnson
2024-01-03 4:12 ` [PATCH 2/3] wifi: ath11k: " Karthikeyan Periyasamy
2024-01-03 16:23 ` Jeff Johnson
2024-01-03 4:12 ` [PATCH 3/3] wifi: ath10k: " Karthikeyan Periyasamy
2024-01-03 16:36 ` Jeff Johnson
2024-01-04 3:03 ` Karthikeyan Periyasamy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9636aec8-8fa3-6129-294a-69dec53276fa@quicinc.com \
--to=quic_periyasa@quicinc.com \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).